With LO 5.0 copying forms in Base does not work anymore. Using embedded database.
Confirming on Version: 5.0.0.4 Build ID: cf112dc905650fb985306a7a03d2fe3fcc6c978f Locale: fr-FR (fr.UTF-8) OSX 10.10.4 regression
Confirming also in Version: 5.1.0.0.alpha1+ Build ID: e2281331b1ab40288494ab3659d9c66e13d3e905 Locale : fr-FR (fr.UTF-8) OSX 10.10.4
Works in LO 4422, 4432
Could confirm. There is no possibility to paste the form I have tried to copy with contextmenue or in other way (Ctrl+C). The same behavior with reports here. Works right with LO 4.4.5.2 on OpenSUSE 13.2 64bit rpm Linux, fails since LO 5.0.0.4
6d97afa867b5e600b8251993d389bf41e88ae831 is the first bad commit commit 6d97afa867b5e600b8251993d389bf41e88ae831 Author: Matthew Francis <mjay.francis@gmail.com> Date: Wed May 27 20:09:05 2015 +0800 source-hash-fb14be5f8f74f83ba89e15f891ddf1f753dcc62f commit fb14be5f8f74f83ba89e15f891ddf1f753dcc62f Author: Noel Grandin <noel@peralex.com> AuthorDate: Thu Mar 12 14:53:28 2015 +0200 Commit: Noel Grandin <noel@peralex.com> CommitDate: Wed Mar 18 14:23:50 2015 +0200 create new 'enum class' SotClipboardFormatId to unify types of which there are several. There are some issues here I am unsure of - the SW and SC and CHART2 modules essentially ignore the enum values and assign their own ids Perhaps I should change them to use the common values and create new enum values where necessary? - the sc/qa/ and sq/qa/ and starmath/qa/ code was doing some dodgy stuff. I translated the code to pass down the stuff numeric values to the underlying code, but perhaps further fixing is necessary? Change-Id: Ic06d723e404481e3f1bca67c43b70321b764d923 :040000 040000 90cec370a34cb9d0565de2fcccf0bd07768ca3ba 1b64b33a6d8f0312b688376ed7ac768ad83f9fa2 M opt
Thank you Schaber for your analysis, let's put Noel in cc.
See also one follow up commit, if relevant (I can't tell): commit 1bcf792993c3d88acfd7ede4567701c5dd6e7e62 (patch) tdf#92037 fix dragging DataSources field into document
How do I reproduce this, please? (not being familiar with how forms work in Base).
Created attachment 117666 [details] Test file Open the DB file On the left pane go to Forms Right-click on Form1 in the middle pane and select Copy Right-click again If Paste is there: OK If Paste is missing: Bug
On pc Debian x86-64 with master sources updated today, I could reproduce this. Here are some console logs: warn:legacy.tools:14360:1:sot/source/base/exchange.cxx:361: SotExchange::GetFormatDataFlavor(): DataFlavor not initialized (soffice:14360): Gtk-CRITICAL **: gtk_clipboard_set_with_owner: assertion 'targets != NULL' failed warn:legacy.tools:14360:1:sot/source/base/exchange.cxx:361: SotExchange::GetFormatDataFlavor(): DataFlavor not initialized warn:legacy.tools:14360:1:sot/source/base/exchange.cxx:361: SotExchange::GetFormatDataFlavor(): DataFlavor not initialized
Noel: could there be a relation with http://cgit.freedesktop.org/libreoffice/core/commit/?id=1bcf792993c3d88acfd7ede4567701c5dd6e7e62 ?
I added some traces: rL.size() = 12 i = 143 that's why bRet is false here http://opengrok.libreoffice.org/xref/core/sot/source/base/exchange.cxx#361 (sorry for my previous comment, I quoted the same commit as comment7)
Noel Grandin committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=f7d65b04126b614bbb0b1bc0e7b6309900d4dc8d tdf#93018 - Copying forms not working anymore It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=0c08cb23b4902f19ed0e1050b5c9a52164c0d2ac tdf#93018 - Copying forms not working anymore (part2) It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Can other applications or generally other parts be affected as well?
(In reply to Gerhard Schaber from comment #15) > Can other applications or generally other parts be affected as well? I think so. Noel: do you confirm? BTW, thank you for your quick patches! :-) (I'm building right now to give it a new try, if ok, I'll put VERIFIED + support your patches for 5.0 branch
Thanks for the quick patch.
On pc Debian x86-64 with master sources updated today, I don't reproduce the problem.
(In reply to Gerhard Schaber from comment #15) > Can other applications or generally other parts be affected as well? Other parts of the LO suite could be impacted in a similar way, yes.
Noel Grandin committed a patch related to this issue. It has been pushed to "libreoffice-5-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=6bc20fff1a1cdd6550e5130356b06de149ee12f6&h=libreoffice-5-0 tdf#93018 - Copying forms not working anymore It will be available in 5.0.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "libreoffice-5-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=cf6869230c3676db068e774a4e2b0a0e43c85390&h=libreoffice-5-0 tdf#93018 - Copying forms not working anymore (part2) It will be available in 5.0.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Could confirm this bug has been gone with LO 5.0.1.2. So I put this bug to Resolved and fixed.
Migrating Whiteboard tags to Keywords: (bibisected) [NinjaEdit]