Bug 93309 - Show/Hide pane button off by one pixel
Summary: Show/Hide pane button off by one pixel
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
5.0.0.0.alpha0+ Master
Hardware: Other All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
: 92087 94174 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-08-09 19:22 UTC by Yousuf Philips (jay) (retired)
Modified: 2024-11-17 03:16 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
color bar (6.65 KB, image/png)
2015-09-12 22:10 UTC, Yousuf Philips (jay) (retired)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2015-08-09 19:22:48 UTC
Taken from bug 83527 comment 24:

attachment 116167 [details]: sidebar button on left pane

Tomaz there is small problem with the button when its on the left panes in impress and draw, as its off by 1 pixel and should be shifted right.

----------------

It seems it also affects vertical panes like the color bar pane in impress (View > Toolbars > Color Bar).
Comment 1 tommy27 2015-08-19 18:28:00 UTC
hi Jay, I checked under Win8.1 x64 and it looks fine in LibO 5.0.0.4 and  5.1.0.0.alpha1+
Build ID: 7d3fa6bae9f7a755eb2d0ca24bf1afd5f3646bb7
TinderBox: Win-x86@39, Branch:master, Time: 2015-08-09_08:38:08
Locale: it-IT (it_IT)

is that a Linux specific bug?
Comment 2 Buovjaga 2015-09-12 16:30:16 UTC
Confirmed.

Manjaro Linux KDE Plasma 5, 64-bit
Version: 5.0.1.2.0+
Build ID: 5.0.1.2 Arch Linux build-1
Locale: fi-FI (fi_FI.UTF-8)
Comment 3 Yousuf Philips (jay) (retired) 2015-09-12 18:13:46 UTC
(In reply to tommy27 from comment #1)
> hi Jay, I checked under Win8.1 x64 and it looks fine in LibO 5.0.0.4 and 
> 5.1.0.0.alpha1+

Take a screenshot of it, open it in your favourite image editor and zoom in or else you may not notice it.

> is that a Linux specific bug?

I doubt it would be.
Comment 4 V Stuart Foote 2015-09-12 19:43:25 UTC
On Windows 10 Pro 64-bit with current master
Version: 5.1.0.0.alpha1+
Build ID: 88c51cd55d1a9b29e62269c53b3923770253ab07
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2015-09-11_13:09:15
Locale: en-US (en_US)

The Show/Hide grips on Vertical Frames attached left are off by ~1px.

But, the button in horizontal panes attached bottom (e.g. the Color bar in Impress/Draw) or top (e.g. F4 - Data Sources in Writer) seem correctly aligned in both selected and mouse over mode.

And no issue when pane for widget is attached right.

So, think misalignment is just affecting when widget being controlled is left attached.
Comment 5 Yousuf Philips (jay) (retired) 2015-09-12 22:10:54 UTC
Created attachment 118656 [details]
color bar

(In reply to V Stuart Foote from comment #4)
> But, the button in horizontal panes attached bottom (e.g. the Color bar in
> Impress/Draw) or top (e.g. F4 - Data Sources in Writer) seem correctly
> aligned in both selected and mouse over mode.

Screenshot will show otherwise. The problem with the color bar is that the height of the draggable area is 6px (from gray line to gray line), while the pane button is 7px. With the data sources, it is the same as the pane, where the space is 7px and the button is off by 1px.
Comment 6 V Stuart Foote 2015-09-12 23:48:12 UTC
(In reply to Yousuf (Jay) Philips from comment #5)
> Created attachment 118656 [details]
> color bar
> 
> (In reply to V Stuart Foote from comment #4)
> > But, the button in horizontal panes attached bottom (e.g. the Color bar in
> > Impress/Draw) or top (e.g. F4 - Data Sources in Writer) seem correctly
> > aligned in both selected and mouse over mode.
> 
> Screenshot will show otherwise. The problem with the color bar is that the
> height of the draggable area is 6px (from gray line to gray line), while the
> pane button is 7px. With the data sources, it is the same as the pane, where
> the space is 7px and the button is off by 1px.

Hmm, Tomaž might have a better idea, but I think the buttons (both flavors) are 7px x 72 px. Although as in bug 94174 the horizontal down pointing button (both renderings) is not as clean as the other three--Horizontal Up, Vertical Right, and Vertical Left.

The issue seems to be where the 7px Vertical Left is being attached. It ends up 1px too far to the left.
Comment 7 QA Administrators 2016-09-20 10:32:07 UTC Comment hidden (obsolete)
Comment 8 V Stuart Foote 2016-09-20 12:50:49 UTC
Issue remains unresolved in current master
Version: 5.3.0.0.alpha0+
Build ID: d15082cac2306fb9562ff126eb5827b7b9eee1e1
CPU Threads: 8; OS Version: Windows 6.19; UI Render: GL; 
TinderBox: Win-x86@42, Branch:master, Time: 2016-09-19_05:39:03
Locale: en-US (en_US); Calc: CL

The vertical left grip color mode is positioned off by 1. The horizontal top and bottom grey (unselected) mode is too tall by 1 px. The horizontal color buttons fit correctly in the border. The vertical right grip on the Sidebar is correct. 

Also, resolving bug 94174 as duplicate of this.

Tomaž?
Comment 9 V Stuart Foote 2016-09-20 12:51:29 UTC
*** Bug 94174 has been marked as a duplicate of this bug. ***
Comment 10 Tomaz Vajngerl 2016-09-21 21:16:57 UTC
I remember I tried to fix it - then some other orientation would be off by 1 :) Anyway .. I'll get back to it eventually.
Comment 11 Xisco Faulí 2017-09-29 08:48:20 UTC Comment hidden (obsolete)
Comment 12 QA Administrators 2019-12-03 14:44:16 UTC Comment hidden (obsolete)
Comment 13 Buovjaga 2020-11-13 17:47:49 UTC
Yep, still seen in the Slide pane hide button

Arch Linux 64-bit
Version: 7.1.0.0.alpha1+
Build ID: c54e1c22f30c23d00e2fe7521217569fcec59cc4
CPU threads: 8; OS: Linux 5.9; UI render: default; VCL: kf5
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Built on 13 November 2020
Comment 14 Buovjaga 2020-11-16 10:09:37 UTC
*** Bug 92087 has been marked as a duplicate of this bug. ***
Comment 15 QA Administrators 2022-11-17 03:46:36 UTC Comment hidden (obsolete)
Comment 16 QA Administrators 2024-11-17 03:16:29 UTC
Dear Yousuf Philips (jay) (retired),

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
 
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug