This one is a bit of a joke: sc/source/ui/dbgui/sfiltdlg.cxx sets up an idle handler that runs all the time: pIdle = new Idle; // FIXME: this is an abomination pIdle->SetPriority( SchedulerPriority::LOWEST ); pIdle->SetIdleHdl( LINK( this, ScSpecialFilterDlg, TimeOutHdl ) ); pIdle->Start(); The comment: // Hack: RefInput-Kontrolle pIdle = new Idle; Is rather accurate ;-) Reading the actual idle handler: // alle 50ms nachschauen, ob RefInputMode noch stimmt if( (_pIdle == pIdle) && IsActive() ) { if( pEdCopyArea->HasFocus() || pRbCopyArea->HasFocus() ) { pRefInputEdit = pEdCopyArea; bRefInputMode = true; } else if( pEdFilterArea->HasFocus() || pRbFilterArea->HasFocus() ) { pRefInputEdit = pEdFilterArea; bRefInputMode = true; } else if( bRefInputMode ) { pRefInputEdit = NULL; bRefInputMode = false; } } Unless there is some cunning operator overloading or mis-use of the HasFocus() method somehow - then all of this could easily be renamed into a: "SyncFocusState()" method - and we can audit the code to find where we need to call that (ie. before we use the pRefInputEdit or bRefInputMode members. Might be nice to prefix the member variables with 'm' or 'm_' to taste. Then rip the idle handler out completely and all the muck that goes with it. Worth checking the git annotate to see why that's there too I suspect =) perhaps there is a helpful bug report somewhere. Thanks (for saving many people's batteries) =)
Migrating Whiteboard tags to Keywords: (easyHack, difficultyBeginner, skillCpp, topicCleanup)
JanI is default CC for Easy Hacks (Add Jan; remove LibreOffice Dev List from CC) [NinjaEdit]
Jaskaran, I was wondering if you're still working on this; if not, I'd like to make an attempt.
I have committed a patch to fix this issue. Kindly, review it. Thanks.
Jaskaran committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=6610ad9aee0c8299880cd1da6cd6a756860ccad9 tdf#93889 Remove a busy loop It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Now since a patch has been successfully merged, Shouldn't this bug be marked RESOVLED?
Sounds good to me - though I suspect there are more of these around the place =)
Eike Rathke committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=62442d9066ea553a4b68b8a93fa54748cbe96e06 Resolves: tdf#99360 Revert "tdf#93889 Remove a busy loop" It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
That simply didn't work, see bug 99360.
Eike Rathke committed a patch related to this issue. It has been pushed to "libreoffice-5-2": http://cgit.freedesktop.org/libreoffice/core/commit/?id=fceea0ff4cfbacd552e8ac949f7db25d0e91493a&h=libreoffice-5-2 Resolves: tdf#99360 Revert "tdf#93889 Remove a busy loop" It will be available in 5.2.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Eike Rathke committed a patch related to this issue. It has been pushed to "libreoffice-5-2-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=ebddfbaeb71383ae94ff491da0b307c86c35e447&h=libreoffice-5-2-0 Resolves: tdf#99360 Revert "tdf#93889 Remove a busy loop" It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I'm a new developer looking for a good easyhack to work on -- it is not clear to me from this comment chain if this bug is resolved or not. The last comment claims that a resolution is committed but reviewing the gerrit it doesn't seem to have been merged. Anyone with more information to clarify would be helpful!
This one is not resolved. What you see above are commits that resolved bug 99360 by reverting the commit that claimed to "fix" this bug but caused the regression of bug 99360.
Actually I tend to remove the easyHack flag from this.. the original hack exists because the problem which manifested also in bug 99360 was not easily solvable.
Looks like that hack is from before 2000. It was finally removed by Kendy in 6.3 with: commit c618b8eae79b8d87ad5002466ef59c5694d4cea0 author Jan Holesovsky <kendy@collabora.com> Wed Apr 17 18:22:46 2019 +0200 committer Jan Holesovsky <kendy@collabora.com> Fri Apr 19 11:23:08 2019 +0200 sc: Get rid of the Idle hack in the Special Filter Dialog. Reviewed-on: https://gerrit.libreoffice.org/70948 Let's mark as fixed.