Bug 94011 - TABLE: Table border (dashed) is not saved
Summary: TABLE: Table border (dashed) is not saved
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.2.0.4 release
Hardware: x86-64 (AMD64) All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:5.1.0
Keywords: bibisected, bisected, implementationError
Depends on:
Blocks:
 
Reported: 2015-09-08 07:18 UTC by pellesimon
Modified: 2016-10-25 19:17 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments
file with table with dashed borders, from LibreOffice 4.0.6.2 (8.41 KB, application/3dr)
2015-09-14 08:44 UTC, Cor Nouws
Details

Note You need to log in before you can comment on or make changes to this bug.
Description pellesimon 2015-09-08 07:18:40 UTC
The border disappears after reopening the file.

Steps to reproduce:

1. Open a new write document
2. Create a table
3. Select the table properties
4. Change border style to dashed
5. save and reopen file
Comment 1 Cor Nouws 2015-09-08 09:43:17 UTC
Thanks for filing, Pellesimon. I confirm the problem in 4.4.5.2 and 5.0.1.2 and in 4.3.7.2 and in 4.2.6.2 ... anyway, OK in 4.0.6.2

on 32 Bits Linux
Comment 2 Cor Nouws 2015-09-08 09:46:41 UTC
OK in 410beta 1 - wild guess: set version to 4.2 release
Comment 3 Oliver Specht (CIB) 2015-09-09 09:36:29 UTC
The unsaved border types are fine_dashed, dashed_dot, dashed_dot_dot and double_thin.
Comment 4 A (Andy) 2015-09-11 22:05:18 UTC
(In reply to Oliver Specht from comment #3)
> The unsaved border types are fine_dashed, dashed_dot, dashed_dot_dot and
> double_thin.

The problems with the dashed lines are for me reproducible also with LO 5.0.1.2, Win 8.1.
Comment 5 Matthew Francis 2015-09-13 05:23:14 UTC
For at least one of the border styles (I presume "fine dashed"), I can't find a commit in which it has worked since it was first enabled below.
Adding Cc: to vmiklos@collabora.co.uk; Could you possibly take a look at this one? Thanks
(Can't see a BZ account to Cc: Eilidh McAdam)

commit 4c3d2dcdadbcb8f2ffc2caab07d50a286341df96
Author: Miklos Vajna <vmiklos@suse.cz>
Date:   Sun Jun 16 17:47:50 2013 +0200

    Add UI for fine dashed border type
    
    Commit 7d632ff29e601c2e680c4a689997fbf552592a4b added document model /
    layout support for this, but UI was lacking.
    
    First, add a new item to the list box in
    SvxBorderTabPage::FillLineListBox_Impl().  Second, handle MAP_TWIP unit
    in svtools::GetDashing() for STYLE_FINE_DASHED. Pick up some values that
    give visually the fine dashed result when painted. (The original values
    from 2f0d406911f9790a434e46bc82ea36bb8ae714e7 in other cases seem to be
    a bit consistent already anyway.)
    
    Change-Id: Ibf1ed235d51515b065d23a6a5d5eef433162899f


The commit referenced in the above is this one:

commit 7d632ff29e601c2e680c4a689997fbf552592a4b
Author: Eilidh McAdam <eilidh@lanedo.com>
Date:   Thu Nov 15 00:29:58 2012 +0000

    Support added for fine dashing on table borders.
    
    When reading in docx documents, fine dashing provides a better visual
    match for some border types.
    Added in this patch:
     - FINE_DASHED in BorderLineStyle UNO enum and in internals
     - Import of docx table borders using this border style
    
    Change-Id: I39cfa18c915ec94d8e4ecfc6a2ca637076d1e468
    Reviewed-on: https://gerrit.libreoffice.org/1123
    Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
    Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
Comment 6 Miklos Vajna 2015-09-14 08:02:29 UTC
I'm marking this as a non-regression then, this never worked I'm afraid. I assume Eilidh added support for this for OOXML in a rush, and forgot about the strict requirement that all new features must be also implemented in the ODF filter, too.
Comment 7 Matthew Francis 2015-09-14 08:34:41 UTC
We have a tag for this case too - adding "Whiteboard: implementationError"
Comment 8 Cor Nouws 2015-09-14 08:44:14 UTC
Created attachment 118691 [details]
file with table with dashed borders, from LibreOffice 4.0.6.2

(In reply to Miklos Vajna from comment #6)
> I'm marking this as a non-regression then, this never worked I'm afraid.

As I wrote in comment #1: when created in 4.0.6, it was saved. See the attached file.
Comment 9 Oliver Specht (CIB) 2015-09-14 10:14:44 UTC
The attached document contains a dashed border but not a _fine_dashed_ border

<style:style style:name="Table1.A1" style:family="table-cell">

<style:table-cell-properties fo:border-bottom="0.05pt dashed #000000" fo:border-top="0.05pt dashed #000000" fo:border-right="none" fo:border-left="0.05pt dashed #000000" fo:padding="0.097cm"/>

</style:style>
Comment 10 Cor Nouws 2015-09-15 06:37:42 UTC
(In reply to Oliver Specht from comment #9)
> The attached document contains a dashed border but not a _fine_dashed_ border

Right ... apologies.
Comment 11 Commit Notification 2015-09-28 14:46:54 UTC
Oliver Specht committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=ac84e4ff6135d51461122e0e1b5b39614b3e6eca

tdf#94011: load&save more border types

It will be available in 5.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 12 Robinson Tryon (qubit) 2015-12-10 10:24:23 UTC Comment hidden (obsolete)