Bug 94045 - FILEOPEN: Negative paragraph indents cannot be loaded from docx
Summary: FILEOPEN: Negative paragraph indents cannot be loaded from docx
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
5.1.0.0.alpha0+ Master
Hardware: Other All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:5.1.0
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-09 05:38 UTC by Oliver Specht (CIB)
Modified: 2016-10-25 19:23 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Document with positive and negative paragraph indents (11.28 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2015-09-09 05:38 UTC, Oliver Specht (CIB)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Specht (CIB) 2015-09-09 05:38:54 UTC
Created attachment 118537 [details]
Document with positive and negative paragraph indents

Negative parapraph indents cannot be imported from .docx files.

Broken since
commit 4771c8836a3e4d5e8ac25a7212293a13fb1e73ba
Author: Michael Meeks <michael.meeks@collabora.com>
Date:   Sat Jun 28 22:59:33 2014 +0100

    writerfilter: use XFastAttributes more efficiently.

    Don't duplicate UTF8 as UCS2 before converting to integers.
    Don't double convert every attribute, and allocate it twice.

    Change-Id: Ibb15d703f011865dac8eb72f18408a5d62b60d96

Which converts xml values to unsigned int.
Comment 1 Jacques Guilleron 2015-09-09 07:28:53 UTC
Can be opened with LO 5.1.0.0.alpha1+
Build ID: d417059dae303685de7aa0f4b1c192ffcf5304d5
TinderBox: Win-x86@39, Branch:master, Time: 2015-09-05_09:23:01
Locale: fr-FR (fr_FR)
& Wiindows 7 Home Premium.
Comment 2 Commit Notification 2015-09-11 12:01:29 UTC
Oliver Specht committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=2062d5d6f472ffa22ab4a769f4cb992f3a91894c

tdf#94045: negative margins in OOXML reenabled

It will be available in 5.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 3 Buovjaga 2015-09-18 11:25:02 UTC
Seems to work now.

Win 7 Pro 64-bit Version: 5.1.0.0.alpha1+
Build ID: 88c51cd55d1a9b29e62269c53b3923770253ab07
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2015-09-11_13:09:15
Locale: en-US (fi_FI)