Bug 94233 - LibreOfficeKit: Add API to advertise what commands the client is interested in
Summary: LibreOfficeKit: Add API to advertise what commands the client is interested in
Status: NEW
Alias: None
Product: LibreOffice Online
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: Other All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-15 08:20 UTC by Jan Holesovsky
Modified: 2015-09-15 10:32 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Holesovsky 2015-09-15 08:20:32 UTC 
Commits

http://cgit.freedesktop.org/libreoffice/core/commit/?id=d3a2c0f60365d6092e5061b1d061d6e3e53eb9cf
http://cgit.freedesktop.org/libreoffice/core/commit/?id=6023b797c4570b69d0511b0a45bcf67932f32ba6

introduce lists of .uno: commands that are handled.

We should not hardcode the commands, instead the LOK client (loolwsd / gtktiledviewer) should advertise which commands it can handle to LibreOfficeKit, and based on that, these should be initialized, and registered for callbacks.

We don't want to call callbacks of everything, as that can be potentially lots and lots of commands.
Comment 1 Jan Holesovsky 2015-09-15 09:42:37 UTC 
When we are at that, the SfxDispatchController_Impl::InterceptLOKStateChangeEvent() should be updated so that it returns a generic UNO -> Json conversion of aEvent.State, and it is up to the client to get the needed info out of that, so that we don't have to handle each and every case in InterceptLOKStateChangeEvent.
Comment 2 Jan Holesovsky 2015-09-15 10:32:01 UTC 
Actually filed the comment 1 as a separate bug 94241, it is unrelated to the comment 0.