git grep -E 'bool n[A-Z]' shows places where the 'n' prefix are used for bool variables. It should be 'b'.
I which directory shall I try this command because it's taking a lot of time in the ~/core/ directory of the libreoffice build. I am new to open source and looking forward to making my first contribution. Please guide me.
Well, either all of "core", or then one subdirectory at a time. "lot of time" is relative, it shouldn't take more than some minutes even on a relatively slow machine, I think. No need to run it over and over again, save the output in a file and look in it when you need to.
Benjamin Ni committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=be729e772196f33543e21cb9bac21add87726b20 tdf#94269: Replace "n" prefix for bool variables with "b" It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Please, when working on this, do only what the title says. Only replace 'n' prefixes for bool variables or fields with 'b'. Don't go *introducing* 'b' prefixes for bool variables elsewhere, in places where the surrounding code perhaps does not use our pseudo-Hungarian notation at all, or where some local bool variable is otherwise already named just obviously and fine enough.
for reference: https://wiki.openoffice.org/wiki/Writer/Code_Conventions#local_variables
Migrating Whiteboard tags to Keywords: (EasyHack DifficultyBeginner SkillCpp ) [NinjaEdit]
This issue seems to have been resolved and git grep -E 'bool n[A-Z]' returns no results. IS it ok to be marked as resolved?
Try: git grep -E 'bool\s*n[A-Z]'
Chris Sherlock committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=8db902785ed40ef388218bd5068f14f5d4bedd69 tdf#94269 Replace "n" prefix for bool variables with "b" It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Remove LibreOffice Dev List from CC on EasyHacks (curtailing excessive email to list) [NinjaEdit]