Bug 94446 - Report exception when parameter dialog is cancelled
Summary: Report exception when parameter dialog is cancelled
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Base (show other bugs)
Version:
(earliest affected)
5.0.2.2 release
Hardware: Other All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:6.3.0 target:6.2.0.1
Keywords: haveBacktrace
Depends on:
Blocks:
 
Reported: 2015-09-22 15:43 UTC by Gerhard Schaber
Modified: 2018-11-28 12:14 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Exception stacktrace (29.40 KB, image/png)
2015-09-22 15:43 UTC, Gerhard Schaber
Details
Test database with report (14.48 KB, application/vnd.sun.xml.base)
2015-09-22 15:52 UTC, Gerhard Schaber
Details
bt with debug symbols (11.21 KB, text/plain)
2018-11-24 05:54 UTC, Julien Nabet
Details
bt from "enabling legacy behavior, there should be no clients of this anymore" (4.73 KB, text/plain)
2018-11-24 06:00 UTC, Julien Nabet
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gerhard Schaber 2015-09-22 15:43:35 UTC
Created attachment 118937 [details]
Exception stacktrace

Open a report that uses a query that itself contains a parameter.
The parameter input dialog pops up
Cancel this dialog (for example, if one clicked the wrong report)
A huge dialog pops up showing a huge stacktrace of an exception
Comment 1 Gerhard Schaber 2015-09-22 15:45:05 UTC
I would suggest some small dialog saying "User operation aborted" or something,
Comment 2 Gerhard Schaber 2015-09-22 15:52:03 UTC
Created attachment 118939 [details]
Test database with report

Open the attached database
Open the report Query_Table
Click on Cancel in the parameter input dialog
Comment 3 Julien Nabet 2015-09-22 20:49:55 UTC
On pc Debian x86-64 with master sources updated today, I could reproduce this.

I also noticed this on console:
warn:legacy.osl:28607:1:xmloff/source/style/xmlimppr.cxx:678: Exception caught; style may not be imported correctly.
warn:legacy.osl:28607:1:xmloff/source/core/xmlerror.cxx:181: An error or a warning has occurred during XML import/export!
Error-Id: 0x20040001
    Flags: 2 ERROR
    Class: 4 API
    Number: 1
Parameters:
    0: FooterBackGraphicURL
Exception-Message: The given value cannot be converted to the required property type.
(property name "FooterBackGraphicURL", found value type "void", required property type "string")
Position:
    Public Identifier: 
    System Identifier: 
    Row, Column: 2,2346


warn:legacy.osl:28607:1:dbaccess/source/ui/uno/dbinteraction.cxx:66: BasicInteractionHandler::BasicInteractionHandler: enabling legacy behavior, there should be no clients of this anymore!
Comment 4 QA Administrators 2016-11-08 10:28:20 UTC Comment hidden (obsolete)
Comment 5 Gerhard Schaber 2016-11-08 11:34:21 UTC
Still happens with  5.3.0.0.alpha0+. It is hard to test with 3.3, since it does not work with Java versions that are available anywhere, but I assume the problem was there even for 3.3.
Comment 6 QA Administrators 2017-11-09 07:44:29 UTC Comment hidden (obsolete)
Comment 7 Gerhard Schaber 2017-11-09 09:21:35 UTC
Same with 5.4.2.2.
Comment 8 Gerhard Schaber 2017-11-09 09:23:22 UTC
It is the same with this 6.0 as well:
Version: 6.0.0.0.alpha1
Build ID: c1d1f859b268f650143d48f294999cda0fa57350
CPU threads: 4; OS: Windows 10.0; UI render: GL; 
Locale: de-AT (de_AT); Calc: CL
Comment 9 QA Administrators 2018-11-10 03:52:01 UTC Comment hidden (obsolete)
Comment 10 Gerhard Schaber 2018-11-20 09:11:53 UTC
The same with 6.1.3.
Comment 11 Julien Nabet 2018-11-24 05:54:27 UTC
Created attachment 146990 [details]
bt with debug symbols

On pc Debian x86-64 with master sources updated yesterday, I could still reproduce this.
Comment 12 Julien Nabet 2018-11-24 06:00:30 UTC
Created attachment 146991 [details]
bt from "enabling legacy behavior, there should be no clients of this anymore"
Comment 13 Julien Nabet 2018-11-24 06:02:05 UTC
Caolán: it seems weld allowed to pinpoint the root cause of this bugtracker.
Any thoughts how to fix this?
Is the second bt the cause of the problem?
Comment 14 Commit Notification 2018-11-27 20:09:43 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/e61dec64f86413f3c7d1d32e1675287eb3550f1f%5E%21

Related: tdf#94446 don't assert on unsetting focus handlers

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 15 Commit Notification 2018-11-27 20:09:49 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/92c34111dd8095b97a3761ab10c3ac4a3c191310%5E%21

Related: tdf#94446 set parent for dialog

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 16 Commit Notification 2018-11-27 20:09:59 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-6-2":

https://git.libreoffice.org/core/+/6e8605ee6de4ead23925476f0e945b51dea26be0%5E%21

Related: tdf#94446 don't assert on unsetting focus handlers

It will be available in 6.2.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 17 Commit Notification 2018-11-28 12:12:00 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/57bfb56972dc101200466054f0f9446301c214cb%5E%21

Resolves: tdf#94446 if this is a SQLException in disguise, throw that instead

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 18 Caolán McNamara 2018-11-28 12:14:20 UTC
We have support for just ignoring the "input param cancelled" exception, but in the reportbuilder it gets wrapped a few levels inside other exceptions to get the exception past the various exception specifications (AFAICS), if I unwrap it on leaving the reportbuilder code then things seem to work just right out of the box