Bug 94591 - FILEOPEN: ODT - Custom shapes and ellipses not rendered correctly
Summary: FILEOPEN: ODT - Custom shapes and ellipses not rendered correctly
Status: RESOLVED NOTOURBUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
5.1.0.0.alpha0+ Master
Hardware: Other All
: medium normal
Assignee: Not Assigned
URL: https://issues.oasis-open.org/browse/...
Whiteboard: target:7.2.0
Keywords:
Depends on:
Blocks: ODF-import Shapes-Custom
  Show dependency treegraph
 
Reported: 2015-09-29 03:42 UTC by Yousuf Philips (jay) (retired)
Modified: 2021-12-09 13:21 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
sample doc (6.78 KB, application/vnd.oasis.opendocument.text)
2015-09-29 03:42 UTC, Yousuf Philips (jay) (retired)
Details
calligra pdf export (2.79 KB, application/pdf)
2015-09-29 03:43 UTC, Yousuf Philips (jay) (retired)
Details
sample doc 2 (8.11 KB, application/vnd.oasis.opendocument.text)
2015-09-29 03:55 UTC, Yousuf Philips (jay) (retired)
Details
calligra pdf export 2 (5.20 KB, application/pdf)
2015-09-29 03:57 UTC, Yousuf Philips (jay) (retired)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2015-09-29 03:42:37 UTC
Created attachment 119109 [details]
sample doc

Steps:
1) Open attached doc
2) Notice that none of the first row of shapes look like arrow and the single entry on the second line doesnt look like a cross

The file was created in Calligra Words and i would assume that LO is having problems deciphering the draw:enhanced-path attribute of the <draw:enhanced-geometry> tag.

Version: 5.1.0.0.alpha1+
Build ID: 18c196f0190d9920673cdd9a4dbc158f08959cfd
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2015-09-26_00:38:50
Locale: en-US (en_US.UTF-8)
Comment 1 Yousuf Philips (jay) (retired) 2015-09-29 03:43:45 UTC
Created attachment 119110 [details]
calligra pdf export
Comment 2 Yousuf Philips (jay) (retired) 2015-09-29 03:55:37 UTC
Created attachment 119111 [details]
sample doc 2

Here is another sample file which has a <draw:custom-shape> smiley face and <draw:ellipse> like a flower.
Comment 3 Yousuf Philips (jay) (retired) 2015-09-29 03:57:36 UTC
Created attachment 119112 [details]
calligra pdf export 2

LO shows the shapes in the navigator, though they are invisible on the page.
Comment 4 Buovjaga 2015-10-02 08:16:15 UTC
Confirmed.

Win 7 Pro 64-bit Version: 5.1.0.0.alpha1+
Build ID: 25de5cfa43b2b1cb7d7214470acc7719839e13fe
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2015-10-01_08:49:54
Locale: en-US (fi_FI)
Comment 5 QA Administrators 2016-11-08 10:42:06 UTC Comment hidden (obsolete)
Comment 6 vihsa 2017-06-01 05:48:27 UTC
reproducible with lo viewer version: 5.5.0.0.alpha0+ / build id : ec79f34 / android 5.1
Comment 7 vihsa 2017-09-05 05:39:45 UTC
attachment 119111 [details]
blank document

lo viewer v1
lo viewer v4
lo viewer v6
lo viewer v8
lo viewer v10

attachment 119109 [details]
repro

lo viewer v1
lo viewer v4
lo viewer v6
lo viewer v8
lo viewer v10

os: android 5.1
device: lyf flame 3 [ ls-4001 ]
Comment 8 QA Administrators 2018-09-06 02:59:34 UTC Comment hidden (obsolete)
Comment 9 Regina Henschel 2018-11-24 18:42:01 UTC
"width" and "height" are wrong interpreted.

The error is still there in Version: 6.3.0.0.alpha0+ (x64)
Build ID: d71ea82055a6a304493c7eaa90809a348e23784d
CPU threads: 8; OS: Windows 10.0; UI render: GL; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-11-19_04:56:18
Locale: de-DE (en_US); UI-Language: en-US
Calc: threaded
Comment 10 Regina Henschel 2018-11-26 00:15:30 UTC
The file "sample doc" uses the identifiers "width" and "height" as parameters in the attribute enhanced-path. But that is not allowed. Allowed are only integer value, floating point value, $ followed by modifier index, and ? followed by formula name. http://docs.oasis-open.org/office/v1.2/os/OpenDocument-v1.2-os-part1.html#attribute-draw_enhanced-path.

I don't know yet, what is wrong with the second document. It has no 'width' or 'height' identifiers in the path.
Comment 11 Regina Henschel 2018-11-30 01:10:45 UTC
The file sample_doc_" has several problems:
The smiley has a wrong path. It uses an angle of about 2.359e+7 degree.

The other shapes have no svg:viewBox attribute and use draw:engine and draw:data attribute.

The specification has no rule for a missing svg:viewBox. That is https://issues.oasis-open.org/browse/OFFICE-3824. In the meantime LibreOffice could use the svg:x, svg:y, svg:width and svg:height attributes to generate a viewBox on import.

The only real bug is, that LibreOffice are confused by the draw:engine and draw:data attributes. Because LibreOffice does not support the specified data:engine, it should ignore these attributes and use the given path.
Comment 12 QA Administrators 2021-02-22 04:00:29 UTC Comment hidden (obsolete)
Comment 13 Regina Henschel 2021-02-22 12:45:10 UTC
The error still exists in Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: d49277fc7c017c5a62a0c28af782cfc04a6460ab
CPU threads: 8; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win
Locale: de-DE (en_US); UI: en-US
Calc: CL
Comment 14 Commit Notification 2021-02-24 20:22:53 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b9646ced245fe89d5a1e8b48fc5af533a94da2a6

crashtesting: assert of unbalanced tags on exporting tdf94591-1.odt to docx

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 15 Regina Henschel 2021-12-09 13:21:50 UTC
Problem still exists in Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 4ac9032163cf55c160145373e7c41741c9c339ca
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: de-DE (en_US); UI: en-US
Calc: CL

The shapes in "sample doc 2" have no svg:viewBox. Issue OFFICE-3824 will be solved for ODF 1.4 so, that the svg:viewBox attribute may not be omitted in enhanced-path like those in the sample documents.

I consider the sample documents as faulty and resolve the bug as NOTOURBUG. Feel free to reopen the bug if you disagree. In that case please state which is the correct result according ODF specification.