Download it now!
Bug 94768 - ODF export: invalid <style:graphic-properties> child of paragraph style
Summary: ODF export: invalid <style:graphic-properties> child of paragraph style
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.4.0.3 release
Hardware: Other All
: high normal
Assignee: Not Assigned
URL:
Whiteboard: odf odf_validation target:5.1.0 targe...
Keywords: bisected, regression
Depends on:
Blocks: ODF-export-invalid Regressions-DrawingLayer-FillStyles
  Show dependency treegraph
 
Reported: 2015-10-04 22:03 UTC by Jos van den Oever
Modified: 2020-06-11 11:50 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments
input file to recreate the bug (79.20 KB, application/vnd.oasis.opendocument.text)
2015-10-04 22:03 UTC, Jos van den Oever
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jos van den Oever 2015-10-04 22:03:12 UTC
Created attachment 119286 [details]
input file to recreate the bug

Under certain circumstances, LO can create seriously invalid ODF.

An element <style:style style:family="paragraph" ...> may not have a child element <style:graphic-properties>. In LO 5.0.1.2, it can create such elements.

To recreate the problem, open the attached before.odt. Now save it and look at styles.xml. This will contain this fragment:

    <style:style style:name="Code" style:family="paragraph" style:parent-style-name="Standard">
      <style:graphic-properties draw:fill="solid" draw:fill-color="#d9d9d9" draw:opacity="100%"/>
      <style:paragraph-properties fo:margin-left="0cm" fo:margin-right="0cm" fo:


To recreate the issue, LO is configured to save to 'ODF 1.2'. The option 'ODF format version:' is set to '1.2'.
Comment 1 Buovjaga 2015-10-08 08:50:33 UTC
Reproduced.

Re-prioritized as the result is not a document that can't be opened. Still, quite embarrassing so setting priority to high.

Win 7 Pro 64-bit, Version: 5.0.2.2 (x64)
Build ID: 37b43f919e4de5eeaca9b9755ed688758a8251fe
Locale: fi-FI (fi_FI)
Comment 2 Michael Stahl (CIB) 2015-10-08 09:44:36 UTC
this is a regression from the new fill-style attributes in LO 4.4
that were added in Writer not just for frames, headers, page styles etc.
but also for paragraph styles.

i've changed it already to use the "loext" namespace in:

"xmloff: ODF export: actually ODF 1.2 does not allow graphic-properties"

commit on master:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=b1922eecb55b233de3e6abaaa644fe9f313cf0f1

commit on libreoffice-5-0:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=651315eab0a605fb0a22e74b6daa4417602fc072

commit on libreoffice-4-4:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=c8adaefafe8bce0920f801f294c2c89077e6659c

somebody needs to write an OASIS proposal for this probably,
so i'll leave the bug unresolved to remind me of that...
Comment 3 Xisco Faulí 2016-09-12 12:31:29 UTC
Adding keyword 'bibisectRequest'.
Comment 4 Michael Stahl (CIB) 2016-09-12 12:51:26 UTC
as the linked fix says, regression from commit
7d9bb549d498d6beed2c4050c402d09643febdfa

although i still haven't got round to file an OASIS proposal...
Comment 5 Armin Le Grand 2016-09-18 14:26:45 UTC
@Michael: I think there is no way to take back the full FillStyles from Writer objects, so I opt for adding a change request to ODF spec to allow this. How to do that? Please go ahead when you know how to do that
Comment 6 Xisco Faulí 2016-09-26 15:03:09 UTC
Adding Cc: to Armin Le Grand
Comment 7 Xisco Faulí 2017-07-13 11:01:35 UTC
Setting Assignee back to default. Please assign it back to yourself if you're
still working on this issue
Comment 8 QA Administrators 2019-03-01 03:49:46 UTC Comment hidden (obsolete)
Comment 9 Michael Stahl (CIB) 2019-11-11 13:28:53 UTC
looks like i still haven't filed a proposal for this...
Comment 10 Xisco Faulí 2020-06-11 10:39:48 UTC
(In reply to Michael Stahl (CIB) from comment #9)
> looks like i still haven't filed a proposal for this...

Hi Michael, is it included in ODF 1.3 ?
Comment 11 Michael Stahl (CIB) 2020-06-11 11:29:27 UTC
(In reply to Xisco Faulí from comment #10)
> (In reply to Michael Stahl (CIB) from comment #9)
> > looks like i still haven't filed a proposal for this...
> 
> Hi Michael, is it included in ODF 1.3 ?

mostly not, for details see bug 103602
Comment 12 Regina Henschel 2020-06-11 11:50:33 UTC
I have posted "ODF: gradient fill on paragraphs, i.a."
 https://lists.freedesktop.org/archives/libreoffice/2020-June/085280.html

But no discussion yet, which way to go.