Created attachment 119286 [details]
input file to recreate the bug
Under certain circumstances, LO can create seriously invalid ODF.
An element <style:style style:family="paragraph" ...> may not have a child element <style:graphic-properties>. In LO 126.96.36.199, it can create such elements.
To recreate the problem, open the attached before.odt. Now save it and look at styles.xml. This will contain this fragment:
<style:style style:name="Code" style:family="paragraph" style:parent-style-name="Standard">
<style:graphic-properties draw:fill="solid" draw:fill-color="#d9d9d9" draw:opacity="100%"/>
<style:paragraph-properties fo:margin-left="0cm" fo:margin-right="0cm" fo:
To recreate the issue, LO is configured to save to 'ODF 1.2'. The option 'ODF format version:' is set to '1.2'.
Re-prioritized as the result is not a document that can't be opened. Still, quite embarrassing so setting priority to high.
Win 7 Pro 64-bit, Version: 188.8.131.52 (x64)
Build ID: 37b43f919e4de5eeaca9b9755ed688758a8251fe
Locale: fi-FI (fi_FI)
this is a regression from the new fill-style attributes in LO 4.4
that were added in Writer not just for frames, headers, page styles etc.
but also for paragraph styles.
i've changed it already to use the "loext" namespace in:
"xmloff: ODF export: actually ODF 1.2 does not allow graphic-properties"
commit on master:
commit on libreoffice-5-0:
commit on libreoffice-4-4:
somebody needs to write an OASIS proposal for this probably,
so i'll leave the bug unresolved to remind me of that...
Adding keyword 'bibisectRequest'.
as the linked fix says, regression from commit 7d9bb549d498d6beed2c4050c402d09643febdfa
although i still haven't got round to file an OASIS proposal...
@Michael: I think there is no way to take back the full FillStyles from Writer objects, so I opt for adding a change request to ODF spec to allow this. How to do that? Please go ahead when you know how to do that
Adding Cc: to Armin Le Grand
Setting Assignee back to default. Please assign it back to yourself if you're
still working on this issue
** Please read this message in its entirety before responding **
To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.
There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.
If you have time, please do the following:
Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/
If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.
Please DO NOT
Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not
appropriate in this case)
If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/
2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword
Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa
Thank you for helping us make LibreOffice even better for everyone!
looks like i still haven't filed a proposal for this...
(In reply to Michael Stahl (CIB) from comment #9)
> looks like i still haven't filed a proposal for this...
Hi Michael, is it included in ODF 1.3 ?
(In reply to Xisco Faulí from comment #10)
> (In reply to Michael Stahl (CIB) from comment #9)
> > looks like i still haven't filed a proposal for this...
> Hi Michael, is it included in ODF 1.3 ?
mostly not, for details see bug 103602
I have posted "ODF: gradient fill on paragraphs, i.a."
But no discussion yet, which way to go.
Save in ODF 1.3 and ODF 1.2 do not write element <style:graphic-properties>.
Save in ODF 1.3 extended and ODF 1.2 extended write element <loext:graphic-properties>.
Tested in Version: 184.108.40.206.alpha0+ (x64) / LibreOffice Community
Build ID: 4ac9032163cf55c160145373e7c41741c9c339ca
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: de-DE (en_US); UI: en-US
The bug is fixed. Because the concrete commit is not known, resolve as "worksforme".