The recent changes removing rtti.hxx have introduced a pattern like this: if( dynamic_cast<const VclWindowEvent*>( &rEvent ) != nullptr ) { VclWindowEvent* pWinEvent = static_cast<VclWindowEvent*>(&rEvent); [...original code...] } When we have performed the dynamic_cast anyway, it would be more readable to change it to: VclWindowEvent* pWinEvent = dynamic_cast<VclWindowEvent*>(&rEvent); if (pWinEvent) { [...original code...] } To find the places where this if (dynamic_cast<Type*>(var) != nullptr) { Type* p = static_cast<Type*>(var); pattern was introduced, just read through the following commits: http://cgit.freedesktop.org/libreoffice/core/commit/?id=d3c7c9ea81ee7c617f8cee5b645621088aea215b http://cgit.freedesktop.org/libreoffice/core/commit/?id=ac9671f94800b647f82b12e718968311a025e87e http://cgit.freedesktop.org/libreoffice/core/commit/?id=85f93697defd9a812a0cda0bc4e9364e28c0339e http://cgit.freedesktop.org/libreoffice/core/commit/?id=89d39bc100aabf5dccbe77c0b5c0c85736e85b39 and see where the "ISA(...)" was removed, it is very likely that such change introduced the unwanted pattern.
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=31ee230b6efac9a6a60ceb5c2367ae9a5cf98929 Related: tdf#94814 some cleanup of static_cast following dynamic_cast It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=9381ca578de26aa75bb0d4439221c3439cf99616 Related: tdf#94814 some cleanup of static_cast following dynamic_cast It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Migrating Whiteboard tags to Keywords: (easyHack, difficultyBeginner, skillCpp, topicCleanup) [NinjaEdit]
JanI is default CC for Easy Hacks (Add Jan; remove LibreOffice Dev List from CC) [NinjaEdit]
Seems solved