Bug 94940 - "Show font history" option does not work
Summary: "Show font history" option does not work
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
4.1.6.2 release
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:5.3.0 target:5.2.1
Keywords: regression
Depends on:
Blocks:
 
Reported: 2015-10-10 17:12 UTC by Jean-Baptiste Faure
Modified: 2016-08-03 13:23 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot of Tools > Options > LibreOfficeDev > View (86.07 KB, image/png)
2015-10-11 02:06 UTC, Terrence Enger
Details
With Font History (256.11 KB, image/png)
2015-11-19 21:06 UTC, Nicholas Niro
Details
Without Font history (255.40 KB, image/png)
2015-11-19 21:17 UTC, Nicholas Niro
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Baptiste Faure 2015-10-10 17:12:11 UTC
It seems that font history is broken: unchecking "Show font history" in Tools > Options > LibreOffice > View has no effect.
Reproduced from version 4.1 to 5.0. Works in version 4.0.6
Tested on Ubuntu 15.04 x86-64

Steps to reproduce:
1/ Open a new empty document LibreOffice Writer
2/ type some text
3/ select some part of the text and change its font
4/ verify that the font dropdown list (in both formatting toolbar and properties tab in sidebar) has the font you choose at the top of the list

5/ go to menu Tools > Options > LibreOffice > View
6/ uncheck the checkbox "Show font history", click the OK button
7/ verify that the font dropdown list (in both formatting toolbar and properties tab in sidebar) still has the font you choose at the top of the list
8/ close and restart LibreOffice
9/ verify that the font dropdown list (in both formatting toolbar and properties tab in sidebar) still has the font you choose at the top of the list

Best regards. JBF
Comment 1 Terrence Enger 2015-10-11 02:06:05 UTC
Created attachment 119494 [details]
Screenshot of Tools > Options > LibreOfficeDev > View

Unless I am overlooking something, the daily dbgutil bibisect
repository version 2015-10-10 does not have "show font history" in
Tools > Options > LibreOfficeDev > View.  Has this been deliberately
removed?  Has it been moved somewhere else?
Comment 2 Jean-Baptiste Faure 2015-10-11 05:54:01 UTC
(In reply to Terrence Enger from comment #1)
> Created attachment 119494 [details]
> Screenshot of Tools > Options > LibreOfficeDev > View
> 
> Unless I am overlooking something, the daily dbgutil bibisect
> repository version 2015-10-10 does not have "show font history" in
> Tools > Options > LibreOfficeDev > View.  Has this been deliberately
> removed?  Has it been moved somewhere else?

I do not know, but the option is still in the expert configuration (search history) and it works in the master.

Best regards. JBF
Comment 3 Terrence Enger 2015-10-12 15:56:00 UTC
I have looked into Expert Configuration.  (No tee-shirt, but I did get
bug 94968 as a consolation prize. <grin />) Ah, now I see
org.openoffice.Office.Common > Font > View , property History.

I have managed to get myself quite confused.  Some initial questions,
comments, etc. ...

(*) So I guess that the show-font-history is moved into Export
    Configuration for 5.1.  What level of support do we give to things
    in Expert Configuration?  (I remember one RESOLVED INVALID for a
    crash resulting from a mistyped value for an envvar: this was
    deemed "test pilot" territory, to be used at my own risk.)

(*) Is a change to show-font-history supposed to be delayed until the
    next execution of LibreOffice?  How widely can the answer be
    generalized?

(*) What is the correct behavior of the drop-down lists when
    show-font-history is false?  No recently-used list at all?

(*) Is the recently-used font list saved per document?  Or, is it kept
    per user?

(*) I think I see different behaviors depending on what I did in
    LibreOffice before starting Writer.  I hope that I can prove to
    myself that I was dreaming.

(*) Important note to self: Use a new user profile; do not even think
    of trying anything more without one.

Guidance welcome.

Thanks,
Terry.
Comment 4 Terrence Enger 2015-11-17 00:25:29 UTC
Starting with a new user profile, the results are much more
comprehensible.  Some answers, based on experimentation with recent
versions from the daily dbgutil bibisec repository ...

(*) Turning off show-font-history takes effect immediately, removing
    the recently-used files from the dropdown list of fonts and
    clearing the saved list.  Turning the flag on starts accumulating
    and displaying the recently-used list.

(*) The recently-used list is kept per user.

(*) Yes, starting with a fresh user profile was necessary to make
    anything comprehensible.

I do see a problem in that the font selection controls in the toolbar
and in the sidebar seem to keep separate lists of recently-used fonts,
at least while the document is open.  Is this the problem you see,
Jean-Baptiste?

Terry.
Comment 5 Nicholas Niro 2015-11-19 21:06:34 UTC
Created attachment 120668 [details]
With Font History

This screenshot shows an history of the last 5 fonts used (I randomly used fonts to test this) right above the fonts list. The option "Show fonts history" was active.
Comment 6 Nicholas Niro 2015-11-19 21:17:54 UTC
Created attachment 120669 [details]
Without Font history

I disabled "Show font history" and this screenshot shows the result. It seems to have removed the history but is still showing the 2 kinds of fonts which are currently in use in the document.

<code>
Font Lists - Show font history

When using this option, the last five fonts you have use the current document displayed on the top of the list of fonts.
</code>

this quote is from : https://en.wikibooks.org/wiki/LibreOffice/Writer/Configuring_the_editor

So this seems to work correctly for me. Can you confirm if this is the same behavior you are getting too? Set this as UNCONFIRMED when you answer please.

Libreoffice version : 4.4.3.2 
Build Id : 88805f81e9fe61362df02b9941de8e38a9b5fd16
distro : Void linux x86-64
Comment 7 Nicholas Niro 2015-11-19 21:19:47 UTC
-Awaiting more information-
Comment 8 Jean-Baptiste Faure 2016-01-16 07:55:41 UTC
Working with a new document and with font history disabled, it remains 2 fonts with no relation with the current document. Perhaps it is by design. Now that the option has been moved in expert configuration and set to true by default, I think we can stop to loose time with that. Closing as WontFix. Thank you for your help.

Best regards. JBF
Comment 9 Adolfo Jayme Barrientos 2016-06-27 07:20:01 UTC
(In reply to Jean-Baptiste Faure from comment #8)
> Working with a new document and with font history disabled, it remains 2
> fonts with no relation with the current document. Perhaps it is by design.

I disagree that stray elements appearing in a list *even after disabling them* is “by design”. And the fact that the “Show font history” is no longer in the UI doesn’t automatically invalidate this bug. On the contrary, it makes it more annoying, because they keep showing up after one’s hunting for the setting in the Expert Confiuguration list.
Comment 10 Caolán McNamara 2016-07-28 16:27:27 UTC
I think the option almost works right. i.e. if you have no history used yet then toggling it on and off will work.

Once you have a history it gets saved and when you start with a history the history is loaded and set to the widget. It doesn't get updated with new entries if the history is disabled, but the old ones are frozen and visible.
Comment 11 Commit Notification 2016-07-28 20:32:04 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=171586cc4df4a9470251e50ce51338c2d53acf9b

Resolves: tdf#94940 don't load font history if option is disabled

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Jean-Baptiste Faure 2016-07-29 17:06:15 UTC
Verified fixed in Version: 5.3.0.0.alpha0+
Build ID: 171586cc4df4a9470251e50ce51338c2d53acf9b
CPU Threads: 4; OS Version: Linux 4.4; UI Render: default; 
Ubuntu_16.04_x86-64
Locale: fr-FR (fr_FR.UTF-8); Calc: group

Thank you very much.

Best regards. JBF
Comment 13 Commit Notification 2016-08-03 13:23:47 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-5-2":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=2adc91069d73d47bfae2a78ff408d21339aba17c&h=libreoffice-5-2

Resolves: tdf#94940 don't load font history if option is disabled

It will be available in 5.2.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.