Created attachment 120037 [details]
screen capture with the master (keyID enabled)
Step to reproduce:
1/ open a new spreadsheet
2/ activate the sidebar if necessary
3/ under Number Format the first dropdown list shows General
4/ select A1, right click and choose Format Cells in category dropdown list there is no general category
I think that the sidebar dropdown list should show Standard instead of General.
Best regards. JBF
Very weird. I saw "General" both in sidebar AND number formatting dialog, but ...
... then I switched Language in number formatting dialog (the combobox in top right corner of it) to "French - France" i.e. the same JBF has ...
... and voila, "Standard" appears in number formatting dialog, while "General" stays in sidebar :)
Anyway, confirmed. Some languages have "Standard", some have "General". This needs to be unified. Slightly reluctant to make this easy hack, as there might be some gotcha ...
(In reply to Katarina Behrens (CIB) from comment #1)
> Anyway, confirmed. Some languages have "Standard", some have "General". This
> needs to be unified. Slightly reluctant to make this easy hack, as there
> might be some gotcha ...
All translation of "General" format can be found in each 155 locale files, on next line defining "FixedFormatskey1"
This wording is used in Format > Cells > Number dialog
Migrating Whiteboard tags to Keywords: (easyHack DifficultyBeginner TopicCleanup)
JanI is default CC for Easy Hacks (Add Jan; remove LibreOffice Dev List from CC)
Hi, I have started working on this bug. Initially i was confused about whether the issue is with inconsistent locale data or with the sidebar. I uploaded a patch to ensure that all languages have "General" (instead of standard) in the xml files. The number formatting dialog is in sc/source/ui/sidebar/NumberFormatPropertyPanel.cxx. According to me the problem is : Sidebar contents aren't updated when we change languages. we can add some code in the action listeners of Format Cells dialog so that the sidebar contents are updated. I would really appreciate if someone could provide a more clear description or some code pointers ...
@ Rohan Kumar
From my point of view, the problem is that General format should be a category and not a format.
In Gnumeric and Excel, General (or Standard) is a category without option, different from Number and Scientific, as General is a mix of these two categories.
This would imply refactoring Number Format UI dialog.
General (or Standard, or ...) is one specific number format, not a category. And it is up to the localization of the locale data (.xml file) if and how it is translated. Usually it is translated to the same word that Excel uses in the corresponding localized version, but not necessarily.
The problem is that "General" format is considered as a format in Format>Cell>Number dialog, and as a category in the Sidebar. They are translated in different file for each UI:
- dialog box: i18npool/source/localedata/data/xx_XX.xml http://opengrok.libreoffice.org/s?n=25&start=0&q=FixedFormatskey1&sort=fullpath&project=core (see Comment 2)
- Sidebar: http://opengrok.libreoffice.org/xref/translations/source/fr/sc/uiconfig/scalc/ui.po#8090 replace "fr" with your local
Each localization should check if both are translated in the same way.
@Laurent BP. The localization inconsistency is a side effect of this bug. I have actually committed a patch related to the localization inconsistency issue :https://gerrit.libreoffice.org/#/c/23310/ . Is this which you were saying about the languages translated the same way?
(In reply to Rohan Kumar from comment #9)
> @Laurent BP. The localization inconsistency is a side effect of this bug. I
> have actually committed a patch related to the localization inconsistency
> issue :https://gerrit.libreoffice.org/#/c/23310/ . Is this which you were
> saying about the languages translated the same way?
Yes, but no. In your patch, you made no translation. You just forced to use an English word. For instance in French (language which I can understand ;-) ) you replaced "Standard" (which is a valid French word) with "General" which is not valid in French (it should be written "Général"). I suppose that same problem occurs in other languages.
What should be done for each l10n:
1. Check inconsistency: is there a different translation in both places Number dialog/Sidebar (see Comment 8)? If not, there is nothing to do (like in French, because "Standard" was chosen as preferred translation by the l10n community
2. Ask l10n community what is the preferred translation or warn l10n community on email@example.com
3. Change translation in Sidebar OR in dialog
4. Check other places where the translation is used:
- in dialog Tools > Options > Calc > Calculate: "_Limit decimals for general number format" see http://opengrok.libreoffice.org/search?&q=generalprec&project=translations,&sort=fullpath
- in help, see http://opengrok.libreoffice.org/search?&q=hd_id315634199&project=translations,&sort=fullpath
I did not notice that your commit was already merged. You should have added tdf#95385 at the beginning of your commit title to link your commit with this .
As mentioned in Comment 10, I do not agree with that commit. It is in contradiction with some l10n work. With French l10n, it is "Standard" which was chosen to translate "General" in SideBar. See http://opengrok.libreoffice.org/xref/translations/source/fr/sc/uiconfig/scalc/ui.po#8090
(In reply to Laurent BP from comment #11)
> I did not notice that your commit was already merged. You should have added
> tdf#95385 at the beginning of your commit title to link your commit with
> this .
> As mentioned in Comment 10, I do not agree with that commit. It is in
> contradiction with some l10n work. With French l10n, it is "Standard" which
> was chosen to translate "General" in SideBar. See
This patch was only merged after exchanging mails with Sophie, if the l10n team as such does not agree, it can of course be changed.
PLEASE REVERT https://gerrit.libreoffice.org/23310
Modifying locale datas' number format is a wrong solution.
I guess it was a result of a misunderstanding.
Doing myself now.
Eike Rathke committed a patch related to this issue.
It has been pushed to "master":
Revert "Text General inconsistent with cell formatting dlg", tdf#95385
It will be available in 5.2.0.
The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
Affected users are encouraged to test the fix and report feedback.
Is this bug fixed?
If so, could you please close it as RESOLVED FIXED?
I've just realized your last commit reverted the previous commit. Sorry for the noise.
Setting Assignee back to default. Please assign it back to yourself if you're
still working on this issue
** Please read this message in its entirety before responding **
To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.
There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.
If you have time, please do the following:
Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/
If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.
Please DO NOT
Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not
appropriate in this case)
If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/
2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword
Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa
Thank you for helping us make LibreOffice even better for everyone!
Same inconsistency between formatting dialog and sidebar in LO 22.214.171.124.0+
Best regards. JBF
To recap and summarise:
The General (or Standard, or ...) seen in the sidebar is the (translated or not) keyword/code of the General number format, not a UI string or translation, if there is no specific number format applied (hence format code General). The problem is that the format code keyword is used as UI "category" name; that should be decoupled.