Bug 96044 - After exiting Page Preview main window number is not reset but bumps to #3
Summary: After exiting Page Preview main window number is not reset but bumps to #3
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
4.3.7.2 release
Hardware: All All
: medium normal
Assignee: akash96j
URL:
Whiteboard: target:5.2.0
Keywords: bibisected, bisected, regression
: 98834 (view as bug list)
Depends on: 96896
Blocks:
  Show dependency treegraph
 
Reported: 2015-11-24 15:26 UTC by Pedro
Modified: 2016-10-25 19:09 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro 2015-11-24 15:26:41 UTC
When the user presses Page Preview (the button or the menu item), the LibreOffice window title switches to <filename>:2 (meaning window 2 of the same document)

Starting from branch 4.3 when the user exits/closes the Preview window, the main window title switches to <filename>:3 instead of just <filename>

This occurs both in Writer and Calc (there is no Page Preview in Impress)

This is a regression from branch 4.2 

Tested with LibreOffice 5.0.3 x64 under Windows 7 Pro x64 SP1 and LibreOffice x86 5.0.3, 4.4.5, 4.3.7 and 4.2.8 under Windows XP Pro x86 SP3
Comment 1 Cor Nouws 2015-11-24 16:20:38 UTC
Thanks Pedro.

Confirm this in daily Version: 5.1.0.0.alpha1+
Build ID: f6bc5b79c31225c02e9500d0ced4bd26f998f82b
Threads 2; Ver: 4.2; Render: default;
Comment 2 raal 2015-12-12 20:05:18 UTC
This seems to have begun at the below commit.
Adding Cc: to Samuel Mehrbrodt ; Could you possibly take a look at this one?
Thanks
 0f9f354ac2a2e115f76429c91aa1ba545a08f328 is the first bad commit
commit 0f9f354ac2a2e115f76429c91aa1ba545a08f328
Author: Matthew Francis <mjay.francis@gmail.com>
Date:   Sun Mar 15 01:49:58 2015 +0800

    source-hash-b4558b508141af16d335f45a0f12bdd34521e944
    
    commit b4558b508141af16d335f45a0f12bdd34521e944
    Author:     Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
    AuthorDate: Fri Aug 22 22:37:56 2014 +0200
    Commit:     Thomas Arnhold <thomas@arnhold.org>
    CommitDate: Sun Aug 24 06:26:17 2014 -0500
    
        fdo#73151 Make better use of the sidebar
    
        The general idea is to encourage use of the sidebar instead of floating windows (for Navigator, Styles&Formatting and Gallery)
    
        Changes:
        * Show the sidebar by default in Writer & Impress
        * Remove the Gallery floating window (Gallery now always opens in the sidebar)
        * Remove all Gallery, Navigator and Styles&Formatting links from the default toolbar in Writer
          (since they have an icon in the sidebar and the sidebar is shown by default now)
        * When selecting "More" from the Styles dropdown, the Stylelist opens in the sidebar instead of the floating window
    
        This has all been discussed extensively here: https://bugs.freedesktop.org/show_bug.cgi?id=73151
    
        Change-Id: I3a0461d1472711da7121801000af294b432fccb1
        Reviewed-on: https://gerrit.libreoffice.org/11077
        Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
        Tested-by: Thomas Arnhold <thomas@arnhold.org>
Comment 3 Samuel Mehrbrodt (allotropia) 2016-01-08 10:43:19 UTC
All my commit did was enabling the sidebar by default.
If you disable the Sidebar, the bug is no longer reproducible.

So this has something to do with the Sidebar, but the root cause must be somewhere deeper in history...
Comment 4 raal 2016-03-29 10:07:53 UTC
*** Bug 98834 has been marked as a duplicate of this bug. ***
Comment 5 Commit Notification 2016-04-05 12:53:35 UTC
akash committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=d0075ad8f2e38e23d578f80928236b3a2780f25b

tdf#96044 - After exiting print preview main window number bumps to #3

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Pedro 2016-04-16 17:06:30 UTC
Verified with

Version: 5.2.0.0.alpha0+ (x64)
Build ID: d6bf3bcd8b51012d55a2ec962800a8549e2b85e1
CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; 
TinderBox: Win-x86_64@62-TDF, Branch:MASTER, Time: 2016-04-15_06:48:04
Locale: pt-PT (pt_PT)

Since this is a bug fix (and it was a regression) can it be back-ported to 5.1 (to be included in 5.1.3 or 5.1.4)?

Thank you!
Comment 7 Stephan Bergmann 2016-04-20 07:16:10 UTC
(In reply to Pedro from comment #6)
> Since this is a bug fix (and it was a regression) can it be back-ported to
> 5.1 (to be included in 5.1.3 or 5.1.4)?

See my comments to <https://gerrit.libreoffice.org/#/c/24137> for why I think it is better to not backport this to 5.1.
Comment 8 Pedro 2016-04-20 08:26:06 UTC
(In reply to Stephan Bergmann from comment #7)
> (In reply to Pedro from comment #6)
> > Since this is a bug fix (and it was a regression) can it be back-ported to
> > 5.1 (to be included in 5.1.3 or 5.1.4)?
> 
> See my comments to <https://gerrit.libreoffice.org/#/c/24137> for why I
> think it is better to not backport this to 5.1.

I agree with your decision. Thank you for the explanation!

Thanks to akash for fixing this!