Replace all possible CPPUNIT_ASSERT with CPPUNIT_ASSERT_EQUAL in the scanner test. Don't replace places where a function call just returns a boolean. Instead do it for all places where we have a == inside of the CPPUNIT_ASSERT. basic/qa/cppunit/test_scanner.cxx
Note that if the expected value is a numeric literal, you MUST make sure it has the same type as the result (by using a suffix--e.g., 42u--or explicit cast--e.g., size_t(42)), otherwise it WILL fail to build on different platforms.
Migrating Whiteboard tags to Keywords: (easyHack, difficultyBeginner, skillCpp, topicCleanup)
Dipangar Niranjar committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=0e41527fd52f676ff6240a08b3fe25607c1ca726 tdf#96136 replace CPPUNIT_ASSERT with CPPUNIT_ASSERT_EQUAL It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Great work. I'm looking forward to your next easy hack.
Remove LibreOffice Dev List from CC on EasyHacks (curtailing excessive email to list) [NinjaEdit]