Bug 96143 - Writer unresponsive large amount of animating gif images in table
Summary: Writer unresponsive large amount of animating gif images in table
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
3.5.7.2 release
Hardware: All All
: high critical
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: perf
Depends on:
Blocks: Writer-Images
  Show dependency treegraph
 
Reported: 2015-11-29 19:15 UTC by Maxim Britov
Modified: 2022-06-16 14:41 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments
A lot of images in tabel cells (denial of service for Writer) (1.66 MB, application/vnd.oasis.opendocument.text)
2015-11-29 19:19 UTC, Maxim Britov
Details
Empty menus at my home pc, but work fine on my another pc. (130.63 KB, application/vnd.oasis.opendocument.text)
2015-11-29 19:27 UTC, Maxim Britov
Details
Callgrind output from master (5.27 MB, application/x-xz)
2017-11-12 18:28 UTC, Buovjaga
Details
perf (960.37 KB, image/svg+xml)
2019-04-28 18:34 UTC, Julien Nabet
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Maxim Britov 2015-11-29 19:15:42 UTC
When open Writer's document with table and image in every cell Writer unresponsive.
I will attach two files with different effects.
Please look.
Comment 1 Maxim Britov 2015-11-29 19:19:08 UTC
Created attachment 120883 [details]
A lot of images in tabel cells (denial of service for Writer)

5.x: x86 not respondind, amd64 out of memory on my pc.
4.3 can open and can  print, but very slow.
File saved in 4.4beta (from metadata).
Comment 2 Maxim Britov 2015-11-29 19:27:52 UTC
Created attachment 120884 [details]
Empty menus at my home pc, but work fine on my another pc.

At my home pc (win7 64 / nvidia 9500gt) Writer 5.x show empty menus.
At my another pc it work fine.
Comment 3 Buovjaga 2015-11-30 11:45:35 UTC
Confirmed.

My whole operating system ground to a halt and I had to take a long break while it thought about the document.

Win 7 Pro 64-bit, Version: 5.0.3.2 (x64)
Build ID: e5f16313668ac592c1bfb310f4390624e3dbfb75
Locale: fi-FI (fi_FI)
Comment 4 Robinson Tryon (qubit) 2015-12-09 18:05:58 UTC Comment hidden (obsolete)
Comment 5 QA Administrators 2017-01-03 19:39:14 UTC Comment hidden (obsolete)
Comment 6 Xavier Van Wijmeersch 2017-11-12 15:25:15 UTC
tested with attachment and no denial of service but very slow opening/closing, very slow saving and almost unworkable.

Version: 5.3.1.2
Build ID: e80a0e0fd1875e1696614d24c32df0f95f03deb2
CPU Threads: 8; OS Version: Linux 4.9; UI Render: default; VCL: kde4; Layout Engine: new; 
Locale: nl-BE (en_US.UTF-8); Calc: group

Version: 5.3.8.0.0+
Build ID: 7f1297d9b4f449eb9ada8008fb21b7046d1a8f19
CPU Threads: 8; OS Version: Linux 4.9; UI Render: default; VCL: kde4; Layout Engine: new; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:libreoffice-5-3, Time: 2017-11-10_15:56:34
Locale: nl-BE (en_US.UTF-8); Calc: group

Version: 6.0.0.0.alpha1+
Build ID: 3ca4d1169c1b6d35eecc980251d6d89ff120ee70
CPU threads: 8; OS: Linux 4.9; UI render: default; VCL: kde4; 
Locale: nl-BE (en_US.UTF-8); Calc: group
Comment 7 Telesto 2017-11-12 18:23:54 UTC
Attachment 120883 [details] contains the same large PNG over and over. It's probably same issue as bug 113038

Working pretty decent with LibO 4.0.0.3
Comment 8 Buovjaga 2017-11-12 18:28:49 UTC
Created attachment 137700 [details]
Callgrind output from master

Arch Linux 64-bit, KDE Plasma 5
Version: 6.0.0.0.alpha1+
Build ID: d73225119476de1826f648acca9e93bf6797e813
CPU threads: 8; OS: Linux 4.13; UI render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on November 12th 2017
Comment 9 Telesto 2017-11-15 11:27:14 UTC Comment hidden (obsolete)
Comment 10 Telesto 2017-11-15 11:29:36 UTC
(In reply to Telesto from comment #9)
Oops, mixed up both attachments. Comment 9 is obsolete
Comment 11 Telesto 2018-02-14 15:58:25 UTC
Repro with
LibreOffice 3.5.7.2 
Build ID: 3215f89-f603614-ab984f2-7348103-1225a5b
Comment 12 QA Administrators 2019-02-19 03:43:16 UTC Comment hidden (obsolete)
Comment 13 Julien Nabet 2019-04-28 18:34:28 UTC
Created attachment 151056 [details]
perf

On pc Debian x86-64 with master sources updated today + enable-symbols without debug, I retrieved a trace from the moment the file was opened.
I clicked on 2 images then closed LO.
Comment 14 Julien Nabet 2019-04-28 18:38:29 UTC
Tomaz: noticing your work about rendering, does the Flamegraph perf graph may help to find what to optimize?
Comment 15 paulystefan 2020-03-16 00:43:13 UTC
LO 6.4.1.2 x64 win10-64

workaround for small file with menu problems

too many animated pictures for LO

extras-options-(german: Barrierefreiheit) handicap freedom -> animated pictures running button  is default enabled

disabled the problem is gone.
Comment 16 paulystefan 2020-03-16 00:48:40 UTC
LO 6.4.1.2 x64 win10-64

second big file 

problem is real in this version.
Comment 17 paulystefan 2020-03-16 14:00:09 UTC
LO 6.4.12.2 x64 win10-64

better behaviour for big file with menu problems

too many animated pictures for LO

extras-options-(german: Barrierefreiheit) handicap freedom -> animated pictures running button  is default enabled

disabled the problem is smaller.
Comment 18 paulystefan 2020-06-20 20:23:50 UTC
LO 7.0.0.0 beta2 x64 win10-64

better behaviour for big file with menu problems

too many animated pictures for LO

extras-options-(german: Barrierefreiheit) handicap freedom -> animated pictures running button  is default enabled

animated pictures disabled, then the problem is solved.
Comment 19 paulystefan 2021-05-17 14:20:39 UTC
better behavior in 7.1.3.2

also with enabled animations

for me, it is solved.

the small test file is heavily increased from 131 kb to 2.647 kb with saving in 7.1.3.2 win64 with open document format 1.3.

in big test file only 3 kb more to 1.703 kb
Comment 20 Buovjaga 2021-05-17 15:07:12 UTC
Great news, let's close
Comment 21 paulystefan 2021-08-05 21:57:24 UTC
ok in LO 7202

the small test file is now ok from 131 kb to 136 kb with saving in 7.2.0.2 win64 with open document format 1.3.

In the big test file, it is only 1 kb more to 1.701 kb.

With enabled animations, my notebook air cooler goes high. 

So it is well solved.

In MSO is the animation not started in work mode.
So there is no performance and heat-making problem.
Comment 22 paulystefan 2022-06-16 13:56:44 UTC
Bug is solved for me in example 1 and 2.

PDF export of example 2 with snow man is buggy.

But this is another location in bug land.

Version: 7.3.4.2 (x64) / LibreOffice Community
Build ID: 728fec16bd5f605073805c3c9e7c4212a0120dc5
CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: CL
Comment 23 Buovjaga 2022-06-16 14:41:06 UTC
(In reply to paulystefan from comment #22)
> PDF export of example 2 with snow man is buggy.
> 
> But this is another location in bug land.

I don't see any bugginess with the snow man in PDF export on Windows or Linux with LibreOffice 7.3. You can report it as a new bug, if you want.