Download it now!
Bug 96396 - libevoablo.so unnecessarily links against GTK+2
Summary: libevoablo.so unnecessarily links against GTK+2
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
5.1.0.0.beta1
Hardware: All All
: medium normal
Assignee: David Tardon
URL:
Whiteboard: target:5.2.0 target:5.1.0.1
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-11 00:09 UTC by Emilio Pozuelo Monfort
Modified: 2016-10-25 19:11 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Emilio Pozuelo Monfort 2015-12-11 00:09:08 UTC
libevoablo.so links against gtk+2 even though it doesn't seem to use it:

emilio@tatooine:/usr/lib/libreoffice/program$ objdump -x libevoablo.so | grep NEEDED | grep gtk
  NEEDED               libgtk-x11-2.0.so.0

This is also true for a few other libraries. From the Debian build log:

pkg-shlibdeps: warning: package could avoid a useless dependency if debian/libreoffice-evolution/usr/lib/libreoffice/program/libevoablo.so was not linked against libpangocairo-1.0.so.0 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/libreoffice-evolution/usr/lib/libreoffice/program/libevoablo.so was not linked against libucbhelper.so (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/libreoffice-evolution/usr/lib/libreoffice/program/libevoablo.so was not linked against libgdk_pixbuf-2.0.so.0 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/libreoffice-evolution/usr/lib/libreoffice/program/libevoablo.so was not linked against libfreetype.so.6 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/libreoffice-evolution/usr/lib/libreoffice/program/libevoablo.so was not linked against libpangoft2-1.0.so.0 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/libreoffice-evolution/usr/lib/libreoffice/program/libevoablo.so was not linked against libfontconfig.so.1 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/libreoffice-evolution/usr/lib/libreoffice/program/libevoablo.so was not linked against libgtk-x11-2.0.so.0 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/libreoffice-evolution/usr/lib/libreoffice/program/libevoablo.so was not linked against libatk-1.0.so.0 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/libreoffice-evolution/usr/lib/libreoffice/program/libevoablo.so was not linked against libcairo.so.2 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/libreoffice-evolution/usr/lib/libreoffice/program/libevoablo.so was not linked against libgdk-x11-2.0.so.0 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/libreoffice-evolution/usr/lib/libreoffice/program/libevoablo.so was not linked against libpango-1.0.so.0 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/libreoffice-evolution/usr/lib/libreoffice/program/libevoablo.so was not linked against libfilelo.so (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/libreoffice-evolution/usr/lib/libreoffice/program/libevoablo.so was not linked against libgio-2.0.so.0 (it uses none of the library's symbols)

Given LO now has a GTK+3 plugin, it'd be good to avoid depending on GTK+2 in other places.
Comment 1 David Tardon 2015-12-11 08:09:05 UTC
Good catch! The dependency was added deep in the OO.o times, by commit 33e3bcc6dacf4437fa82b00e83e0176a7a726e75 (or, rather, by one of the commits merged into that one by the awful OO.o release process). We then dutifully migrated it during conversion to the new build system...
Comment 2 Commit Notification 2015-12-11 08:14:30 UTC
David Tardon committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=b672126e7c4ffd32d42594cf527b09a9f0434cb9

tdf#96396 evoab2 does not need gtk

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Commit Notification 2015-12-11 08:19:48 UTC
David Tardon committed a patch related to this issue.
It has been pushed to "libreoffice-5-1":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=aac08c38c0ca5b24a395735cb64db2a98e2d6e62&h=libreoffice-5-1

tdf#96396 evoab2 does not need gtk

It will be available in 5.1.0.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.