Bug 96422 - LOKView No signal when search was successful
Summary: LOKView No signal when search was successful
Status: UNCONFIRMED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
5.2.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: LOKDocView
  Show dependency treegraph
 
Reported: 2015-12-11 17:38 UTC by Bastien Nocera
Modified: 2023-11-22 14:50 UTC (History)
8 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bastien Nocera 2015-12-11 17:38:05 UTC
It looks like 'search-result-count' isn't emitted anymore, which makes it problematic for knowing when to enable the find next/prev buttons.

I would expect to:
- disable the next/prev buttons
- launch highlight_all('my-search-string');
- wait for search-result-count > 0 (or a "search-found" signal) to enable the next/prev buttons
Comment 1 Xisco Faulí 2017-03-02 10:39:24 UTC
Dear Reporter,
Could you please try to reproduce it with the latest version of LibreOffice
from https://www.libreoffice.org/download/libreoffice-fresh/ ?
I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' if the bug is still present in the latest version.
Comment 2 QA Administrators 2017-08-30 19:27:43 UTC Comment hidden (obsolete)
Comment 3 Bastien Nocera 2017-08-30 19:29:38 UTC
The bug is as much there as it was when I filed it, as far as I know.
Comment 4 Jean-Baptiste Faure 2018-06-17 16:58:45 UTC
I do not see any mean to test this bug report.

Please, could you describe a step by step procedure to reproduce this problem?

Status set to NEEDINFO, please set it back to UNCONFIRMED once requested
informations are provided.

Best regards. JBF
Comment 5 Bastien Nocera 2018-06-18 10:05:06 UTC
(In reply to Jean-Baptiste Faure from comment #4)
> I do not see any mean to test this bug report.

Write a program that uses the LOKDocView, and connect to the search-result-count. This is all in comment 0.
Comment 6 Xisco Faulí 2018-12-17 12:52:44 UTC
Hi Kendy,
Do you know anyone who could investigate this issue ?
Comment 7 Jess Adams 2021-02-18 08:11:25 UTC Comment hidden (spam)
Comment 8 Xisco Faulí 2021-04-30 09:46:40 UTC
Hello Bastien,
is this issue still reproducible in a master build ?
I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the bug is still present in the master build
Comment 9 Bastien Nocera 2021-04-30 10:01:57 UTC
(In reply to Xisco Faulí from comment #8)
> Hello Bastien,
> is this issue still reproducible in a master build ?
> I have set the bug's status to 'NEEDINFO'. Please change it back to
> 'UNCONFIRMED' if the bug is still present in the master build

I don't think that me testing for bugs that nobody intends on fixing is a good use of my time.
Comment 10 QA Administrators 2021-05-01 03:57:14 UTC Comment hidden (obsolete)
Comment 11 Buovjaga 2023-11-22 14:20:59 UTC
Miklos: looks like you added LOKDocView::search-result-count in 22d342a82f225381057b5b8b941be8583de87a63.

Kendy made a pretty important typo fix in c0f37892a24b202c0a28836ed1046c90c7631e03

Bastien's report was made only two months after the implementation.

A note to Bastien: if you had included an example program, a tester with no experience with LOKit might have bisected the issue and essentially handed it to developers on a silver platter.
Comment 12 Bastien Nocera 2023-11-22 14:50:15 UTC
(In reply to Buovjaga from comment #11)
> Miklos: looks like you added LOKDocView::search-result-count in
> 22d342a82f225381057b5b8b941be8583de87a63.
> 
> Kendy made a pretty important typo fix in
> c0f37892a24b202c0a28836ed1046c90c7631e03
> 
> Bastien's report was made only two months after the implementation.
> 
> A note to Bastien: if you had included an example program, a tester with no
> experience with LOKit might have bisected the issue and essentially handed
> it to developers on a silver platter.

The person working on LOKit was the same person working on the gnome-documents backend, so they would have known how to test this.

I'm not sure that advice on how to report a good bug 8 years after it was filed is as useful as you think it is.

In any case, gnome-documents doesn't exist anymore, so feel free to close this.