We have tons of instances of the 'long' integer literals 0L and 1L in the code. (And also some 2L etc.) I am fairly certain that in the majority of cases, no compiler warnings would be produced, and the semantics of the code would be identical, and the generated machine code would be identical, if the 'L' was dropped. But feel free to prove me wrong, of course. If you want to work on this, don't change them all in one go. Do it a "reasonable" number of source files at a time. (So that the total number of changed lines in each change is a hundred or so.) And make sure that you indeed don't introduce any compiler warnings. Don't do a change if you are at all unsure whether it indeed might have a semantic effect on what the code means.
Don't do this for any argument of CPPUNIT_*EQUAL* or std::min/std::max (unless the template type is explicitly specified). That would cause compilation failure on some platforms.
JanI is default CC for Easy Hacks (Add Jan; remove LibreOffice Dev List from CC) [NinjaEdit]
Aleksas Pantechovskis committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=57d0caacee2f395be2e89b78f8ece2d47b2c8683 tdf#96505 Remove long integer literal specifier when not needed It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Thanks for taking up this.
i'm not sure if it's a good idea to do this as an easy-hack: there is a nasty corner case with vararg calls that could bite us in annoyingly platform dependent ways. http://blog.regehr.org/archives/1303
But if we have code passes 0L as a vararg where the callee is expecting a pointer, this is already broken for 64-bit Windows, where long is 32-bit, right?
Michael Stahl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=ba0a866b83f016fd460320e7d057dd107e019f19 tdf#96505: fix wrong SfxDispatcher::Execute calls ... It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
slideon committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=75092faa821b236eaed27b7d0e6f1f1a28d1a2e2 tdf#96505 Remove 0L occurences from avmedia and basegfx modules It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
erdemdemirkapi committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=e070fa3eab9cef868aab38643060e20ae0c77b26 tdf#96505 Get rid of cargo cult long integer literals It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Controlled, still open
apurvapriyadarshi committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=4537a027c5c734e094191d01a46c2da734dbfe5b tdf#96505 Get rid of cargo cult long integer literals It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
krishna keshav committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=3c573174dab0f1c6a85ce50ad4210c8772bdcf9a tdf#96505 Get rid of cargo cult long integer literals It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Assuming still open
apurvapriyadarshi committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=e4b332358789c0d4df88401021c17e0c88671eb3 tdf#96505 Get rid of cargo cult long integer literals It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
is this still open..if so i can fix this. can you show me good starting pointers
(In reply to Nadith Malinda from comment #15) > is this still open..if so i can fix this. > can you show me good starting pointers Yes there are still tons of long constant in the code, follow the advice in comment #1. This is one of the cases, where you have to search the code using e.g. opengrok.libreoffice.org Have a look at https://wiki.documentfoundation.org/Development/GetInvolved Have fun rgds jan I.
Helllo I would like to contribute to this bug as my first bug fixing. Can you show me starting pointers.
(In reply to Asela from comment #17) > Helllo > > I would like to contribute to this bug as my first bug fixing. > Can you show me starting pointers. Welcome, there are no special code pointers for this bug, because the e.g. 0L is distributed all over the code. use e.g. http://opengrok.libreoffice.org/ to find the lines. Please also have a look at: https://wiki.documentfoundation.org/Development/GetInvolved
Thanks jan for help. Sorry for late reply. I am working on it.
Asela Dasanayaka committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=cf0fea5546c9b6b30d18deb084ddaa5e08aad41b tdf#96505 get rid of "long" integer literals 'L' It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Please be aware, that this easyhack is considered an important but large scale cosmetic change as described in https://wiki.documentfoundation.org/Development/LargeScaleChanges It was in decided by the ESC to close this kind of easyhacks, and send them directly as mail, to new contributors. https://lists.freedesktop.org/archives/libreoffice/2016-August/074920.html Please do not submit patches with many files !! This particular easyhack is kept open as an exception to the rule
Asela Dasanayaka committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=a9bda90b3ad8ad8bb1e76c73e10df5c73607907f tdf#96505 get rid of long integer literals 'L' It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Asela Dasanayaka committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=9fcfe485cd23d7e560aa05efbd02401d62d144dd tdf#96505 get rid of "long" integer literals 'L' It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Asela Dasanayaka committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=057ae1cfcac518e5693e75aca87d307ce90ba6fb tdf#96505 get rid of "long" integer literals 'L' It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
e12346 committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=171201c574b325653794bcd851d0aa7a80dc3249 tdf#96505 - Remove "long" integer literals in vcl/source/gdi/ It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Rosen committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=dad35b0463a16d3d6eca068100e95822ae466a9a tdf#96505 Get rid of cargo cult "long" integer literals It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Rosen committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=622bb4bc72ee6e8eae3193e80e13748be150e1e0 tdf#96505 Get rid of cargo cult "long" integer literals It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
This does not apply to the "external" directory.
Rosen committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=8ae33b1652cb1e654c426350169d3bb9fa031a4f tdf#96505 Get rid of cargo cult "long" integer literals It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
jan iversen committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=9183e2cec024c28fb26f9f9f83530bd002d539c9 Revert "tdf#96505 Get rid of cargo cult "long" integer literals" It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I am starting work on this bug. This will be my first LibreOffice bug.
No need to assign the bug to yourself if you want to work on this. There are so many of these that there is room for several people to work on them at the same time.
Also note that doing this just mechanically, without actually checking in what cases there might be a reason to use a long literal, is way too trivial and does not pre-qualify you for GSoC. (In my opinion, but I am not a (potential) GSoC mentor.)
I understand . I will try to give meaningful commits.
dilekuzulmez committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=e73505fe0fb44075b462a20a3b2091063db5e1b3 tdf#96505 Get rid of cargo cult long integer literals It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
udaycoder committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=68bd686b2ca62602fd4b580b905baaa0a04d1f3c tdf#96505 - Get rid of cargo cult long integer literals It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Thomas Beck committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=659cb8466495a15a680f684ec4aa1f1d3c4225cc tdf#96505 Get rid of cargo cult "long" integer literals It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
dilekuzulmez committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=ef5757ab06743fc56d5bf74d7244edf01acfa842 tdf#96505 Get rid of cargo cult long integer literals It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
A polite ping, still working on this bug
Hello, I am new here. Can I contribute to this bug as my first bug? Is this bug still open?
Just git grep for such literals and see?
Hello, I would like to contribute to this bug as my first bug fix. Is this bug still open?
See the literally previous comment...
Thanks. I'll get started and see.
Jens Carl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=998532d8542b87b4069416ca48d1fc90e8d8ed70 tdf#96505 Get rid of cargo cult "long" integer literals It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Created attachment 134576 [details] Remove "long" literals from cui/source/tabpages directory
Ivan Safonov committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=d2adc30aa0bb843ace819277c68871a86a8418e8 tdf#96505 Get rid of cargo cult "long" integer literals It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
66kesara99 committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=16549dc267149aaf098191591acb20024ea21513 tdf#96505 Get rid of cargo cult "long" integer literals It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Please don't assign this bug to yourself. There is room for multiple people working on this bug. Nobody is going to "fix" all the cases of cargo cult long literals.
udareechk committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=2f3b95246362aa8290e06b29fc44ee8dafa48aa8 tdf#96505 Get rid of cargo cult long integer literals It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
udareechk committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=f89b3d4bc24a3237f404bb6cb449ce28ce3f5a08 tdf#96505 Get rid of cargo cult long integer literals It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
udareechk committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=bafc68b9e72cab0de949a8f2bc49a832c3517623 tdf#96505 Get rid of cargo cult long integer literals It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
udareechk committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=1fe94cb6152737632e543ef8f8534f15203dc747 tdf#96505 Get rid of cargo cult long integer literals It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
udareechk committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=022b1b2a40fcaf8d201081dead44c1d3346d1972 tdf#96505 Get rid of cargo cult long integer literals It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
udareechk committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=f9b3a1db585e103bb93be0b5954de6858ad42c51 tdf#96505 Get rid of cargo cult long integer literals It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
ekuiitr committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=c7d3440fed86c7ef986cdaf57dfe2017325ff190 tdf#96505 removed "L" literal It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
tagezi committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=baadb184e84568acd1c6efda95c3715b05818da3 tdf#96505 Deleted suffix long (L) where it is possible It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Please don't assign this bug to yourself, there is ample work available here for multiple people to work on in parallel. (Just mention what part of the codebase you are looking at in a comment if you want to make sure nobody else is working on the same part at the same time.) Also, note that even if I files this bug as an EasyHack, I now more think that this is actually the kind of thing that could better be solved by a Clang rewriting plug-in. Also, in my opinion, submitting a commit for this EasyHack that changes just a few long literals to plain int ones does not really require much skill, so if I were a GSoC mentor (I am not), I would not put too much value into it.
Note that for actual impressiveness, it would be nice to also see some newbie take me up on the "feel free to prove me wrong" part of the initial comment;) Such a write-up on some part of the code where long literals are now used might be a sign of deeper understanding of some aspect of the code and C++.
No warnings now. No change in semantics if changed. Careful with corner cases when fixing... What's the point? What are the expected benefits?
@Baltasar: The benefit is to get rid of the cargo cult long integer literals. Avoiding the possibility that somebody reading the code things that it actually makes a difference to have those integer literals "long". And copying that without thinking. Code is read much more than it was written. Tens of years later. By other people. We certainly know that in LibreOffice, where parts of the codebase is over 20 years old. And full of weird stuff that you don't know whether it actually has a meaning.
Kemal Ayhan committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3a3110564bcda4678fb804d01013e226fd2fbe93 tdf#96505 - Get rid of cargo cult long integer literals It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Yusuf Keten committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9ef226c581ddf025e36aebefaa48c051354c520b tdf#96505 Get rid of cargo cult long integer literals It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Yusuf Keten committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f69fa576c579a88853a563aed1b947319b6ffcf1 tdf#96505 Get rid of cargo cult long integer literals It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
ayhanyalcinsoy committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c1599fc5c9800086548595d1f1464619a7024d06 tdf#96505:Get rid of cargo cult long integer literals It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
ASSIGNED TO shivamhere247@gmail.com
Onur Yilmaz committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/2065cbf576e7d3257e7da2151419404928326df3 tdf#96505: Get rid of cargo cult long integer literals It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Onur Yilmaz committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b44ad15cd78892f2f1d7fe83ccda9fc41dc9c9a5 tdf#96505: Get rid of cargo cult long integer literals It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Onur Yilmaz committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ece847579e606efc0398c01b5a91101111623935 tdf#96505: Get rid of cargo cult long integer literals It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Onur Yilmaz committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4a88e0c6e90c1c2cba33b8626564429f54b74c0b tdf#96505: Get rid of cargo cult long integer literals It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
iakarsu committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/446af1fd2b76dfe32a3f947b683a4e36122cea37 tdf#96505: Get rid of cargo cult long integer literals It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Desmin Alpaslan committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f17f9bf0b3e5e548a8ef40206ebed180bda14931 tdf#96505: Get rid of cargo cult long integer literals It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Shivam Kumar Singh committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/03685b1ab86a9b8d78ad2a4fd460c2aaa50f03ab tdf#96505 Get rid of cargo cult "long" integer literals . It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Gökhan Özeloğlu committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/561e5559bb68242c7f785f0ca3bee3eb12b58963 tdf#96505: Get rid of cargo cult long integer literals It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
umutbayramoglu committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9feea2ecc59c6daa42dece6c30cf33f5e7df7561 tdf#96505 : Get rid of cargo cult long integer literals It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Alchemist committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/8bce488df9921c845841677c17fd5f2e8c4c6dac tdf#96505 Get rid of cargo cult 'long' integer literals It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I think this Easy Hack has outlived its usefulness now. Most of the 0L and 1L are gone. Remaining long literals are far from easy to check whether dropping the L will cause issues or not. Resolving as fixed and removing the keywords.
(What I actually mean is of course that I personally have no interest in this any longer now, and as I filed this (non-)bug, I can close it too.)