One of our custom install functions CheckInstallDirectory (in Library_shlxtmsi, compiled from setup_native/source/win32/customactions/shellextensions/checkdirectory.cxx) will always claim that the target installation directory is empty, and therefore OK to install into, as it is checking for the wrong file. It does this as it inserts the string "LibreOffice 5" between the actual install location and the file it's trying to test for. Spotted this whilst looking to eliminate _tstring/TCHAR and Win32 ANSI API calls. Verified by adding debug output to this custom installer DLL in a build of 5.1 beta2 and forcing LO install into a differently named directory containing a program\setup.ini file. git diff \ -r 4dd1fa636a7408ba04777435911f8b1cb5da7587 \ -r d5c1f2e15d2b80346f02612919dc5de014153bb8 \ setup_native/source/win32/customactions/shellextensions/checkdirectory.cxx - std::_tstring sSetupIniPath = sInstallPath + TEXT("program\\setup.ini"); + std::_tstring sSetupIniPath = sInstallPath + sOfficeHostnamePath + TEXT("\\program\\setup.ini"); *** BUT the worst thing is that this function is called too late in the MSI InstallExecuteSequence AFTER all the files have been copied anyway, so it would end up testing for a file which always DID exist... I think that the best thing to do is to actually eliminate this function from the installer.
Hello Stuart, it seems you're using an old version of LibreOffice. Could you please try to reproduce it with the latest version of LibreOffice from https://www.libreoffice.org/download/libreoffice-fresh/ ? I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the bug is still present in the latest version.
Dear Bug Submitter, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping-20171030
Dear Bug Submitter, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-20171204