Bug 96677 - Alt+s Hot Key At Effects Dialog Incorrectly Mapped
Summary: Alt+s Hot Key At Effects Dialog Incorrectly Mapped
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.0.6.2 release
Hardware: All All
: medium minor
Assignee: Caolán McNamara
URL:
Whiteboard: target:5.3.0 target:5.2.1
Keywords: bibisected, regression
Depends on:
Blocks:
 
Reported: 2015-12-23 04:24 UTC by Joel Madero
Modified: 2016-08-02 15:21 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joel Madero 2015-12-23 04:24:35 UTC
Bodhi Moksha
Version: 5.2.0.0.alpha0+
Build ID: 5df326438fd3a5613a52b4de1935426911ff1301

1) Open writer;
2) alt+o -> c (opens character dialog);
3) Select "Font Effects" tab


Observed: No underline for any of the options available (for instance strikethrough should have an underline under "s")

4) Push "alt"

Observed: See underlines under appropriate letters (for instance under "s" in strikethrough)

 
5) alt + s

Expected: Get to strikethrough options;
Observed: Gets to "Effects" instead

Note: I did not test each and every options. Based on a part of bug 80612
Comment 1 Joel Madero 2015-12-23 04:53:16 UTC
Important: At some point "alt+s" was used to trigger "shadow" instead of "strikethrough" - but it worked as expected (did not select effects instead). So "good" was valid for "shadow". If a second bibisect is needed to determine when strikethrough changed to shadow for alt+s just request it and I'll do it.

It seems *very* likely that when s was moved back from shadow to strikethrough...the problems occurred.

Bibisect 1: Alt+s incorrectly mapped to effects f076560b5b9947a5b316efb4764d697f80e53afb is the first bad commit
commit f076560b5b9947a5b316efb4764d697f80e53afb
Author: Bjoern Michaelsen <bjoern.michaelsen@canonical.com>
Date:   Thu Oct 17 18:00:51 2013 +0000

    source-hash-420aa16af0bbab4bdef80ceeb8d44cabe65840e0
    
    commit 420aa16af0bbab4bdef80ceeb8d44cabe65840e0
    Author:     Michael Stahl <mstahl@redhat.com>
    AuthorDate: Fri Jul 12 19:04:21 2013 +0200
    Commit:     Michael Stahl <mstahl@redhat.com>
    CommitDate: Fri Jul 12 19:23:06 2013 +0200
    
        fdo#66745: drawinglayer: properly restore anti-aliasing mode
    
        VclPixelProcessor2D: the constructor changes the anti-aliasing mode of
        the given output device, and the destructor restores a hard-coded mode
        instead of what was there before.
    
        Due to this commit 5913506b2193e93ca2767ab7365ab2e76ed7848f turned off
        anti-aliasing for FontWork objects simply by creating a
        temporary VclPixelProcessor2D.
    
        Change-Id: I7f7fcbf86b0dd425f599cd8e62fce3c69a2744bb

:100644 100644 e77d6562a032ab72f4f6687b79ee3ddb0a8b9ac7 cf818efc4efa98dc54c53ec32be6b8413e1538d8 M	ccache.log
:100644 100644 440acef13e7e01f69e2e977deeded3b1f85c14c2 b2b4cae57b151f1949a6a8aceca17a54686d0076 M	commitmsg
:100644 100644 b8596aef3d1c51c964a23adfd6c9e3a188d0d57b 90cc6f203d87a733288a1e3fd816324b62c25e45 M	dev-install.log
:100644 100644 bef4904693793b8ab0e56f05a36436b3a4155fd4 911329c9e7f5014dd76c62bfbf78e1b260884f17 M	make.log
:040000 040000 a81dc7173b6b8a0d4f48d0cdaacedfb3af9c29b2 854f5173fa9f68a863965820d7bc55a592050424 M	opt

# bad: [423a84c4f7068853974887d98442bc2a2d0cc91b] source-hash-c15927f20d4727c3b8de68497b6949e72f9e6e9e
# good: [65fd30f5cb4cdd37995a33420ed8273c0a29bf00] source-hash-d6cde02dbce8c28c6af836e2dc1120f8a6ef9932
git bisect start 'latest' 'oldest'
# good: [e02439a3d6297a1f5334fa558ddec5ef4212c574] source-hash-6b8393474974d2af7a2cb3c47b3d5c081b550bdb
git bisect good e02439a3d6297a1f5334fa558ddec5ef4212c574
# bad: [4850941efe43ae800be5c76e1102ab80ac2c085d] source-hash-980a6e552502f02f12c15bfb1c9f8e6269499f4b
git bisect bad 4850941efe43ae800be5c76e1102ab80ac2c085d
# skip: [a043626b542eb8314218d7439534dce2fc325304] source-hash-9379a922c07df3cdb7d567cc88dfaaa39ead3681
git bisect skip a043626b542eb8314218d7439534dce2fc325304
# skip: [aba65c3e4c0df07e4909aeefb758cdb688242bf6] source-hash-827524abfb4b577d08276fde40929a9adfb7ff1a
git bisect skip aba65c3e4c0df07e4909aeefb758cdb688242bf6
# skip: [aba65c3e4c0df07e4909aeefb758cdb688242bf6] source-hash-827524abfb4b577d08276fde40929a9adfb7ff1a
git bisect skip aba65c3e4c0df07e4909aeefb758cdb688242bf6
# bad: [c81a8a0dcfc1ed095a80e4485c89dd0fcaf73f31] source-hash-c69ed33628ec0b7abf6296539cf280d6c4265930
git bisect bad c81a8a0dcfc1ed095a80e4485c89dd0fcaf73f31
# bad: [c81a8a0dcfc1ed095a80e4485c89dd0fcaf73f31] source-hash-c69ed33628ec0b7abf6296539cf280d6c4265930
git bisect bad c81a8a0dcfc1ed095a80e4485c89dd0fcaf73f31
# bad: [1d4980621741d3050a5fe61b247c157d769988f2] source-hash-89d01a7d8028ddb765e02c116d202a2435894217
git bisect bad 1d4980621741d3050a5fe61b247c157d769988f2
# bad: [ba096f438393091574da98fe7b8e6b05182a8971] source-hash-8499e78ca03c792f4fa2650e02b519094ba0baa8
git bisect bad ba096f438393091574da98fe7b8e6b05182a8971
# good: [9daa289e178460daaafa4b3911031df5b8736218] source-hash-704292996a3731a61339b1a4a5c90c9403aa095f
git bisect good 9daa289e178460daaafa4b3911031df5b8736218
# good: [34eab3946c46bb7273ba4ca395db9c4421dd232f] source-hash-e962805b31074d6b6a2ed0db6452769448337553
git bisect good 34eab3946c46bb7273ba4ca395db9c4421dd232f
# bad: [a8577b9049e085140768f97f7d4ff555a8a447cb] source-hash-98ded3e42011b060368899018c07cbd32e7993f1
git bisect bad a8577b9049e085140768f97f7d4ff555a8a447cb
# bad: [e128a0b9bd133d989b87354bd271ef25c642b7bc] source-hash-7be71336862204f0763fc2f8cf62a6f48f341114
git bisect bad e128a0b9bd133d989b87354bd271ef25c642b7bc
# bad: [f076560b5b9947a5b316efb4764d697f80e53afb] source-hash-420aa16af0bbab4bdef80ceeb8d44cabe65840e0
git bisect bad f076560b5b9947a5b316efb4764d697f80e53afb
# first bad commit: [f076560b5b9947a5b316efb4764d697f80e53afb] source-hash-420aa16af0bbab4bdef80ceeb8d44cabe65840e0

+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

bibisect 2: tried to find when underline disappeared

Note: Really weird - can't repro in bibisect packages (tried each 35all, 45max, 50max)
Comment 2 Joel Madero 2015-12-23 04:54:42 UTC
Note: The missing underline might be a feature (weird?) but if you HOLD alt then they all appear...makes more sense for them to always be visible but I leave that for UX to decide.
Comment 3 Commit Notification 2016-07-29 09:59:07 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=b3b7669e7fb74b04d925f21a7f0b048434eeffa3

Resolves: tdf#96677 effects page didn't link labels to what they labelled

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Caolán McNamara 2016-07-29 10:03:15 UTC
alt press/release to show/hide accelerators is a gtk thing is working (in this case at least) correctly. The jumping to the wrong place is the substantive problem and is because the .ui didn't set the mnemonic widgets for the labels correctly.
Comment 5 Commit Notification 2016-08-02 15:21:59 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-5-2":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=9804ec09742f39bcc1cd02fdb4de3ca251d5f5d2&h=libreoffice-5-2

Resolves: tdf#96677 effects page didn't link labels to what they labelled

It will be available in 5.2.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.