Bug 96771 - Android: Viewer cannot open owncloud files which have spaces in filename (crash)
Summary: Android: Viewer cannot open owncloud files which have spaces in filename (crash)
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Android Viewer (show other bugs)
Version:
(earliest affected)
5.2.0.0.alpha0+
Hardware: All Android
: medium major
Assignee: Not Assigned
URL:
Whiteboard: target:5.3.0
Keywords:
Depends on:
Blocks: 96786
  Show dependency tree / graph
 
Reported: 2015-12-29 11:48 UTC by Faruk Uzun
Modified: 2016-10-23 15:05 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:

Attachments
Logs from crash (238.68 KB, image/jpeg)
2015-12-29 11:48 UTC, Faruk Uzun 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Faruk Uzun 2015-12-29 11:48:04 UTC 
Created attachment 121596 [details]
Logs from crash

When I try to open a file which have a name like "x y z.odt" from my owncloud server, app crashes instantly. 

Steps to Reproduce

1) Connect to an owncloud server
2) Try to open a file which have spaces in filename

Logs on the attachement.
Comment 1 Faruk Uzun 2015-12-29 12:11:54 UTC 
Btw, ownCloud 8.1 is running on my server
Comment 2 raal 2016-05-07 14:40:16 UTC 
I can confirm with 5.2, android 4.4

Tested on demo.owncloud.org , file 'demo textfile - licence.txt'


Log:
java.lang.IllegalArgumentException: Illegal character in path at index 5: /Demo Textfile - License.txt
	at java.net.URI.create(URI.java:727)
	at org.libreoffice.storage.owncloud.OwnCloudFile.getUri(OwnCloudFile.java:42)
	at org.libreoffice.ui.LibreOfficeUIActivity$7.onPostExecute(LibreOfficeUIActivity.java:388)
	at org.libreoffice.ui.LibreOfficeUIActivity$7.onPostExecute(LibreOfficeUIActivity.java:354)
	at android.os.AsyncTask.finish(AsyncTask.java)
	at android.os.AsyncTask.access$600(AsyncTask.java)
	at android.os.AsyncTask$InternalHandler.handleMessage(AsyncTask.java)
	at android.os.Handler.dispatchMessage(Handler.java)
	at android.os.Looper.loop(Looper.java)
	at android.app.ActivityThread.main(ActivityThread.java)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:515)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:788)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:604)
	at dalvik.system.NativeStart.main(Native Method)
Comment 3 Commit Notification 2016-08-28 07:14:22 UTC 
Mert Tumer committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=5bdea25f681fb252967f99a22a38cce6be3c0b48

tdf#96771 - bug fix for owncloudfiles with white space characters

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Xisco Faulí 2016-10-03 10:01:35 UTC 
Hello,
Is this bug fixed?
If so, could you please close it as RESOLVED FIXED?