We can toggle Modes Tab Bar visibility by the menu View > Modes Tab Bar. But, when opening new presentation after making it visible, it always disappear i.e. the effect of toggling is lost. This behaviour seems unintended according to [1], and also stays in master branch. How to reproduce: 0. start LibreOffice 1. create new presentation e.g. by clicking "Impress Presentation" in the sidebar 2. click menu View > Modes Tab Bar (You will see Modes Tab Bar appear.) 3. create another presentation e.g. by clicking Ctrl+N (Then you will find Modes Tab bar is hidden as by default.) Expected behaviour: Modes Tab Bar keeps the visibility. [1] http://listarchives.libreoffice.org/global/design/msg07534.html
On a current master -- c71b5b4d2ec76c0a204f9515dece1e0e0689ce3c Confirming as described. Setting is not retained when active from Impress session-to-session. Either when selected from View -> Modes Tab Bar, or when using the "Toggle Tab Bar visibility" button active on the Standard menu. @Philippe, any comment on your intended statefulness of the setting--should it be retained between sessions, and can it be adjusted to do so as the Mode tab bar control is currently structured?
And please remove the icon from the menu. Setting an option on/off is done by a checkbox to have a clear visual clue. An icon make sense only at toggle buttons on toolbars.
We talked about the issue at the weekly design meeting with the decision: * Hide the tabs bar by default. * Show toggle display-tabs-bar button in the toolbar now. But then hide the toggle button from release 5.2 on (aiding transition). * Move display-modes split button and the toggle-tabs-bar button to the right edge of the standard toolbar. * Store last user setting For the toggle button please use a checkbox in the menu and an icon at the toolbar Future enhancements: * Think about changing access to master slides for 5.x/6.x Bubli offered her help on IRC (assignment done). Please fix the bug and do the small changes for the upcoming release (importance: high)
thanks :) !
I proposed something here : https://gerrit.libreoffice.org/21541. Review appreciated :-) Philippe
Philippe Jung committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=87084436d39662636e92dd03a5161293efb80948 tdf#97119 Make TabBarVisible configuration persistant It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
What are the versions to target with this patch ? Code is pushed into master I have initiated cherry pick into 5.1 Are we also targetting 5.1.0 ?
(In reply to Philippe Jung from comment #7) > What are the versions to target with this patch ? > Code is pushed into master > I have initiated cherry pick into 5.1 > Are we also targetting 5.1.0 ? Since there will be a 5.1.0rc3, perhaps the triple review to get it into 5.1.0 and be done with it, rather than the wait for 5.1.1, is worth the effort? But--that is not my call.
Philippe Jung committed a patch related to this issue. It has been pushed to "libreoffice-5-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=f9b0fec2ff0a17ae851077a2b74a0e9d6fc38476&h=libreoffice-5-1 tdf#97119 Make TabBarVisible configuration persistant It will be available in 5.1.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philippe Jung committed a patch related to this issue. It has been pushed to "libreoffice-5-1-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=bef97e1e067b4e0ef48c0ea8966c8107a0d2b6d4&h=libreoffice-5-1-0 tdf#97119 Make TabBarVisible configuration persistant It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.