Bug 97218 - REMOVE comment will crash impress
Summary: REMOVE comment will crash impress
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
5.1.0.2 rc
Hardware: All Linux (All)
: high major
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2016-01-18 00:34 UTC by Marek Dolezel
Modified: 2016-10-10 12:08 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marek Dolezel 2016-01-18 00:34:14 UTC 
1. Create impress presentation
2. add comment
3. delete comment or delete all comments 
4. crash to Libreoffice document recovery

LO:
Version: 5.1.0.2
Build ID: 5.1.0.2-3.fc24
CPU Threads: 4; OS Version: Linux 4.4; UI Render: default; 
Locale: en-GB (en_GB.UTF-8)

OS:
Fedora release 24 (Rawhide) under wayland
Comment 1 Marek Dolezel 2016-01-18 01:03:28 UTC 
Reproduced with 
Version: 5.2.0.0.alpha0+
Build ID: 5486688f87f0999b156e1e5085c616d72270e50a
CPU Threads: 4; OS Version: Linux 4.4; UI Render: default; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2016-01-17_10:25:20
Locale: en-GB (en_GB.UTF-8)
Comment 2 FutureProject 2016-01-18 01:40:24 UTC 
Unable to reproduce.

Windows 10 Pro, Version 1511 (OS Build 10586.36)

Version: 5.0.3.2 (x64)
Build ID: e5f16313668ac592c1bfb310f4390624e3dbfb75-GL
Locale: de-DE (de_DE)

Version: 5.0.4.2
Build ID: 2b9802c1994aa0b7dc6079e128979269cf95bc78
Locale: en-US (de_DE)

Version: 5.1.0.2 (x64)
Build ID: ecd3574d51754b043f865cf5bafee286d24db7cc
CPU Threads: 4; OS Version: Windows 6.19; UI Render: GL; 
Locale: de-DE (de_DE)
Comment 3 Marek Dolezel 2016-01-18 19:37:43 UTC 
(In reply to FutureProject from comment #2)
> Unable to reproduce.
> 
> Windows 10 Pro, Version 1511 (OS Build 10586.36)
> 
> Version: 5.0.3.2 (x64)
> Build ID: e5f16313668ac592c1bfb310f4390624e3dbfb75-GL
> Locale: de-DE (de_DE)
> 
> Version: 5.0.4.2
> Build ID: 2b9802c1994aa0b7dc6079e128979269cf95bc78
> Locale: en-US (de_DE)
> 
> Version: 5.1.0.2 (x64)
> Build ID: ecd3574d51754b043f865cf5bafee286d24db7cc
> CPU Threads: 4; OS Version: Windows 6.19; UI Render: GL; 
> Locale: de-DE (de_DE)

Can you try on Fedora?
Comment 4 raal 2016-01-18 21:00:26 UTC 
I can confirm crash with Version: 5.2.0.0.alpha0+
Build ID: 75f0f9d5538577e0d4923b4d46ba6f88b6199814
CPU Threads: 4; OS Version: Linux 4.2; UI Render: default; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2016-01-12_14:23:15
Comment 5 raal 2016-01-19 12:52:04 UTC 
This seems to have begun at the below commit.
Adding Cc: to Noel Grandin; Could you possibly take a look at this one? Thanks

 2cbeb0b41125c058ffa68266dc15015d3da0cc16 is the first bad commit
commit 2cbeb0b41125c058ffa68266dc15015d3da0cc16
Author: Norbert Thiebaud <nthiebaud@gmail.com>
Date:   Tue Nov 24 15:54:55 2015 -0800

    source dd351dd728687cffe432ce0ec9367ceb80e097fb

    source dd351dd728687cffe432ce0ec9367ceb80e097fb

:040000 040000 c4c97c772f77b104077790c9c0a94e94bb034bb4 4d3cef0361423f5a763e933b48e2a71cf0eba785 M      instdir

author	Noel Grandin <noel@peralex.com>	2015-11-24 06:50:39 (GMT)
committer	Noel Grandin <noelgrandin@gmail.com>	2015-11-24 08:17:55 (GMT)
commit dd351dd728687cffe432ce0ec9367ceb80e097fb (patch)
Comment 6 Noel Grandin 2016-01-19 12:58:19 UTC 
This should have been fixed by commit 8a86d673140febc39be2044d2feb7c28fd307aa0

which reverted the relevant bits
Comment 7 Xisco Faulí 2016-02-03 14:04:00 UTC 
I can't reproduce the issue in

Version: 5.2.0.0.alpha0+
Build ID: 0e7cd653ea90da388820220bf6a3eb140b57bbd6
CPU Threads: 1; OS Version: Linux 4.2; UI Render: default; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2016-01-25_00:31:55
Locale: en-US (en_US.UTF-8)

Thus, close this as RESOLVED FIXED
Comment 8 Marek Dolezel 2016-05-02 07:38:28 UTC 
I am glad now this is fixed in 5.2.*, however new Ubuntu 16.04 suffers from this bug (happens only in impress).

I am therefore reopening this bug, as this needs to be fixed in all currently supported versions.

Version: 5.1.2.2
Build ID: 1:5.1.2-0ubuntu1
CPU Threads: 4; OS Version: Linux 4.4; UI Render: default; 
Locale: en-US (en_US.UTF-8)
Comment 9 Michael Stahl (allotropia) 2016-05-10 12:58:18 UTC 
the commit from comment #6 was found already backported to libreoffice-5-1 branch

testing on Fedora 24 upgraded yesterday with gtk3 vclplug in gnome-shell Wayland
didn't find any crashes when inserting/deleting comments in Impress