For instance the include/vcl/salnativewidgets.hxx file contains lots off stuff that is not used outside vcl. It would be better to have that in a separate include file inside vcl, for instance vcl/inc/nativewidgets.hxx.
There might be a little confusion around this one for newbies. include/vcl/salnativewidgets.hxx is used for any module that needs to access specific classes or functions of VCL. You'll see what sort of things need this because there is a SAL_DLLPUBLIC decorator in the class or function. If the class/function doesn't have a SAL_DLLPUBLIC attribute decorating it, then there is a good chance that it should be moved to the "private" vcl headers, which are found at vcl/inc/* - Tor's suggestion is to move them into vcl/inc/nativewidgets.hxx - but don't feel constrained in this - if there is a better header filename then try this instead. If it's wrong, then it's wrong and we'll advise you - but if you think it's more specialized then there is a good likelihood it's better off in a different header! As an example, there is a class called ControlCacheKey: http://opengrok.libreoffice.org/xref/core/include/vcl/salnativewidgets.hxx#257 Clicking on the link and searching for symbols that reference it in OpenGrok shows that only vcl uses it. In this case, it's probably a good candidate to move into vcl/inc/nativewidgets.hxx Any file that references this class should then include the new header with the syntax: #include "nativewidgets.hxx"
Has been partially addressed by commit bf86287c5f439c48: http://cgit.freedesktop.org/libreoffice/core/commit/?id=bf86287c5f439c4873e8e7d191449ef40dee5795 author: Noel Grandin <noel@peralex.com> 2016-01-29 13:06:16 (GMT) committer: Caolán McNamara <caolanm@redhat.com> 2016-01-31 17:26:49 (GMT) move boost header dependency for ControlCacheHashFunction inside vcl ControlCacheHashFunction is only used by vcl/opengl/*
JanI is default CC for Easy Hacks (Add Jan; remove LibreOffice Dev List from CC) [NinjaEdit]
abdulwd committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=e61fe745d12055ee3915a957714772eeb46fdcd3 tdf#97228 Move include file include/vcl/BitmapProcessor.hxx to vcl/inc/ It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Huzaifa Iftikhar committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=da7b10018433946dd0e0125ec5316dbe8c8b683c tdf#97228 Moved class ControlCacheKey in a seperate include file. It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Shubham Verma committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=63a342ec65f702bfe27de0f0343f75198e6103dc tdf#97228 Moved struct FltCallDialogParameter It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
VaibhavMalik4187 committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ed007423eb4b6d1560d81317b20f291d81bced28 tdf#97228 Move ToolbarValue class to separate include file It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
anfanite396 committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/35845a056e332c1d78d536b613aeb3183af09a91 tdf#97228 Move MenubarValue class to separate include file It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.