Since: http://cgit.freedesktop.org/libreoffice/core/commit/?id=af8143bc40cf2cfbc12e77c9bb7de01b655f7b30 one can write code that looks a lot more native and less cumbersome in Python/PyUNO. Quite a few of our Python unittests where translated from old Java tests and still contain boilerplate that is superficial in Python. This EasyHack is to look at the existing Python tests and make them more readable by using the added pythonic features. code pointer: http://cgit.freedesktop.org/libreoffice/core/commit/?id=af8143bc40cf2cfbc12e77c9bb7de01b655f7b30 <module>/qa/python/<foo>.py https://wiki.documentfoundation.org/Development/Python_Unit_Tests
Hey, I would like to work on this issue. Can you tell me what to do?
(In reply to Dhruv Khattar from comment #1) > Hey, I would like to work on this issue. > Can you tell me what to do? May I suggest you only work on one bug, and please read the comments. Comment 1 describes very well what needs to be done.
I would like to a work on this, if no one else is working. I am new to the community.
This is one of the generic task, where multiple people work in parallel. We have made a step by step guide to help you get started: https://wiki.documentfoundation.org/Development/GetInvolved/DeveloperStepByStep LibreOffice is a very big program and getting it built, setting up gerrit, and getting the first patch right can be a bit challenging, therefore do not hesitate to email me if you want help. However the unittest are very easy to manage if you follow the step-by-step guide.
Matthew Francis gave a great talk in Aarhus on what is possible with the new PyUNO stuff. Watch it here: https://www.youtube.com/watch?v=jS1nnSqGbZM
This is a generic bug, where multiple people can work on each their unittest, therefore you should not assign it to yourself. have a look at https://wiki.documentfoundation.org/Development/GetInvolved Looking forward to see your patches.
JanI is default CC for Easy Hacks (Add Jan; remove LibreOffice Dev List from CC) [NinjaEdit]
slideon committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=c19219d5f49b305d31ad251bc87a87b0109c2402 tdf#97361 Refactor load_save_test It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
slideon committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=9338e4f5b1ffcba2d5b0bd8960dd8795d8909ff1 tdf#97361 Refactor dbaccess test again It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
slideon committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=d513cd3bf635af857624b8c8e693f82f3073e0b4 tdf#97361 Fix check_table and remove = None assignments It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Not my scope
I would like to work on it. I can see some patches were already developed for that one. Is there still some work to be done? It's my first bug in libreoffice, I'm going to need some guidance probably. Is that good choice? Any suggestions?
kerem committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=48120d6ce597472933fa7a8a292ce8d0f1fbe1f9 tdf#97361 remove = None assignments in check_fields It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
kerem committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=25cc8979c5e6238bb76c9d751f3fa3433f48542c tdf#97361 remove = None assignments in sfx2 python unit tests It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
n5xgdh committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=9d67a5872ef7e4b38eb8158046e149a59d6af4f3 tdf#97361: Changed naming convention to Python type, object factories implemented It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
kerem committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=2fa2e149e4829eb653da7972970e1e3e5ba9983d tdf#97361 Fixed check_flies.py It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
kerem committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=7724c6136a5d2e7666b4e801fc6f5df83e18a961 tdf#97361 Fixed check_cross_references.py It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
kerem committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=027a41959cc722fb9e3e7e2375eac9a3703d4799 tdf#97361: Changed naming in sfx2 python tests It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
kerem committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=9cfb2f2f03b5ec086487fd483298466db0b09010 tdf#97361: Changed naming in var_fields and load_save_test It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Justn Lavoie committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=6cea397a95dab91ebf37f25e443393c22da065f7 tdf#97361 Use join() for string concatenation It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
kerem committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=c2e69df36464437d70c4396a4bc5932e6a97a0ff tdf#97361: Changed method calls in check_flies It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
kerem committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=ceab0bab9275394e8ac20e32a1d7828b4eb1f6ac tdf#97361: Changed naming in check_fields and check_table It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
kerem committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=564bbaba573b565dfd7180ef20054ebf0297fe9b tdf#97361: Changed method calls in check_indexed_property_values It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
kerem committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=9f18ee7fd912a6ba600985c5fcbe1e8672dfa993 tdf#97361: Changed method calls in sfx2 python tests It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
A polite ping, still working on this bug?
I am sorry I couldn't find time to solve this bug but but I can't leave the assignment.How can I leave bug assignment?
Saurav Chirania committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=ada02c556531e9e5f28a159223fc7e2b36a7a84d tdf#97361 Tests in sw should be more pythonic It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Saurav Chirania committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=4469c1d4061e8cb463469e60e5d87af5f9bf9636 tdf#97361 Tests in sw should be more pythonic It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Saurav Chirania committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=8e1bb35eeb332d7cb8e4aafb47b57a0ffd7de044 Revert "tdf#97361 Tests in sw should be more pythonic" It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Just a quick comment to let anyone interested know that I'm about to start work on this. I'm new here, so I might need some help, but the documentation seems good, so I reckon I'll be alright.
Note, I found a unit test I was going to work on - /sw/qa/python/load_save_test.py. However, I found that there is no entry for it in PythonTest_sw_python.mk and that it doesn't work (results in a segfault) when added. I'll move on to other files now, but I though this should be noted.
Hamish McIntyre-Bhatty committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/6bfef5f9fdb0977af10ad32db712968825e31f34%5E%21 tdf#97361 Make var_fields more pythonic. It will be available in 6.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Hamish McIntyre-Bhatty committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/f3b743a453002c78eacd0482c26017b75964c989%5E%21 tdf#97361 Make check_table.py more pythonic It will be available in 6.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Hamish McIntyre-Bhatty committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/6e9b4cf30d9ab8d77d14813ab35f32fb63d3f7e8%5E%21 tdf#97361 Make check_bookmarks.py more pythonic It will be available in 6.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Note for xtext.py: I was just working on xtext.py as part of this bug, and I just found a note, showing that removing annotations that have already been removed doesn't result in an exception. According to the unit test, it should. Should I report this as a separate issue? I don't really know what the annotations are for, or what they do, but with a bit of guidance I am happy to try to fix this issue. Hamish
Hamish McIntyre-Bhatty committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/b0b23543449a3666df6e48c561672432af9d6948%5E%21 tdf#97361 Make xtextcontent.py more pythonic It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Hamish McIntyre-Bhatty committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/19b5607329d3b9c12aa743b5480e9dec1b74ceea%5E%21 tdf#97361 Make xtext.py more pythonic It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
test
test comment
Hamish McIntyre-Bhatty committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/f4a1dfe2ea2750467f2cc8cc50a14c656beda6ec%5E%21 tdf#97361 make xscriptprovider.py more pythonic It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Hi! I have fixed some `x.getCount()` function to `len(x)` in unittest for Pyuno, calc and writer. I have tested them too. However, I cannot find a syntax to run the test in `sd/qa/uitest/impress_tests/' folder. Hence, I am not able to change the python test files. Please suggest ways to run the test file in the folder.
(In reply to Mayank Suman from comment #42) > Hi! I have fixed some `x.getCount()` function to `len(x)` in unittest for > Pyuno, calc and writer. I have tested them too. > > However, I cannot find a syntax to run the test in > `sd/qa/uitest/impress_tests/' folder. Hence, I am not able to change the > python test files. Please suggest ways to run the test file in the folder. I believe 'make sd.uicheck' should do it
When index is out of bound pyhton emits `IndexError` however the line 66 in `sw/qa/python/check_styles.py` expect `IndexOutOfBoundsException`. Hence, `x.getByIndex(n)` not entirely same as x[n]. Where I can find the source code for `getByIndex` method so that it can be fixed.
(In reply to Xisco Faulí from comment #43) > (In reply to Mayank Suman from comment #42) > > Hi! I have fixed some `x.getCount()` function to `len(x)` in unittest for > > Pyuno, calc and writer. I have tested them too. > > > > However, I cannot find a syntax to run the test in > > `sd/qa/uitest/impress_tests/' folder. Hence, I am not able to change the > > python test files. Please suggest ways to run the test file in the folder. > > I believe 'make sd.uicheck' should do it Thanks! That worked.
Mayank Suman committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d5dc19402e2b390aedd92ed94d0cd2444fd4478f tdf#97361: Removed getByIndex in calc and writer It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Mayank Suman committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/574cfcacc5489f8995d697126dd463e3df25a4d6 tdf#97361: Removed getByTindex in Pyuno pytests It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
The PythonTest_sc_python.mk does list CalcRTL.py. But running "make PythonTest_sc_python.mk" shows: No rule to make target 'PythonTest_sc_python.mk' It there any way to run this test manually.
(In reply to gs_1001 from comment #48) > The PythonTest_sc_python.mk does list CalcRTL.py. > But running "make PythonTest_sc_python.mk" shows: No rule to make target > 'PythonTest_sc_python.mk' > > It there any way to run this test manually. use 'make PythonTest_sc_python' without the '.mk' at the end
Hannah Meeks committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/182833b893ae4ad7430479f2dfebcc9c130cf27c tdf#97361 - make unit tests more pythonic. It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
hi, I made 1 python file more pythonic. LMK what you think, I can do this for all files if you want.
(In reply to LukasM from comment #51) > hi, > > I made 1 python file more pythonic. > LMK what you think, I can do this for all files if you want. https://gerrit.libreoffice.org/c/core/+/133223/1
(In reply to LukasM from comment #52) > (In reply to LukasM from comment #51) > > hi, > > > > I made 1 python file more pythonic. > > LMK what you think, I can do this for all files if you want. > > https://gerrit.libreoffice.org/c/core/+/133223/1 That's not a unit test, though.
Chenxiong Qi committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/14cff82b314709db488d929b75c254fbb0355419 tdf#97361 replace getCellRangeByPosition with slices It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Chenxiong Qi committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9928f139e858768047b8dea0405720395beb18cd tdf#97361 replace getCellByPosition with access by subscript It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Chenxiong Qi committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/74de0ebb810f3e13c45f01c63067cb8de794ce3c tdf#97361 Make unittests more pythonic: XIndexAccess It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.