Bug 97640 - Beanshell Editor: Use fixed-width font
Summary: Beanshell Editor: Use fixed-width font
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium enhancement
Assignee: Chirag
URL:
Whiteboard: ToBeReviewed target:5.2.0
Keywords: difficultyBeginner, easyHack, skillJava
Depends on:
Blocks: Beanshell-Editor
  Show dependency tree / graph
 
Reported: 2016-02-08 11:51 UTC by Samuel Mehrbrodt (allotropia)
Modified: 2016-10-25 19:09 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Samuel Mehrbrodt (allotropia) 2016-02-08 11:51:38 UTC 
A fixed font should be used for the Beanshell editor.
Comment 1 Samuel Mehrbrodt (allotropia) 2016-02-08 12:47:49 UTC 
EasyHack:
The source is in scripting/java/com/sun/star/script/framework/provider/beanshell
Comment 2 Chirag 2016-02-12 14:17:18 UTC 
(In reply to Samuel Mehrbrodt (CIB) from comment #1)
> EasyHack:
> The source is in
> scripting/java/com/sun/star/script/framework/provider/beanshell

Hi, I am new to open source development and I would like to resolve this bug. I would really appreciate if you could give me starting points.
Thanks
Comment 3 Samuel Mehrbrodt (allotropia) 2016-02-12 14:30:01 UTC 
(In reply to Chirag from comment #2)
> Hi, I am new to open source development and I would like to resolve this
> bug. I would really appreciate if you could give me starting points.
> Thanks

Please read the code I mentioned in comment 1 and come back with any specific questions.
Comment 4 Samuel Mehrbrodt (allotropia) 2016-02-12 14:30:43 UTC 
And add yourself to cc on bugs where you ask for something...
Comment 5 Chirag 2016-02-14 06:03:27 UTC 
(In reply to Samuel Mehrbrodt (CIB) from comment #3)
> (In reply to Chirag from comment #2)
> > Hi, I am new to open source development and I would like to resolve this
> > bug. I would really appreciate if you could give me starting points.
> > Thanks
> 
> Please read the code I mentioned in comment 1 and come back with any
> specific questions.

I examined the code and made some changes in the PlainSourceView.java file, and build the code.
I fixed the font, its style and its size to a default value and then added some code in the initUI. It seems to work. This is what you meant by fixing the font right?
Comment 6 Adolfo Jayme Barrientos 2016-02-15 00:47:32 UTC 
I guess the bug summary could use some clarification…
Comment 7 Samuel Mehrbrodt (allotropia) 2016-02-15 09:17:26 UTC 
I meant a *fixed width* font.
Comment 8 Samuel Mehrbrodt (allotropia) 2016-02-15 09:18:06 UTC 
Chirag, please push your changes to Gerrit and add me as reviewer, will comment there.
Comment 9 Chirag 2016-02-15 13:38:29 UTC 
(In reply to Samuel Mehrbrodt (CIB) from comment #8)
> Chirag, please push your changes to Gerrit and add me as reviewer, will
> comment there.

Samuel, I tried creating a gerrit account but I still cant login. 
"./logerrit test" seems to run but I still cant login through my username or email account.
Could you please help me out with it.
Comment 10 Chirag 2016-02-15 16:06:54 UTC 
I uploaded the fix on gerrit and have added you as the reviewer.
Comment 11 Commit Notification 2016-02-17 07:36:10 UTC 
Chirag Manwani committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=38969497cbccacf2999d92b06a85946c1f71be05

tdf#97640 Fixed-Width Font for Beanshell Editor

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Robinson Tryon (qubit) 2016-02-18 16:34:25 UTC Comment hidden (obsolete)