Bug 97661 - It seems that there are two fill color button when we insert shape
Summary: It seems that there are two fill color button when we insert shape
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Writer-Toolbars
  Show dependency tree / graph
 
Reported: 2016-02-08 20:36 UTC by ackepenek
Modified: 2023-04-02 06:18 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:

Attachments
screenshot for two fill color button (46.16 KB, image/png)
2016-02-08 20:36 UTC, ackepenek 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description ackepenek 2016-02-08 20:36:18 UTC 
Created attachment 122460 [details]
screenshot for two fill color button

Repating steps:
- open the writer
- insert shape (line, rectangle etc.)
- there are two fill color button in the top bar

I think left button is unnecesarry. Because right button is working correctly. If I change color using left button then left button color is changing. But If I change color using right button then right button color is not changing.

This problem is avaliable in the development code
Comment 1 Cor Nouws 2016-02-09 08:51:17 UTC 
Thanks Ahmet for filing.
Indeed odd.
The behaviour of the left control, showing the color last used, is what people like IMO.
Adding Jay here.
Comment 2 Yousuf Philips (jay) (retired) 2016-02-09 14:02:57 UTC 
Yes it (.uno:FillColor) was added at a time when the 'Area Style / Filling' control (.uno:FillStyle) didnt have the new color picker and as a replacement to the 'Area' control (.uno:FormatArea).

The most ideal fix would be to add the image from .uno:FillColor or .uno:FormatArea on the left of .uno:FillStyle (of course when UI is LTR), as without an image next to it, .uno:FillStyle isnt understandable. We do the same thing with the transparency control in the image toolbar (.uno:GrafTransparence).

The alternative easy fix would be to replace .uno:FormatArea with .uno:FillColor.

@Maxim: Would the first option be something easy to do?
Comment 3 Michael Meeks 2016-02-11 10:33:00 UTC 
Who added the easy-hack tags ? this bug doesn't have any code pointers; and doesn't seem to meet the criteria for one (to me). Jan - might be a good idea to watch for well meaning people adding not very well formed easy hacks =) at least to triage the 5x new ones we get per week ? =)
Comment 4 Cor Nouws 2016-02-11 10:40:09 UTC 
(In reply to Michael Meeks from comment #3)
> Who added the easy-hack tags ? this bug doesn't have any code pointers;

I didn't (not this time anyway ;) ) but I appreciate people wanting to drive those opportunities.

You guys know that I (and others prolly too) set needsDevEval as a sign that it might be easyHackable?
Should another key word be used?
Comment 5 ackepenek 2016-02-11 11:15:57 UTC 
I opened this bug and I added easyHack tag to this bug. I am new to contribute to libreoffice.
Comment 6 jani 2016-02-11 11:56:14 UTC 
This is clearly not an easyHack, there are no code pointers.

With my (limited) knowledge, even with code pointers, it does not look like an easyHack.

Ahmet, please let the core developers define easyHacks. We welcome you to work on the bug, and look forward to see a patch.
Comment 7 jani 2016-02-11 11:56:54 UTC 
(In reply to Michael Meeks from comment #3)
> Who added the easy-hack tags ? this bug doesn't have any code pointers; and
> doesn't seem to meet the criteria for one (to me). Jan - might be a good
> idea to watch for well meaning people adding not very well formed easy hacks
> =) at least to triage the 5x new ones we get per week ? =)

I try to, I am just a bit overloaded right now.
Comment 8 QA Administrators 2017-03-06 16:11:54 UTC Comment hidden (obsolete)
Comment 9 Xisco Faulí 2017-07-13 10:59:49 UTC 
Setting Assignee back to default. Please assign it back to yourself if you're
still working on this issue
Comment 10 QA Administrators 2018-07-14 02:46:37 UTC Comment hidden (obsolete)
Comment 11 QA Administrators 2020-07-14 04:04:06 UTC Comment hidden (obsolete)
Comment 12 QA Administrators 2022-07-15 03:45:03 UTC 
Dear ackepenek,

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
 
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug