We have a way to dump our complex attribute storage inside of SfxItemSet (a container for different properties) and the many subclasses of SfxPoolItem. This is currently mainly used by writer but we should add that also for calc. This task involves two parts: 1.) Adding a way to dump the cell properties similar to the dump* calls in ScGridWindow::KeyInput. Instead of these functions place it outside of the DBG_UTIL part to make it available in normal builds (I might move it to dbgutil builds later) The position of the current cell can be gotten through ScGridWindow::pViewData, ScViewData::GetTabNo, ScViewData::GetCurX, ScViewData::GetCurY. The SfxItemSet for dumping through ScDocument::GetPattern and ScPatternAttr::GetItemSet. 2.) Add dumpAsXml methods to the SfxPoolItem subclasses inside of sc/inc/attrib.hxx
JanI is default CC for Easy Hacks (Add Jan; remove LibreOffice Dev List from CC) [NinjaEdit]
Jaskaran committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=98f3b0e091f47fd8eeadd8b8acede2da06fd02b8 tdf#97667 Added a dump method for SfxItemSet in gridwin.cxx It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Only part 1 is implemented.
I am going to attempt to complete part 2. If I understand correctly, I need to implement a dumpAsXML method to every subclass of SfxPoolItem in sc/inc/attrib.hxx And these dumpAsXML methods will call the dump method in SfxItemSet referenced in Comment 2.
Hi there. I have added "virtual void dumpAsXml(xmlTextWriterPtr pWriter) const override;" line to each subclass of SfxPoolItem. Is this enough to submit the patch?
(In reply to Abhishek from comment #5) > Hi there. I have added "virtual void dumpAsXml(xmlTextWriterPtr pWriter) > const override;" line to each subclass of SfxPoolItem. Is this enough to > submit the patch? Submit the patch to gerrit so people can look at it.
Sorry for the delay. I submitted my patch on gerrit. but I am having trouble understanding the build error please help. Thanks!
The patch: https://gerrit.libreoffice.org/c/core/+/88475
I will pick up where @Abhishek left of (implementing part 2)
patch here: https://gerrit.libreoffice.org/c/core/+/113497 I don't know where the unit tests (or regressions) for this kind of things are so I can add them for the methods I added. I don't mind adding them myself to that same patch
Felipe Lema committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/8b1318324e574e510adb0c39fd744de360dd19b3 tdf#97667 Add XML Dump methods for Calc Pool Items It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Can we close this one as FIXED? Markus? Felipe?
I'm ok with closing this. Some feature may be missing, but if that's the case, we can open a separate bug