Bug 97703 - EasyHack: Remove empty setUp/tearDown overrides from CppUnit test code
Summary: EasyHack: Remove empty setUp/tearDown overrides from CppUnit test code
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard: ToBeReviewed target:5.2.0
Keywords: difficultyBeginner, easyHack, skillCpp, topicCleanup
Depends on:
Blocks:
 
Reported: 2016-02-10 08:15 UTC by Stephan Bergmann
Modified: 2017-02-14 08:57 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Bergmann 2016-02-10 08:15:13 UTC
Some of our C++ test code using CppUnit needlessly contains empty overrides of CppUnit::TextFixture::setUp and/or CppUnit::TextFixture::tearDown (e.g., <https://cgit.freedesktop.org/libreoffice/core/tree/sal/qa/rtl/random/rtl_random.cxx?id=0c517ab1bf7f17b9d070f0a79fc2e6d637309d11#n38>).  These can just be removed.
Comment 1 Commit Notification 2016-02-19 06:27:50 UTC
Jaskaran committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=9fe9f487a25a15558b77a8afc359e844922f1e83

tdf#97703 Removed a few redundant calls to setUp and tearDown

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 2 Commit Notification 2016-03-07 09:15:21 UTC
Chirag Manwani committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=cc84aaf70ac56092b32d1d329143eca0550dce12

tdf#97703 removed empty setUp/tearDown methods

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Commit Notification 2016-03-08 16:56:50 UTC
Chirag Manwani committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=b38f58a3f959b5e36813f8c2d88bdb2baf03a1b9

tdf#97703 Removed empty setUp/tearDown methods

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.