Bug 97973 - cleanup spinbuttons theming logic.
Summary: cleanup spinbuttons theming logic.
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: graphics stack (show other bugs)
Version:
(earliest affected)
5.1.1.1 rc
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:5.2.0
Keywords: difficultyBeginner, easyHack, skillCpp, topicCleanup
Depends on:
Blocks:
 
Reported: 2016-02-18 10:57 UTC by Michael Meeks
Modified: 2017-02-14 08:57 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Meeks 2016-02-18 10:57:54 UTC
SpinButtons used to (erroneously) pass in an empty rectangle as their control region. This was fixed in:

commit 469ce3ed324c784a2af1e2fdb0a1f09e28170def
Author: Michael Meeks <michael.meeks@collabora.com>
Date:   Wed Feb 17 20:42:52 2016 +0000

    tdf#97922 - get control area right for spinbuttons.

But there is still a lot of ugliness undoing this lower down the theming stack and around the place =) it would be fantastic to remove that.

Checkout vcl/unx/kde4/KDESalGraphics.cxx which has a special case to build the widgetRect for spin-buttons that can now be cleaned up.

Similarly vcl/unx/gtk/salnativewidgets-gtk.cxx has // CTRL_SPINBUTTONS pass their area in pSpinVal, not in rControlRectangle

That comment is now wrong, and we can dung out that special case too.

Worth also removing the commented out code in salnativewidgets-luna.cxx  // decrease spinbutton rects a little.

Please see bug#97922 for a way to test the spin-buttons in the Change Icon dialog =)

Thanks !
Comment 1 Michael Meeks 2016-03-19 20:38:12 UTC
Thanks to Gurkaran for fixing this one =)
Comment 2 Commit Notification 2016-03-19 20:40:05 UTC
Gurkaran committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=2f7815ab6b3f93f7f9712d403846f1874b8e3a2b

tdf#97973 - cleanup spinbuttons theming logic.

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.