The Beanshell editor currently has a set of buttons below the editor. These should be converted to a toolbar above the editor area. The close button can be omitted, instead undo and redo should be added after Bug 97636 has been solved. The code is in scripting/java/com/sun/star/script/framework/provider/beanshell .
Chirag Manwani committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=1b287f14b2adc79586ae2dde6b08cd8eb960e0ce tdf#98004 Added toolbar to beanshell editor with undo/redo buttons It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Look solved
> The Beanshell editor currently has a set of buttons below the editor. > These should be converted to a toolbar above the editor area. This part is still TODO.
I would like to try this bug (In reply to Samuel Mehrbrodt (CIB) from comment #3) > > The Beanshell editor currently has a set of buttons below the editor. > > These should be converted to a toolbar above the editor area. > > This part is still TODO. I would like to try this part can you explain it a bit more what should be done ?
(In reply to Nadith Malinda from comment #4) > I would like to try this bug > (In reply to Samuel Mehrbrodt (CIB) from comment #3) > > > The Beanshell editor currently has a set of buttons below the editor. > > > These should be converted to a toolbar above the editor area. > > > > This part is still TODO. > > > I would like to try this part can you explain it a bit more what should be > done ? Comment #1 gives you a pointer to the code, and comment #3 describes what is missing. The difficulty level is set to "interesting" for a reason, this is not a beginners bug, it assumes you are a bit familiar with that part of the code. Having said that this bug looks pretty simple: 1) add a new toolbar 2) move the current actions to the toolbar 3) remove the actions from their current place. We have also made a guide to help you get started: https://wiki.documentfoundation.org/Development/GetInvolved have fun jan i.
(In reply to jan iversen from comment #5) > Comment #1 gives you a pointer to the code, and comment #3 describes what is > missing. > > The difficulty level is set to "interesting" for a reason, this is not a > beginners bug, it assumes you are a bit familiar with that part of the code. > Having said that this bug looks pretty simple: > 1) add a new toolbar > 2) move the current actions to the toolbar > 3) remove the actions from their current place. > > We have also made a guide to help you get started: > https://wiki.documentfoundation.org/Development/GetInvolved > > have fun > jan i. I have pull the patch to master on that day after fixing what need to be done I'm waiting for to review it.I got mail it's been verified.and still no review
> > I have pull the patch to master on that day after fixing what need to be > done I'm waiting for to review it.I got mail it's been verified.and still no > review That is kind of hard to know, when you ask for help, and to not write anything about that it is no longer needed. Your patch https://gerrit.libreoffice.org/#/c/27702/ is only 2 days old, and people are in general very busy. Specifically in this case Samuel is on vacation. You have not assigned the task to yourself ?
(In reply to jan iversen from comment #7) > That is kind of hard to know, when you ask for help, and to not write > anything about that it is no longer needed. I looked at that part of the code.I think that I understood what was missing. Then I fixed it.I think it will solve the problem . > Your patch https://gerrit.libreoffice.org/#/c/27702/ is only 2 days old, and > > people are in general very busy. Specifically in this case Samuel is on vacation. Sorry for my impatience . I'm new to LO. I'm counting days until my patch will verify and get merge .that is because I love to see my patch is merge. > > You have not assigned the task to yourself ? thanks for assigned me for the bug .
A polite ping, still working on this bug ?
(In reply to jan iversen from comment #9) > A polite ping, still working on this bug ? Sorry for late.I was Pretty busy with University exams.I finished & submited the patch to gerrit....hope So that it will merge
nadith committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=71901bfedd9f0f6f31be8a9ff54253d56c10b5f3 tdf#98004 - Enhansment on Editor(Beanshell) It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
@jan: you set ux-advise to this but dont know where to find this beanshell editor in order to give some input.
(In reply to Yousuf Philips (jay) from comment #12) > @jan: you set ux-advise to this but dont know where to find this beanshell > editor in order to give some input. To be honest, that makes two of us, I just saw the word editor and thought UI :-) We have a patch pending, but I think I will just try the patch in my debugger.
Seems solved