Bug 98004 - Beanshell Editor: Add a toolbar
Summary: Beanshell Editor: Add a toolbar
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: BASIC (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium enhancement
Assignee: Nadith Malinda
URL:
Whiteboard: target:5.2.0 target:5.3.0
Keywords: difficultyInteresting, easyHack, skillJava, topicUI
Depends on:
Blocks: Beanshell-Editor
  Show dependency treegraph
 
Reported: 2016-02-19 12:11 UTC by Samuel Mehrbrodt (allotropia)
Modified: 2017-02-14 08:57 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Samuel Mehrbrodt (allotropia) 2016-02-19 12:11:30 UTC
The Beanshell editor currently has a set of buttons below the editor.
These should be converted to a toolbar above the editor area.

The close button can be omitted, instead undo and redo should be added after Bug 97636 has been solved.

The code is in scripting/java/com/sun/star/script/framework/provider/beanshell .
Comment 1 Commit Notification 2016-02-22 12:31:31 UTC
Chirag Manwani committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=1b287f14b2adc79586ae2dde6b08cd8eb960e0ce

tdf#98004 Added toolbar to beanshell editor with undo/redo buttons

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 2 jani 2016-06-14 09:43:39 UTC
Look solved
Comment 3 Samuel Mehrbrodt (allotropia) 2016-06-14 09:48:19 UTC
> The Beanshell editor currently has a set of buttons below the editor.
> These should be converted to a toolbar above the editor area.

This part is still TODO.
Comment 4 Nadith Malinda 2016-07-29 14:31:43 UTC
I would like to try this bug 
(In reply to Samuel Mehrbrodt (CIB) from comment #3)
> > The Beanshell editor currently has a set of buttons below the editor.
> > These should be converted to a toolbar above the editor area.
> 
> This part is still TODO.


I would like to try this part can you explain it a bit more what should be done ?
Comment 5 jani 2016-07-30 19:20:15 UTC
(In reply to Nadith Malinda from comment #4)
> I would like to try this bug 
> (In reply to Samuel Mehrbrodt (CIB) from comment #3)
> > > The Beanshell editor currently has a set of buttons below the editor.
> > > These should be converted to a toolbar above the editor area.
> > 
> > This part is still TODO.
> 
> 
> I would like to try this part can you explain it a bit more what should be
> done ?

Comment #1 gives you a pointer to the code, and comment #3 describes what is missing.

The difficulty level is set to "interesting" for a reason, this is not a beginners bug, it assumes you are a bit familiar with that part of the code. Having said that this bug looks pretty simple:
1) add a new toolbar
2) move the current actions to the toolbar
3) remove the actions from their current place.

We have also made a guide to help you get started:
https://wiki.documentfoundation.org/Development/GetInvolved

have fun
jan i.
Comment 6 Nadith Malinda 2016-08-01 05:50:27 UTC
(In reply to jan iversen from comment #5)

> Comment #1 gives you a pointer to the code, and comment #3 describes what is
> missing.
> 
> The difficulty level is set to "interesting" for a reason, this is not a
> beginners bug, it assumes you are a bit familiar with that part of the code.
> Having said that this bug looks pretty simple:
> 1) add a new toolbar
> 2) move the current actions to the toolbar
> 3) remove the actions from their current place.
> 
> We have also made a guide to help you get started:
> https://wiki.documentfoundation.org/Development/GetInvolved
> 
> have fun
> jan i.

I have pull the patch to master on that day after fixing what need to be done I'm waiting for to review it.I got mail it's been verified.and still no review
Comment 7 jani 2016-08-01 06:00:30 UTC
> 
> I have pull the patch to master on that day after fixing what need to be
> done I'm waiting for to review it.I got mail it's been verified.and still no
> review

That is kind of hard to know, when you ask for help, and to not write anything about that it is no longer needed.

Your patch https://gerrit.libreoffice.org/#/c/27702/ is only 2 days old, and people are in general very busy. Specifically in this case Samuel is on vacation.

You have not assigned the task to yourself ?
Comment 8 Nadith Malinda 2016-08-01 06:35:44 UTC
(In reply to jan iversen from comment #7)

> That is kind of hard to know, when you ask for help, and to not write
> anything about that it is no longer needed.

I looked at that part of the code.I think that I understood what was missing. Then
I fixed it.I think it will solve the problem . 


> Your patch https://gerrit.libreoffice.org/#/c/27702/ is only 2 days old, and > > people are in general very busy. Specifically in this case Samuel is on vacation.


Sorry for my impatience . I'm new to LO. I'm counting days until my patch will verify and get merge .that is because I love to see my patch is merge.



> 
> You have not assigned the task to yourself ?

thanks for assigned me for the bug .
Comment 9 jani 2016-09-01 05:42:19 UTC Comment hidden (obsolete)
Comment 10 Nadith Malinda 2016-09-18 09:39:40 UTC
(In reply to jan iversen from comment #9)
> A polite ping, still working on this bug ?

Sorry for late.I was Pretty busy with University exams.I finished & submited the patch to gerrit....hope So that it will merge
Comment 11 Commit Notification 2016-10-16 12:47:48 UTC
nadith committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=71901bfedd9f0f6f31be8a9ff54253d56c10b5f3

tdf#98004 - Enhansment on Editor(Beanshell)

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Yousuf Philips (jay) (retired) 2016-10-16 15:07:06 UTC
@jan: you set ux-advise to this but dont know where to find this beanshell editor in order to give some input.
Comment 13 jani 2016-10-16 15:10:57 UTC
(In reply to Yousuf Philips (jay) from comment #12)
> @jan: you set ux-advise to this but dont know where to find this beanshell
> editor in order to give some input.

To be honest, that makes two of us, I just saw the word editor and thought UI :-)

We have a patch pending, but I think I will just try the patch in my debugger.
Comment 14 jani 2016-10-16 15:46:15 UTC
Seems solved