Created attachment 122995 [details]
Can't edit the "disk with star" icon.
I noticed that the save icon in Writer has changed: it is no longer a single icon that is grayed out when there are no changes to the document, but rather one that adds a star when the document has changed and can be saved.
The problem is that this new behavior breaks Writer's customize icon feature: the user can no longer customize the icon fully, only the "no-changes-yet" state. In order to be consistent, a way to edit the "changes-have-been-made" save icon with a star should be added.
I've changed my icons to be monochrome, but I can find no way to change the new "disk with a star" icon; see attached picture.
Which icon theme do you use?
I just added my own icons (mostly from the Faenza icon set) using Tango as a base via the icon customization option (Tools -> Customize... -> Toolbars -> Modify -> Change Icon). The only way I could change the star icon was to manually switch out /res/savemodified_small.png in images_tango.zip with something else.
In any case, my point was just that having the save icon change to another (instead of just being grayed out when no changes have been made) means that the built-in customize icon function in Writer does not work correctly, since you can only set the one for the "not changed yet" state, and not the "changes have been made" state. Using a non-Tango icon set (like the Human theme) brings up that same icon, but that's a different problem (namely that no one has made a proper Human version of that icon).
> "[…] Using a non-Tango icon set (like the Human
> theme) brings up that same icon, but that's a different problem (namely that
> no one has made a proper Human version of that icon).
That is because Ubuntu will drop the Human theme. See http://pad.lv/1506544
nice to read.
(In reply to Adolfo Jayme from comment #3)
> That is because Ubuntu will drop the Human theme. See http://pad.lv/1506544
Good to hear, I think that theme looks much better. But the problem with the icon customization function remains regardless of the theme.
(In reply to Aibara from comment #2)
> I just added my own icons (mostly from the Faenza icon set) using Tango as a
> base via the icon customization option (Tools -> Customize... -> Toolbars ->
> Modify -> Change Icon). The only way I could change the star icon was to
> manually switch out /res/savemodified_small.png in images_tango.zip with
> something else.
Oh I wasn't even aware that we have a GUI to exchange icons. So this is a problem, sure.
Any idea how to deal with this, Maxim?
(In reply to Samuel Mehrbrodt (CIB) from comment #6)
> Any idea how to deal with this, Maxim?
We can draw the star on top of the original save icon, like we do for color buttons, but I wonder how well it will fit with all icon themes.
(In reply to Maxim Monastirsky from comment #7)
> (In reply to Samuel Mehrbrodt (CIB) from comment #6)
> > Any idea how to deal with this, Maxim?
> We can draw the star on top of the original save icon, like we do for color
> buttons, but I wonder how well it will fit with all icon themes.
Maybe do that only if no savemodified icon found in current icon theme?
(In reply to Samuel Mehrbrodt (CIB) from comment #8)
> Maybe do that only if no savemodified icon found in current icon theme?
How that will solve this particular bug?
(In reply to Maxim Monastirsky from comment #9)
> (In reply to Samuel Mehrbrodt (CIB) from comment #8)
> > Maybe do that only if no savemodified icon found in current icon theme?
> How that will solve this particular bug?
Hm right, we would need to check whether the user has modified the icon and in this case draw the star on it.
** Please read this message in its entirety before responding **
To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.
There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.
If you have time, please do the following:
Test to see if the bug is still present on a currently supported version of LibreOffice
(5.2.7 or 5.3.3 https://www.libreoffice.org/download/
If the bug is present, please leave a comment that includes the version of LibreOffice and
your operating system, and any changes you see in the bug behavior
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave
a short comment that includes your version of LibreOffice and Operating System
Please DO NOT
Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not
appropriate in this case)
If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3)
2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to "inherited from OOo";
4b. If the bug was not present in 3.3 - add "regression" to keyword
Feel free to come ask questions or to say hello in our QA chat: http://webchat.freenode.net/?channels=libreoffice-qa
Thank you for helping us make LibreOffice even better for everyone!
Cannot reproduce the issue, in:
Build ID: 6.1.4-4
CPU threads: 4; OS: Linux 4.20; UI render: default; VCL: gtk3;
Locale: it-IT (en_GB.UTF-8); Calc: group threaded
as the user can select whatever "icon" the user want and this command need two icons (one for change and one for no change) I don't know how to easy solve this issue.
the "only" solution I see is to don't change the icon when the user define an specific icon for this (two) commands.
or set the bug to wfm.
Well spotted issue. My take here, we should accept the little shortcoming. Modifying the icon decoration was done intentionally and is effective. Solution could be to a) draw the decoration programmatically, b) have many icons in one icon file, c) split the button into different objects with different icons and hide contextually, and d) tweak the customization UI. All sounds like a lot of work for not much benefit.
For me also a lot of work for less benefit
We discussed the issue in the design meeting. Possible solutions are:
a) combine two/some icons in one with a proprietary format,
b) split the UNO command into uno:SAVEEMPTY and uno:SAVEMODIFIED,
c1) draw the decoration programmatically,
c2) combine/overlay two icons
None of these are good solutions. And actually it's not common to change single icons so taking the effort of any patch into account it's not worth to do. => WF