Bug 98240 - Adjust size of standard filter dialog within a reasonable range
Summary: Adjust size of standard filter dialog within a reasonable range
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
4.2.8.2 release
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:5.3.0
Keywords: regression
Depends on:
Blocks: 98207
  Show dependency treegraph
 
Reported: 2016-02-27 19:17 UTC by Heiko Tietze
Modified: 2016-10-25 18:39 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Heiko Tietze 2016-02-27 19:17:14 UTC
Access to the "standard filter" (which is rather an overview of the current setup) is possible from the autofilter overlay widget or via menu: data > more filters > standard filter.

Issue: The dialog is badly sized and cannot made smaller (running on LibO fresh on KDE). I suggest to define a sensible minimal and maximal size for this (and every other) dialog.

raal: "WFM, ubuntu Unity. The dialog has minimal size, but can be sized."
Comment 1 Heiko Tietze 2016-02-27 19:18:08 UTC
Issue #2: When the current filter contains of many lengthy items, which can easily happen for text, the value input grows to a length above real screen estate. I suggest to cut the text with ellipsis.
Comment 2 Yousuf Philips (jay) (retired) 2016-02-28 00:53:46 UTC
raal: "3 - Confirm. bug."

This is a regression introduce in 4.2, likely when the dialog was converted over to glade.

The glade UI file is here is at core/sc/uiconfig/scalc/ui/standardfilterdialog.ui

As stretching the dialog downloads doesnt expose more entries, maybe its best to go with a fix width like the pre-4.2 version had.
Comment 3 Commit Notification 2016-07-13 19:12:10 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=595c049afe0aff08ec350100bda5a2528f660a8e

Resolves: tdf#98240 limit width of widgets of standard filter

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Caolán McNamara 2016-07-13 19:14:02 UTC
I think I've addressed the problems listed here. Feel free to open a new bug if I missed something.