Bug 98361 - Selection via keyboard exits Base
Summary: Selection via keyboard exits Base
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Base (show other bugs)
Version:
(earliest affected)
5.2.0.0.alpha0+
Hardware: x86-64 (AMD64) Linux (All)
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, regression
Depends on:
Blocks:
 
Reported: 2016-03-02 20:06 UTC by Terrence Enger
Modified: 2016-03-04 21:14 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Terrence Enger 2016-03-02 20:06:14 UTC
STR
---

(1) Open biblio.odb from the command line; my command in a daily Linux
    dbgutil checkout was ...
        opt/program/soffice --norestore --nologo \
                            opt/presets/database/biblio.odb
    The program presents window "biblio.odb - LibreOfficeDev Base
    5.2..."; <Forms> is highlighted in Database pane.

(2) Type "<up>".  In the Database pane the program hightlights
    <Queries>.

(3) Type "<tab><down><down>".  In the Tasks pane the program
    highlights "Create Query in SQL View...".

(4) Type "<Enter>".
    Expected :  The program should open window "Query1...".
    Observed :  A window appears briefly; from the position and size it
                might be the query window, but it disappears too fast
                for me to be sure.  Then the program closes window
                "biblio.odb..." and displays Start Center.

Other actions are similarly afflicted, but note for comparison that
the same actions invoked by mouse clicks produce the expected
behaviour.

I see this in a local build of master fetched 2016-03-01 and
subsequently hacked, and in recent versions of daily Linux dbgutil
bibisect repository, all running on debian-stretch.  I do not see this
problem with Windows master daily build version 2016-03-01 running on
Windows Vista.

Speaking of the daily Linux dbgutil repository, I see from `git bisect
bad` (whitespace added) ...

    4c8042c3e6e94228cf74f34711e4447356f0f63a is the first bad commit
    commit 4c8042c3e6e94228cf74f34711e4447356f0f63a
    Author: Miklos Vajna <vmiklos@collabora.co.uk>
    Date:   Sat Feb 27 05:35:25 2016 +0100

        2016-02-27: source-hash-af57a81d0c28944b424649f024c28f444a1ab2d9

    :100644 100644 af24f8698d3225b3855ee26c7c7806e246d94918
        91f1e7076f5f87c67353e01b35bb456c110c37d8 M	build-info.txt
    :040000 040000 452fafd8634e317f230e6502c2a8603dc8fa0341
        52d9ef2edcd256b6777b21172b45499213e3b17a M	opt

and from `git bisect log` (whitespace added) ...

    # bad: [0b7a45a0705675545c658b765204d616308c5dd5]
        2016-03-01: source-hash-817f6bd75e98a321c238b5906bfcb031908914b2
    # good: [04b41bd7ffecc8ec64c960b533a833f45b8a4e52]
        2016-02-14: source-hash-e11776e98c5f505c349b5426276e5d983ae14062
    git bisect start '0b7a45a0705675545c658b765204d616308c5dd5'
        '04b41bd7ffecc8ec64c960b533a833f45b8a4e52'
    # good: [3e543dd7bb61aafa92452b5a8ecccdcd538c2deb]
        2016-02-22: source-hash-8bcc538953ceec4ef266f16cf72329bc6080d08c
    git bisect good 3e543dd7bb61aafa92452b5a8ecccdcd538c2deb
    # good: [a441153e2d2e0e5cb60e6c77ceab73edfded5a64]
        2016-02-26: source-hash-49f81b3f33e1b043a1615855503768d78db5f093
    git bisect good a441153e2d2e0e5cb60e6c77ceab73edfded5a64
    # bad: [0e5760214586a3ffc977984d5dad5a04a617e3e0]
        2016-02-28: source-hash-5978b78eb2ee016bfda0a572ae1a9c86dc639241
    git bisect bad 0e5760214586a3ffc977984d5dad5a04a617e3e0
    # bad: [4c8042c3e6e94228cf74f34711e4447356f0f63a]
        2016-02-27: source-hash-af57a81d0c28944b424649f024c28f444a1ab2d9
    git bisect bad 4c8042c3e6e94228cf74f34711e4447356f0f63a
    # first bad commit: [4c8042c3e6e94228cf74f34711e4447356f0f63a]
        2016-02-27: source-hash-af57a81d0c28944b424649f024c28f444a1ab2d9

In the git log of that range, the only appearance of "keyboard" is
    1724081... Feb 26 21:34:57 2016 +0000
    gtk3+wayland: gnome#762756 hack around keyboard focus
Caolán, could this be causing my problem?
Comment 1 Terrence Enger 2016-03-02 20:12:52 UTC
I am setting priority minor because the workaround, to use the mouse,
is so obvious, and most people work that way anyway.

Adding Caolán to cc, and setting keywords regression, bibisected.
Comment 2 Caolán McNamara 2016-03-03 11:21:33 UTC
This sounds very like https://cgit.freedesktop.org/libreoffice/core/commit/?id=3a4b68260bc6c1e8bcb694f640c70652b830c621 which can also be reproduced by just launching writer and pressing return. Keyboard focus stuck in the "close button" in the menubar
Comment 3 Terrence Enger 2016-03-04 21:14:38 UTC
Setting VERIFIED FIXED.

The patch also fixes the case of a fast-closing pane invoked by a mouse click.  Thank you, Caolán.