Bug 98637 - GtkSalMenu: Customization doesn't work
Summary: GtkSalMenu: Customization doesn't work
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: graphics stack (show other bugs)
Version:
(earliest affected)
5.2.0.0.alpha0+
Hardware: All Linux (All)
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:5.2.0
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-13 20:48 UTC by Maxim Monastirsky
Modified: 2016-10-25 19:02 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maxim Monastirsky 2016-03-13 20:48:29 UTC
1. Make sure you're using GtkSalMenu.
2. Customize main menu, e.g. in File move "Open..." above "New".
3. The menu still looks like before, but clicking "Open..." will execute the "New" command.
Comment 1 Caolán McNamara 2016-03-15 20:49:14 UTC
This is proving tricky. It might be easier if the actiongroup and menumodel were available right at the start of this ball of mud. So I'll see if https://gerrit.libreoffice.org/23287 will build on all platforms and that might allow an easier approach.
Comment 2 Commit Notification 2016-03-16 09:29:58 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=86f504ee014d17172267f14742b8edd5789cbbc6

Related: tdf#98637 make this a tractable problem

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Caolán McNamara 2016-05-06 15:08:32 UTC
https://cgit.freedesktop.org/libreoffice/core/commit/?id=d20e08a3ab819ac24f7ea49a98b4dd3683120857 seems to fix this the way I wanted