Bug 98842 - macOS: Cmd+Q in "Save changes?" dialog closes app and loses data
Summary: macOS: Cmd+Q in "Save changes?" dialog closes app and loses data
Status: RESOLVED DUPLICATE of bug 126638
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All macOS (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: dataLoss, haveBacktrace
: 133088 (view as bug list)
Depends on: 31915
Blocks: macOS-UI-polish
  Show dependency treegraph
 
Reported: 2016-03-23 13:45 UTC by Mike Saunders
Modified: 2024-02-20 22:00 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
"Save Document?" dialog (79.08 KB, image/png)
2016-03-23 13:45 UTC, Mike Saunders
Details
Backtrace from lldb (38.38 KB, text/plain)
2017-05-22 15:04 UTC, Alex Thurgood
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Saunders 2016-03-23 13:45:12 UTC
Created attachment 123793 [details]
"Save Document?" dialog

On Mac OS X:

1. Open LibreOffice Writer
2. Enter some text
3. Press Cmd+Q to quit
4. "Save Document?" dialog appears (screenshot attached)
5. Press Cmd+Q again (or go to LibreOffice > Quit in the menu)
6. LibreOffice closes instantly
7. On next start, the Document Recovery dialog appears, although it doesn't recover the text entered before


What should happen:

In Apple's own apps, it is not possible to use Cmd+Q in "save changes?" dialog boxes, nor close the app via the menu. You have to choose one of the buttons.

This is an unlikely data-loss scenario, but it would be good for consistency if app quitting was disabled when the "Save Document?" dialog pops up.
Comment 1 Adolfo Jayme Barrientos 2016-03-24 18:44:44 UTC
Uh-uh, that should not happen to modal dialogs. This one should be presented as a sheet (bug 81908) anyway, which could be a way to solve this issue.
Comment 2 QA Administrators 2017-05-22 13:20:17 UTC Comment hidden (noise)
Comment 3 Mike Saunders 2017-05-22 13:29:20 UTC
Confirming that this is still an issue in LibreOffice 5.3.3 on macOS.
Comment 4 Alex Thurgood 2017-05-22 14:58:58 UTC
Confirming with

Version: 5.3.2.2
Build ID: 6cd4f1ef626f15116896b1d8e1398b56da0d0ee1
Threads CPU : 8; Version de l'OS :Mac OS X 10.12.4; UI Render : par défaut; Moteur de mise en page : nouveau; 
Locale : fr-FR (fr_FR.UTF-8); Calc: group
Comment 5 Alex Thurgood 2017-05-22 15:04:52 UTC
Created attachment 133451 [details]
Backtrace from lldb
Comment 6 QA Administrators 2018-05-23 02:37:10 UTC Comment hidden (noise)
Comment 7 Mike Saunders 2018-05-23 08:37:15 UTC
Still an issue (albeit not very important) in:

Version: 6.0.4.2
Build ID: 9b0d9b32d5dcda91d2f1a96dc04c645c450872bf
CPU threads: 4; OS: Mac OS X 10.13.4; UI render: GL; 
Locale: en-GB (en_GB.UTF-8); Calc: group
Comment 8 Christopher Alexander Chavez 2018-09-19 05:41:49 UTC
Could this be related to bug 31915?
Comment 9 Phil Krylov 2019-04-05 21:55:48 UTC
Reproduced in 6.2.0.3, as well as in 6.3.0.0.alpha0+ Build ID: cc9a8c13dad6f3d82a2386554bd6113b486a1752
Comment 10 eisa01 2020-05-16 15:34:02 UTC
*** Bug 133088 has been marked as a duplicate of this bug. ***
Comment 11 eisa01 2020-05-16 15:36:51 UTC
This is in fact inherited from LO 3.3

Pretty confident this is an issue of not having native modal dialogs
Comment 12 QA Administrators 2022-05-22 03:43:21 UTC Comment hidden (noise, obsolete)
Comment 13 eisa01 2024-02-20 20:08:16 UTC
Patrick, I think you fixed this bug while fixing bug 126638?
Comment 14 Patrick Luby (volunteer) 2024-02-20 22:00:02 UTC
(In reply to eisa01 from comment #13)
> Patrick, I think you fixed this bug while fixing bug 126638?

Correct. I ran into this bug while debugging tdf#126638. With the fix for tdf#126638, the Quit menu item (either when pressing Command-Q or clicking on the menu item) will now be ignored when there is a modal window displayed.

*** This bug has been marked as a duplicate of bug 126638 ***