In gdiimpl.cxx in Win implementation of graphic sal stuff, a Gdiplus::GpSolidFill is constructed but not freed. WinSalGraphicsImpl::drawPolyPolygon needs to be adapted
Of course only on Windows. Problem could be solved by freeing the Gdiplus::GpSolidFill using GpStatus WINGDIPAPI GdipDeleteBrush(GpBrush *brush) (see https://msdn.microsoft.com/en-us/library/windows/desktop/ms533974%28v=vs.85%29.aspx). But basic problem is usage of the procedural calls per se. To make sure that does not happen on other places, replace that calls (starting with Gdiplus::DllExports::Gdip*) using the Object-Oriented approach
Change done, tested if it works. Submitted to gerrit.
Armin Le Grand committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=84f7867de70fb91e7e3bd8acc8175b4be4be31dd tdf#98859 use ObjectOriented approach for Gdiplus It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Hi, Is this bug fixed? If so, could you please close it as RESOLVED FIXED? Regards
I was told that as a developer I should not do exactly that - it will be tested for being fixed and closed by QA. Explanation was that QA wants to explicitely check if the task is solved from QA-Perspective (sometimes different from dev one, thus a good thing from my POV). Did that change..?
(In reply to Armin Le Grand (CIB) from comment #5) > I was told that as a developer I should not do exactly that - it will be > tested for being fixed and closed by QA. Explanation was that QA wants to > explicitely check if the task is solved from QA-Perspective (sometimes > different from dev one, thus a good thing from my POV). Did that change..? Normally, when a bug is fixed, it should be set to RESOLVED FIXED by the developer when he/she believes it's fixed. Later on, QA should verify it and change it to VERIFIED FIXED. This is the normal case for most of the bugs we have in BZ and I believe you should follow this rule as well.