Created attachment 124094 [details] The default minimum angle for miter is 15°. Set your LibreOffice to not use OpenGL. 1. Switch Antialiasing off. Open the attached file. Look at it in edit mode and in presentation mode. 2. Switch Antialiasing on. Again look at the file in edit mode and in presentation mode. Expected behavior: The shapes look the same in edit mode and presentation mode. Seen behavior: A miter limit is used in presentation mode and in edit mode without antialiasing. No miter limit is used in edit mode, if antialiasing is on. I see the problem since Version: 4.2.5.2 Build ID: 6ff819b65674ae6c83f3cbab9e4a4c2b292a7a94 My PC cannot use OpenGL, but I would like to know the test result for the case OpenGL too. Please add your findings, if you can use OpenGL.
Created attachment 124095 [details] screenshot of edit mode, anti-aliasing off
Created attachment 124096 [details] screen of edit mode, anti-aliasing on
Created attachment 124097 [details] screenshot of presentation mode
It seems, that the problem is, that anti-aliased line rendering uses directly gdi+ without own decomposition. (Windows 7 here). And gdi+ handles miter limit different from LibreOffice. And without anti-aliasing the own decomposition is used, which switches from line join 'miter' to 'bevel', if the angle is too small. In addition, there is a real bug in bool WinSalGraphicsImpl::drawPolyLine (line#2018). const Gdiplus::REAL aMiterLimit(15.0); aPen.SetMiterLimit(aMiterLimit); uses the default 15° MiterMinimum_Angle_, but gdi+ expects a MiterLimit, which is the ratio of MiterLength to stroke-width. Correcting that error, I get nearly the same cuts of the tips as rendered in PowerPoint.
OpenGL rendering of polylines currently doesn't support miter limit (it doesn't fallback to bevel at a certain angle) which is bad. When I'll implement this then I'll make sure the document is rendered correctly.
One error is in case basegfx::B2DLineJoin::Miter in WinSalGraphicsImpl::drawPolyLine, in /core/vcl/win/gdi/gdiimpl.cxx Currently it is case basegfx::B2DLineJoin::Miter : { const Gdiplus::REAL aMiterLimit(15.0); aPen.SetMiterLimit(aMiterLimit); aPen.SetLineJoin(Gdiplus::LineJoinMiter); break; } But the type "Gdiplus::LineJoinMiter" acts different than LO. The correct type is "Gdiplus::LineJoinMiterClipped" see https://msdn.microsoft.com/en-us/library/windows/desktop/ms534148%28v=vs.85%29.aspx Therefore it should be in content case basegfx::B2DLineJoin::Miter : { const Gdiplus::REAL aMiterLimit(1/sin(7.5*F_PI180)); aPen.SetMiterLimit(aMiterLimit); aPen.SetLineJoin(Gdiplus::LineJoinMiterClipped); break; } There exist the general formula miter length = 1 / sin (phi/2 ) where phi is the angle between the lines. As Gdi+ expects a miter limit and LO uses a minimum angle, you have to convert it. Currently LO has only default 15° as minimum angle. Making the angle variable is work in progress.
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present on a currently supported version of LibreOffice (5.2.7 or 5.3.3 https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the version of LibreOffice and your operating system, and any changes you see in the bug behavior If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a short comment that includes your version of LibreOffice and Operating System Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to "inherited from OOo"; 4b. If the bug was not present in 3.3 - add "regression" to keyword Feel free to come ask questions or to say hello in our QA chat: http://webchat.freenode.net/?channels=libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug-20170522
Didn't we fix this already?
In edit mode it is correct now in both cases, anti-aliasing on or off. But in presentation mode the switch to bevel does not happen at all, all four examples in the attached file have a sharp long corner. Anti-aliasing on/off setting has no effects on presentation mode. In presentation mode view is always anti-aliased. Tested with Version: 5.4.0.0.alpha1+ Build ID: 965494c544dd8f35ae83b7cf38549009da06c367 CPU threads: 4; OS: Windows 6.1; UI render: default; TinderBox: Win-x86@62-TDF, Branch:MASTER, Time: 2017-05-10_23:06:27 Locale: de-DE (de_DE); Calc: group
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
The error still exists in Version: 6.0.4.2 (x64) Build ID: 9b0d9b32d5dcda91d2f1a96dc04c645c450872bf CPU threads: 8; OS: Windows 10.0; UI render: default; Locale: de-DE (de_DE); Calc: CL and Version: 6.1.0.0.alpha1+ (x64) Build ID: 88051c660fc6759346a01bc559818d3e23f8f55c CPU threads: 8; OS: Windows 10.0; UI render: default; Locale: de-DE (de_DE); Calc: CL
Dear Regina Henschel, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
The linejoin miter is still wrongly rendered in presentation mode. Tested with Version: 6.3.0.0.alpha1+ (x64) Build ID: 115ab48f86d4e3c6eede49767df1ee5a82b4ab22 CPU threads: 8; OS: Windows 10.0; UI render: default; VCL: win; TinderBox: Win-x86_64@62-TDF, Branch:master, Time: 2019-05-20_17:50:30 Locale: en-US (en_US); UI-Language: en-US Calc: threaded
Dear Regina Henschel, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
The problem still exists in Version: 7.2.0.0.alpha1+ (x64) / LibreOffice Community Build ID: 60cba23bc0f5e8eafecc03c437f1133b62569fa6 CPU threads: 8; OS: Windows 10.0 Build 19041; UI render: default; VCL: win Locale: de-DE (en_US); UI: en-US Calc: CL If Skia is enabled, rendering is OK, same in edit as in presentation mode. If Skia is disable, rendering in presentation mode is wrong, now independent from setting for antialiasing.