Bug 99188 - Calc outer border lines do not close nicely when connected
Summary: Calc outer border lines do not close nicely when connected
Status: RESOLVED DUPLICATE of bug 81643
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
5.0.5.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, regression
Depends on:
Blocks:
 
Reported: 2016-04-09 20:35 UTC by Roeland
Modified: 2016-09-06 19:36 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
How the corners of my formatted cells look like (2.04 KB, image/png)
2016-04-09 20:35 UTC, Roeland
Details
The "format cells" options used (35.13 KB, image/png)
2016-04-09 20:35 UTC, Roeland
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Roeland 2016-04-09 20:35:08 UTC
Created attachment 124208 [details]
How the corners of my formatted cells look like

If, in calc, I want to create a cadre around some cells, there's an easy way to do this via "format cells". The wizard shows a clean box around the cells, but the outcome is different: the corners of my framework are not seamlessly connected. i attached some screenshots to illustrate this.

Steps to reproduce:
1. open Calc 
2. select some cells and right click
3. click "Format cells"
4. click "borders" and select "set outer border line only"
5. select thicknes 4 pt and click "ok"
6. expected result: perfect black rectangle around cells, achieved result: corners of the black borders do not close cleanly
 
I chose 6pt thickness to better illustrate the problem, but this occurs with lesser thickness as well.

This problem was tested on 5.1.1 and 5.1.2 on Windows 7
Comment 1 Roeland 2016-04-09 20:35:47 UTC
Created attachment 124209 [details]
The "format cells" options used
Comment 2 Cor Nouws 2016-04-09 21:29:28 UTC
Hi Roeland,

Thanks for filing. I confirm the problem in 5.0.5.2 and later.
LibreOffice 3.4.4 - 4.0.6 don't have the issue > Regression

I would have thought the issue is already known, but I can't find a bug, so I set to new.
Comment 3 raal 2016-04-10 07:02:22 UTC

during bibisect are builds which doesn't show borders at all, I marked them "bad"
 bf3ec9b92ce269faa4009bd358ce393a4f754bad is the first bad commit
commit bf3ec9b92ce269faa4009bd358ce393a4f754bad
Author: Matthew Francis <mjay.francis@gmail.com>
Date:   Thu May 28 17:55:18 2015 +0800

    source-hash-dd902b8e256867b5d5fed06b52995f14d969f67d
    
    commit dd902b8e256867b5d5fed06b52995f14d969f67d
    Author:     Eike Rathke <erack@redhat.com>
    AuthorDate: Tue Dec 17 16:59:08 2013 +0100
    Commit:     Eike Rathke <erack@redhat.com>
    CommitDate: Fri Dec 20 03:26:53 2013 +0100
    
        reordered member variables for 4 byte alignment
    
        Change-Id: Iaae7689d1ed3c74e261fcc90fa88b5521468e376

during bibisect are builds which doesn't show borders at all, I marked them "good" a3ada5c2e0f610e97f9494118f3823de2abb6a31 is the first bad commit
commit a3ada5c2e0f610e97f9494118f3823de2abb6a31
Author: Matthew Francis <mjay.francis@gmail.com>
Date:   Thu May 28 18:29:06 2015 +0800

    source-hash-111fe03e36dd7e819e8fa9bdf38a16f5284b6063
    
    Bibisect: This commit covers the following source commit(s) which failed to build
    f979a12741d0e5f47b26aa407593ab7c21979f6d
    6a3fb868b2b8af21f7b6140424b6f8377599a786
    ec1a3157c1851dcb481f402ec25aa38fa9e7c51c
    82599357ae6066b002ca2bd2b7060b26e51ba00f
    b3b57c7a3a43a056217c72716d18bdeced029b66
    ae22838d2ff4d388e97c30317a6a9f83e652a06a
    30f97564f86ff2fff3e682a14191db0d841df0cf
    41bee5b83102760a6da7eaca3b770e4c4e310d4d
    01104522ef890bb535994311e627ba1bbfff023c
    4b2b4133c2bd750a4b71230433dba0e41ced0abe
    
    commit 111fe03e36dd7e819e8fa9bdf38a16f5284b6063
    Author:     Jan Holesovsky <kendy@collabora.com>
    AuthorDate: Mon Jan 20 19:57:26 2014 +0100
    Commit:     Jan Holesovsky <kendy@collabora.com>
    CommitDate: Mon Jan 20 19:58:06 2014 +0100
    
        Rest of the incomplete conversion.
    
        What I am doing today?! - sorry for the incomplete push.
    
        Change-Id: Idca25b390820527481b1c672a0ad62f2d83a0e13


probably these ones and other  Kohei's commits mentioned >

author	Kohei Yoshida <kohei.yoshida@collabora.com>	2014-01-18 23:17:52 (GMT)
committer	Kohei Yoshida <kohei.yoshida@collabora.com>	2014-01-20 19:37:01 (GMT)
commit 6a3fb868b2b8af21f7b6140424b6f8377599a786 (patch)
tree a6f7e401f6757dd8b5bb2e266c512a2dc5494ccb
parent f979a12741d0e5f47b26aa407593ab7c21979f6d (diff)
Draw horizontal solid border lines directly in the pixel processor.
This makes slightly skinnier solid lines which look better on screen.

author	Kohei Yoshida <kohei.yoshida@collabora.com>	2014-01-19 04:02:05 (GMT)
committer	Kohei Yoshida <kohei.yoshida@collabora.com>	2014-01-20 19:37:02 (GMT)
commit ec1a3157c1851dcb481f402ec25aa38fa9e7c51c (patch)
tree 8f5deeb7c3a636a79106c0de4054d202368c64ac
parent 6a3fb868b2b8af21f7b6140424b6f8377599a786 (diff)
Better pixelization of dashed lines for screen rendering.

author	Kohei Yoshida <kohei.yoshida@collabora.com>	2014-01-20 15:04:26 (GMT)
committer	Kohei Yoshida <kohei.yoshida@collabora.com>	2014-01-20 19:37:02 (GMT)
commit 82599357ae6066b002ca2bd2b7060b26e51ba00f (patch)
tree bcdca1bb1ff5f7cff5bd8bc7c1f67ed626e9cbc2
parent ec1a3157c1851dcb481f402ec25aa38fa9e7c51c (diff)
Add vertical lines for testing.

author	Kohei Yoshida <kohei.yoshida@collabora.com>	2014-01-20 15:12:53 (GMT)
committer	Kohei Yoshida <kohei.yoshida@collabora.com>	2014-01-20 19:37:02 (GMT)
commit b3b57c7a3a43a056217c72716d18bdeced029b66 (patch)
tree 7c44dafab345ffa40eb2281cd37909d75958b7a4
parent 82599357ae6066b002ca2bd2b7060b26e51ba00f (diff)
Same solid line treatment for vertical lines during on-screen drawing.
Comment 4 Roeland 2016-06-27 16:46:46 UTC
I stumbled upon another bug, which I believe is the same bug as this one: Bug 81643.
If this is correct, then the bug report I initiated may be closed as a duplicate.
Comment 5 Roeland 2016-06-27 19:13:12 UTC

*** This bug has been marked as a duplicate of bug 81643 ***