Bug 99211 - Use the restart dialog for notifications about restart
Summary: Use the restart dialog for notifications about restart
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
5.0.1.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:5.2.0
Keywords: difficultyBeginner, easyHack, topicUI
Depends on:
Blocks:
 
Reported: 2016-04-11 07:45 UTC by Jan Holesovsky
Modified: 2017-02-14 08:57 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Holesovsky 2016-04-11 07:45:06 UTC
There are places in the configuration that need a restart when changed.  Some of them use a plain MessageBox, but should use the dedicated 'restart' dialog for that.  To find the places:

git grep RID_SVXSTR_OPTIONS_RESTART

The changes that are necessary would be like:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=cf81f3ba0602eeffad8907a1bb9cdd24e62c2d1e
Comment 1 Jan Holesovsky 2016-04-11 07:46:40 UTC
For the moment, these are the files that have message box and should be changed:

cui/source/options/optinet2.cxx
cui/source/options/optjava.cxx
cui/source/options/optopencl.cxx
Comment 2 Commit Notification 2016-05-03 09:26:39 UTC
irem committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=2fce97c51ceb15c7722ed828b2cc0ea4b21c8c95

tdf#99211 Use the restart dialog for notifications about restart

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Commit Notification 2016-05-23 08:35:19 UTC
irem committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=a4e8419c8a1eb3e56ef973de4b15fdafc91248a2

tdf#99211 Use the restart dialog for notifications about restart

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 jani 2016-06-14 09:52:30 UTC
Seems solved