Bug 99549 - UI: Listbox anchored in a cell is not expanded correct after group, saving, closing, opening and ungrouping
Summary: UI: Listbox anchored in a cell is not expanded correct after group, saving, c...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
5.1.2.2 release
Hardware: All All
: medium minor
Assignee: Regina Henschel
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Group&Outline
  Show dependency treegraph
 
Reported: 2016-04-28 10:00 UTC by riesslibo
Modified: 2020-11-02 14:30 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
calc with a listbox with the problem after reopening (8.79 KB, application/vnd.oasis.opendocument.spreadsheet)
2016-04-28 10:02 UTC, riesslibo
Details
Calc with a listbox without the problem because of the height (8.77 KB, application/vnd.oasis.opendocument.spreadsheet)
2016-04-28 10:02 UTC, riesslibo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description riesslibo 2016-04-28 10:00:55 UTC
Version: 5.1.2.2 x86
Build ID: d3bf12ecb743fc0d20e0be0c58ca359301eb705f
CPU Threads: 8; OS Version: Windows 6.1 x64; UI Render: default; 
Locale: de-DE (de_DE)

A little bit complicate but with the attachement hopefully reproducable.

Problem Statement:
If you have in a Calc sheet a List Box as Form Control, which is anchored in a cell, and this cell is part of a group, which you can colapse and expand with the + and – icons on the left side, the hight of such a list box is not correctly expanded again (the hight is sero, so that it is displayed as a line) after colapsing and saving and reopening and expanding the group. This behaviour occurs reproducable, if the height of the listbox is less then the heigt of the cell (or precise of the row, because every cells of the row does have the height of the row).


Steps to reproduce
There are two files, one with a listbox with a height less than the cell height (TestGruppierungMITProblem) and one without the issue (TestGruppierumgOHNEProblem) because the height is a little bit higher than the cell height.

1. Open the file TestGruppierungMITProblem and see the sheet with grouped rows 6 to 14 but not collapsed and the listbox anchored in cell E11 with a height less than the cell.

2. Collapse the group with hitting on the – icon on the left.

3. Save the file. Close the file.

4. Reopen the file, expand the group with hitting on the +-icon

5. The listbox seems to be gone, but if you look for a line you can see that the listbox
is still collapsed with the height 0 and appaers like a line. If you click on it in the Design mode you can verify and expand the heigt manually.


Expected behaviour
See the file TestGruppierumgOHNEProblem with the same listbox but with a height a little bit bigger than the row height, do the same actions like above, the listbox is correctly collapsed and expanded after the actions saving, closing, reopening, expanding as described above.


Puuh, hopefully it is understandable, if not, give me a question in a comment.
Comment 1 riesslibo 2016-04-28 10:02:03 UTC
Created attachment 124687 [details]
calc with a listbox with the problem after reopening
Comment 2 riesslibo 2016-04-28 10:02:53 UTC
Created attachment 124688 [details]
Calc with a listbox without the problem because of the height
Comment 3 Buovjaga 2016-05-03 13:41:09 UTC
Repro with file.
Has it always behaved like this?

Btw. there are other reports with group collapsing weirdness.

64-bit, KDE Plasma 5
Build ID: 5.1.2.2 Arch Linux build-1
CPU Threads: 8; OS Version: Linux 4.5; UI Render: default; 
Locale: fi-FI (fi_FI.UTF-8)

Arch Linux 64-bit, KDE Plasma 5
Version: 5.2.0.0.alpha1+
Build ID: 540fee2dc7553152914f7f1d8a41921e765087ef
CPU Threads: 8; OS Version: Linux 4.5; UI Render: default; 
Locale: fi-FI (fi_FI.UTF-8)
Built on April 30th 2016
Comment 4 QA Administrators 2017-05-22 13:39:51 UTC Comment hidden (obsolete)
Comment 5 riesslibo 2017-05-30 14:23:15 UTC
Still present and confirmed for 

Version: 5.3.3.2
Build-ID: 3d9a8b4b4e538a85e0782bd6c2d430bafe583448
CPU-Threads: 8; BS-Version: Windows 6.1; UI-Render: Standard; Layout-Engine: neu; 
Gebietsschema: de-DE (de_DE); Calc: single
Comment 6 QA Administrators 2019-05-24 02:57:18 UTC Comment hidden (obsolete)
Comment 7 Regina Henschel 2020-10-26 18:48:47 UTC
The error still exists in Version: 7.1.0.0.alpha0+ (x64)
Build ID: 37081085fa989aa2fd07a7a0d063295819e185a0
CPU threads: 8; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win
Locale: de-DE (en_US); UI: en-US
Calc: threaded

I'm working on a fix, but it will take same time. The solution requires larger changes in the code.
Comment 8 Regina Henschel 2020-10-31 17:00:23 UTC
Should be fixed with https://cgit.freedesktop.org/libreoffice/core/commit/?id=1f0b3c7a40edfa81bbc7a58d123a6a2dfd83e4ca

(The patch covers several bug reports, therefore no automatic notification.)
Comment 9 Buovjaga 2020-11-02 14:30:19 UTC
Verified

Arch Linux 64-bit
Version: 7.1.0.0.alpha1+
Build ID: 2764c334c3b9cf428e4e7ab0c28ce6a34036fa77
CPU threads: 8; OS: Linux 5.9; UI render: default; VCL: kf5
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Built on 2 November 2020