Bug 99567 - Wrong appdata.xml id
Summary: Wrong appdata.xml id
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Dev-related
  Show dependency treegraph
 
Reported: 2016-04-29 09:43 UTC by Stephan Bergmann
Modified: 2023-05-11 12:20 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Bergmann 2016-04-29 09:43:07 UTC
For "*" in "base", "calc", "draw", etc., in each of the sysui/desktop/appstream-appdata/libreoffice-*.appdata.xml files (which are then copied to their target locations via sysui/desktop/share/create_tree.sh), the id element is hardcoded as

  <id>libreoffice-*.desktop</id>

while the .desktop file symlinks that are created via sysui/destop/share/create_tree.sh have pathnames of the form

 .../share/applications/<PREFIX>-*.desktop

where "<PREFIX>" is e.g. "libreoffice5.2" or "libreofficedev5.2" for a current master build (depending on --enable-release-build).

However, given <https://people.freedesktop.org/~hughsient/appdata/#id> and <https://specifications.freedesktop.org/desktop-entry-spec/1.1/ape.html> "E. Desktop File ID", it looks more plausible that .appdata.xml id elements should match the names of the .desktop file, e.g., be of the form

  <id>libreoffice5.2-*.desktop</id>

resp.

  <id>libreofficedev5.2-*.desktop</id>

for a current master build (depening on --enable-release-build).
Comment 1 Buovjaga 2016-05-06 13:28:08 UTC
Yes.
Comment 2 QA Administrators 2017-05-22 13:41:17 UTC Comment hidden (obsolete)
Comment 3 QA Administrators 2019-12-03 15:01:27 UTC Comment hidden (obsolete)
Comment 4 Stephan Bergmann 2019-12-04 14:42:57 UTC
(In reply to QA Administrators from comment #3)
> If the bug is present, please leave a comment that includes the information
> from Help - About LibreOffice.

The issue described in comment 0 is still present in current master towards LO 6.5.  (To verify, build on Linux with e.g. --enable-release-build --with-package-format=rpm, and find the /usr/share/appdata/libreoffice6-5-*.appdata.xml files and /usr/share/applications/libreoffice6.5-*.desktop symlinks in workdir/installation/LibreOffice/rpm/install/LibreOffice_6.5.0.0.alpha0_Linux_x86-64_rpm/RPMS/libreoffice6.5-freedesktop-menus-6.5.0-0.noarch.rpm.)
Comment 5 QA Administrators 2021-12-04 04:44:38 UTC Comment hidden (obsolete)
Comment 6 Stephan Bergmann 2021-12-06 11:27:50 UTC
(In reply to QA Administrators from comment #5)
> If the bug is present, please leave a comment that includes the information
> from Help - About LibreOffice.

The issue described in comment 0 is still present in current master towards LO 7.4.  (To verify, build on Linux with e.g. --enable-release-build --with-package-format=rpm, and find the /usr/share/metainfo/libreoffice7.4-*.appdata.xml files and /usr/share/applications/libreoffice7.4-*.desktop symlinks in workdir/installation/LibreOffice/rpm/install/LibreOffice_7.4.0.0.alpha0_Linux_x86-64_rpm/RPMS/libreoffice7.4-freedesktop-menus-7.4.0-0.noarch.rpm.)