Created attachment 124792 [details] affected file Try to open the attached file and edit one embbedded objects. (For example edit the table on page 8). When click outside the embbedded spreadsheet the table is incorrectly scaled. NOTE: if the embedded file is an XLSX it's incorrectly scaled, while if the file is a XLS it's opened as a new read-only document. (Different bug report to be filled) IDEA: Something related to bug 93635 ------------------------ Works fine on: Version 3.6.7.2 (Build ID: e183d5b) Do not work on: Version: 5.1.2.2.0+ Build ID: 10m0(Build:2) Thread CPU: 4; Versione SO: Linux 4.5; Resa interfaccia: predefinito; Locale: it-IT (it_IT.UTF-8) OS: openSUSE Tumbleweed (20160422) (x86_64) Version: 5.0.5.2 Build ID: 55b006a02d247b5f7215fc6ea0fde844b30035b3 Locale: it-IT (it_IT.UTF-8) OS: openSUSE Tumbleweed (20160422) (x86_64) Version: 4.4.7.2 Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600 Locale: it_IT.UTF-8 OS: openSUSE Tumbleweed (20160422) (x86_64) Version: 4.2.8.2 Build ID: 48d50dbfc06349262c9d50868e5c1f630a573ebd Locale: it_IT.UTF-8 OS: openSUSE Tumbleweed (20160422) (x86_64)
Repro with document. 64-bit, KDE Plasma 5 Build ID: 5.1.2.2 Arch Linux build-1 CPU Threads: 8; OS Version: Linux 4.5; UI Render: default; Locale: fi-FI (fi_FI.UTF-8)
also see bug 99632.
Adjusting earliest version to 4.1.0.4, tried editing 2nd table on page 8 (strangely, nothing happens if I click on 1st table). Interestingly, I can't edit that table in 4.0.0.3 at all.
Regression introduced by author David Tardon <dtardon@redhat.com> 2014-07-16 13:13:36 (GMT) committer David Tardon <dtardon@redhat.com> 2014-07-16 13:32:07 (GMT) commit c10390a681a4d4696d45a6d38f7d01829f368daa (patch) tree b4797585f963f9eaf122d25081ab5d5cb6b2865c parent cc1bea8692ad44dcc795766118b4b75c690e2655 (diff) fdo#81113 always run the actual detection The old code only run detection if an UCBContent property was passed. That means that any time the function got only InputStream, it claimed that it was a Keynote presentation. Change-Id: I377828229e7e95384257bde247612d7768307581 Adding Cc: to David Tardon
Hmm, it sounds weird that this should have any effect on embedded objects at all...
dtardon->xiscofauli: I think you've made a mistake somewhere during bisection... Even when I make KeynoteImportFilter::detect a dummy (to rule out a possible uncaught exception), the 1st table on page 8 still fails to open for editing.
I do confirm that in bibisect-44max, if I do: -git checkout a3504bf4d8f26bd18a1558a1a0fc122a455a1b13 I move to: commit a3504bf4d8f26bd18a1558a1a0fc122a455a1b13 Author: Matthew Francis <mjay.francis@gmail.com> Date: Sat Mar 14 23:23:55 2015 +0800 source-hash-c10390a681a4d4696d45a6d38f7d01829f368daa commit c10390a681a4d4696d45a6d38f7d01829f368daa Author: David Tardon <dtardon@redhat.com> AuthorDate: Wed Jul 16 15:13:36 2014 +0200 Commit: David Tardon <dtardon@redhat.com> CommitDate: Wed Jul 16 15:32:07 2014 +0200 and I see that the embedded file is incorrectly scaled. Then If I do: git checkout HEAD~1 and I move to the previous commit: commit 562c5d3383b40a2a2c022a0a1c8625ca852fd48d Author: Matthew Francis <mjay.francis@gmail.com> Date: Sat Mar 14 23:23:52 2015 +0800 source-hash-cc1bea8692ad44dcc795766118b4b75c690e2655 then the file is opened in a new read-only document
At this point I no longer understand what you're trying to reproduce...
(In reply to David Tardon from comment #8) > At this point I no longer understand what you're trying to reproduce... 1. Open document and go to page 8 2. Double click the lower table for editing and it becomes zoomed in 3. Click outside and it remains zoomed in This does not happen with 3.6.7.2 Arch Linux 64-bit, KDE Plasma 5 Version: 5.3.0.0.alpha0+ Build ID: ff2a399b61f34f7920e594e8cbb6c19045b24956 CPU Threads: 8; OS Version: Linux 4.7; UI Render: default; Locale: fi-FI (fi_FI.UTF-8); Calc: group Built on October 7th 2016 Arch Linux 64-bit Version 3.6.7.2 (Build ID: e183d5b)
I've just bibisected it with lo-linux-dbgutil-daily-till44 to double check it and it says that the regression was introduced in this range: https://cgit.freedesktop.org/libreoffice/core/log/?id=c10390a681a4d4696d45a6d38f7d01829f368daa&qt=range&q=6b00bfeefde972beea947da66e07b59794717e4f..98fb5f98d84474103a04cbad824febecb25407c2
*** Bug 103277 has been marked as a duplicate of this bug. ***
*** Bug 103675 has been marked as a duplicate of this bug. ***
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
CONFIRMED on: Version: 6.0.4.1 Build ID: 00m0(Build:1) CPU threads: 4; OS: Linux 4.16; UI render: default; VCL: gtk3; Locale: it-IT (it_IT.UTF-8); Calc: group
CONFIRMED on: Versione: 6.1.0.0.alpha1 Build ID: cb47f0d320994e001bc38dc2ee9b7d957b15e6ab Thread CPU: 4; SO: Linux 4.16; Resa interfaccia: predefinito; VCL: gtk2; Versione locale: it-IT (it_IT.UTF-8); Calc: group
László Németh committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/75656a933e7a503f114aa64c67397cb375c9dbe8%5E%21 tdf#99631 DOCX import: set 1:1 scale in embedded XLSX It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
László Németh committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/69ce3374f90847f357249a41118314508da6bb98%5E%21 tdf#99631 DOCX import: keep zoom of embedded XLSX It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
László Németh committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/fc50869a818f5411bf2bbd34db398078308f2ba3%5E%21 tdf#99631 DOCX export: keep zoom of embedded XLSX It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Created attachment 147693 [details] How it looks on master compared to LibreOffice 6.1.3.2 The blurred problem in the first table is reported in bug 119180
Setting as VERIFIED FIXED Version: 6.3.0.0.alpha0+ Build ID: 1b7bcaa714f0af45c6a9660d1f0940cb7931ba0f CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded @László Németh, thanks for fixing this!!
László Németh committed a patch related to this issue. It has been pushed to "libreoffice-6-2": https://git.libreoffice.org/core/+/5db1b9e519e1af16d3faf98465b5a901c6bdbb36%5E%21 tdf#99631 DOCX: keep zoom of embedded XLSX It will be available in 6.2.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
@Xisco, Miklós and all: Thanks for your feedbacks!