Created attachment 125061 [details]
Broken BASIC example code indentation
The code example indentation seems broken throughout the BASIC help pages: just two spaces, no sub-indentation for statements.
Confirmed on Debian Jessie, 32-bit, with:
Build ID: a3123cd0105c1feec3a06d071c97cb758b307bf8
CPU Threads: 2; OS Version: Linux 4.3; UI Render: default;
TinderBox: Linux-rpm_deb-x86@71-TDF, Branch:master, Time: 2016-05-15_10:23:02
Locale: en-US (en_US.UTF-8)
I can confirm with Version: 18.104.22.168.alpha1+
Build ID: eb7593daa4bac21bd68182c8bbbd3ee3bd7b64dd
CPU Threads: 4; OS Version: Linux 4.4; UI Render: default;
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2016-05-03_07:06:45
This seems to be a regression from...
Author: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Date: Mon Jan 25 20:07:10 2016 +0100
fix validation errors by round-trip through helpauthoring extension
nope, no regression. That string was a single string before already.
-<paragraph role="bascode" id="par_id3150400" xml-lang="en-US" oldref="4">Select Case condition Case expression Statement Block [Case expression2 Statement Block][Case Else] Statement Block End Select</paragraph>
+<paragraph id="par_id3150400" role="bascode" xml-lang="en-US">Select Case condition Case expression Statement Block [Case expression2 Statement Block][Case Else] Statement Block End Select</paragraph>
Reassigning to Olivier to decide what's the best time to fix it/whether to fix for 5.2 or not (next week is string freeze)
sorry, looking closely I see the regression - should have looked at the actual sample below, that indeed loses the indent/did flatten it.
so bug in helpauthoring extension..
changing most of those should not affect translators, as they have localize="false" attribute already.
I'll take this for recovering the missing indent in the helpcontent repo, though it appears that the help extension has a bug here in causing the indent to go away in the first place which I won't personally address
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-5-2":
Resolves: tdf#99861 Recover lost basic in help indentation
fix-up is in master too