Created attachment 125197 [details] bt + console logs On pc Debian x86-64 with master sources updated today + brand new profile, I got a crash when changing Locale Settings. Steps to reproduce: 1) Launch LO 2) Menu Tools/Options 3) Language Settings/Languages 4) Change Locale Setting 5) Click OK => Crash
I don't reproduce this with LO Debian package 5.1.3.2 I found that the commit which caused regression was: https://cgit.freedesktop.org/libreoffice/core/commit/?id=0f6725454823a5789f3e1c70dad024c46d3f6fc9 this part specifically: diff --git a/unotools/source/config/options.cxx b/unotools/source/config/options.cxx index 28b64bb..e336775 100644 --- a/unotools/source/config/options.cxx +++ b/unotools/source/config/options.cxx @@ -68,8 +68,8 @@ void ConfigurationBroadcaster::NotifyListeners( sal_uInt32 nHint ) nHint |= m_nBlockedHint; m_nBlockedHint = 0; if ( mpList ) { - for ( size_t n = 0; n < mpList->size(); n++ ) { - (*mpList)[ n ]->ConfigurationChanged( this, nHint ); + for (ConfigurationListener* n : *mpList) { + n->ConfigurationChanged( this, nHint ); } } }
I got this after building master last weekend on Windows 7, but couldn't reproduce with one of the daily builds this week, so I thought it was gone. Apparently it isn't. As it's a crash, and right before the beta, raising priority to critical.
Noel, could you take a look?
gcc (Debian 5.3.1-19) Noel: I don't know why modernize-loop-convert doesn't work in this specific case. So for the moment, it seems to me that the only way to avoid the crash is to revert this specific part of the commit. Any thoughts?
Sorry Aron, I've overwriten the status when I've applied my changes. I put it back to NEW/critical
Created attachment 125201 [details] Error screenshot This is the error message with: Win10x64 Version: 5.2.0.0.alpha1+ Build ID: 7b704dfbdb23540ff6366fa60c73474bbda9dc26 CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; TinderBox: Win-x86@39, Branch:master, Time: 2016-05-20_05:45:40 after click on skip (omitir) I can follow without restart.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=3a077c0c3f41575cdce7e7e2f65916b0e8eb85dd tdf#99973 - Crash when changing Locale Setting in options It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I'll set this as fixed seeing as NoelGs comments suggests that
On pc Debian x86-64 with master sources updated today, I confirm I don't reproduce this. Thank you Noel for the fix.