Download it now!
Bug 100632 - SIDEBAR, FILEOPEN: Certain Position & Size fields in Sidebar are not filled for this SVG
Summary: SIDEBAR, FILEOPEN: Certain Position & Size fields in Sidebar are not filled f...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
5.0.0.5 release
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard: target:5.3.0 target:7.0.0
Keywords: bibisected, bisected, needUITest, regression
Depends on:
Blocks: Sidebar-Properties Sidebar-Properties-PositionAndSize
  Show dependency treegraph
 
Reported: 2016-06-27 02:36 UTC by Aron Budea
Modified: 2020-05-20 08:32 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Aron Budea 2016-06-27 02:36:11 UTC
Open this attachment from bug 99088 in Draw:
https://bugs.documentfoundation.org/attachment.cgi?id=124072

Select the rectangle. You will see the following Horizontal/Vertical positions/Width/Height in the Sidebar:
-4.4.0.3: 0.07/0.07/0.84/0.08
-5.0.0.5 & 5.1.4.2: 0.07/0.00/0.84/0.08
-5.2.0.1: 0.07/0.00/0.84/0.00

=> regression
There was a fix to bug 82616, which might be related (pushed for 4.5/5.0).
Bug 99711 might also be a distant relative.


There is an additional, related issue that existed from the introduction of the Sidebar.
Sidebar's Position and Size doesn't display the exact same values as right click -> Position and Size...
In 4.3.0.4:
-Sidebar: 0.07/0.07/0.84/0.08
-Dialog: 0.07/0.07/0.85/0.07

(note a naming inconsistency: Position X/Position Y in dialog vs. Horizontal/Vertical in Sidebar)

Setting confirmed based on Heiko's reply:
https://bugs.documentfoundation.org/show_bug.cgi?id=99088#c13
Comment 1 Commit Notification 2016-07-10 18:13:39 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=c25ee07a77a5ff278804aa3dbd8dbfcc3ac3ca46

Related: tdf#100632 naming consistency

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 2 Heiko Tietze 2016-07-14 09:24:30 UTC
Positional values in the sidebar still don't get updated.

Is: 0.07/0.00/0.84/0.00 
Expected: 0.07/0.07/0.84/0.07 (according the position & size dialog)

Version: 5.3.0.0.alpha0+
Build ID: b93cfe09c21b996cd3f1c40037e0ebf712922006
CPU Threads: 8; OS Version: Linux 4.6; UI Render: default; 
Locale: de-DE (de_DE.UTF8); Calc: group
Comment 3 Aron Budea 2016-08-30 07:55:14 UTC Comment hidden (bibisection)
Comment 4 Aron Budea 2016-08-30 07:59:00 UTC
Katarina, can you please take a look? This concerns the 2nd 0.07 becoming 0.00 in the Sidebar (Unit of Measurement has to be set to Centimeters).

The other 0.00 needs to be bibisected separately, but might be in the same piece of code.


c97b9bf218da33e15639134ef609a8c4c3820553 is the first bad commit
commit c97b9bf218da33e15639134ef609a8c4c3820553
Author: Matthew Francis <mjay.francis@gmail.com>
Date:   Wed May 27 16:48:36 2015 +0800

    source-hash-1386c348f81738a9966d1217db89d1f603466317
    
    commit 1386c348f81738a9966d1217db89d1f603466317
    Author:     Katarina Behrens <bubli@bubli.org>
    AuthorDate: Fri Nov 28 11:20:04 2014 +0100
    Commit:     Katarina Behrens <bubli@bubli.org>
    CommitDate: Sat Nov 29 08:18:34 2014 +0000
    
        fdo#82616: set limits on spinboxes according to size of workarea
    
        Do it the same way as position'n'size dialog does, for that matter
        move shared code into a separate header/class.
    
        This fixes regression from .ui migration that omitted spinbox limits
    
        Change-Id: I884904719b2608dd80aecc5d7ffb3923de71774d
        Reviewed-on: https://gerrit.libreoffice.org/13174
        Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
        Reviewed-by: Katarina Behrens <bubli@bubli.org>
Comment 5 Aron Budea 2016-08-31 21:56:11 UTC
Xisco, the bibisectRequest is still valid for this change, since I only bibisected the one between 4.4 and 5.0:
-5.0.0.5 & 5.1.4.2: 0.07/0.00/0.84/0.08
-5.2.0.1: 0.07/0.00/0.84/0.00

I don't know if there's a protocol for that, but I added an extra whiteboard tag for clarification.
Comment 6 Aron Budea 2016-09-18 03:52:45 UTC
The second change is caused by this commit:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=0acbf9404a40e5ca87642af299218846d51cf009

tdf#82396:Incorrect behavior on update of Size values in sidebar

Rishabh, can you please take a look?
Comment 7 QA Administrators 2017-12-21 03:37:26 UTC Comment hidden (obsolete)
Comment 8 Aron Budea 2017-12-22 11:35:58 UTC
Still the same in 6.0.0.1 / Windows 7.
Comment 9 QA Administrators 2019-10-29 03:29:17 UTC Comment hidden (obsolete)
Comment 10 Aron Budea 2020-03-24 09:09:50 UTC
The selection rectangle is wrong since 6.1, reported bug 131523 on that. Thus the  exact numbers can't be verified, but they are filled now.

1. Height is filled since bug 111922's fix.

2. Position fields are filled since the following commit:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=c85fcc6e1994eb8e079aaca85066ab4d67149c15
author		Caolán McNamara <caolanm@redhat.com>	2019-12-23 16:05:02 +0000
committer	Caolán McNamara <caolanm@redhat.com>	2019-12-30 10:39:48 +0100

"weld PosSizePropertyPanel"

Let's assume fixed. Thanks to Gabor Kelemen and Caolán McNamara!