Bug 100784 - Keyboard shortcuts don't work in Mac full screen mode due to hidden menu bar
Summary: Keyboard shortcuts don't work in Mac full screen mode due to hidden menu bar
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: Other Mac OS X (All)
: medium normal
Assignee: Maxim Monastirsky
URL:
Whiteboard: target:6.1.0 target:6.0.3
Keywords:
Depends on:
Blocks: Shortcuts-Accelerators Full-Screen-Mode
  Show dependency treegraph
 
Reported: 2016-07-06 13:51 UTC by gil
Modified: 2018-04-13 11:53 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments
Bibisect (2.37 KB, text/plain)
2018-02-05 22:08 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description gil 2016-07-06 13:51:49 UTC
User-Agent:       Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_5) AppleWebKit/601.6.17 (KHTML, like Gecko) Version/9.1.1 Safari/601.6.17
Build Identifier: LibreOffice 5.1.4.2

The following shortcuts work OK in windowed mode (normal and maximised) but fail to work in Full Screen Mode:

Cmd+<Number> (Heading and Text Body styles)
Cmd+B  (Bold)
Cmd+I  (Italic)


Reproducible: Always

Steps to Reproduce:
A (New Document version)
1. Start LO by double clicking the application icon in the Finder
2. Select Create → Writer Document
3. Type the word “Test”
4. Select View Menu → Full Screen OR Press Shift+Cmd+J to enter Full Screen Mode
5. Highlight the word “Test” and press Cmd+1 (or any shortcut listed in Details)

B (Recent Document version)
1. Start LO by double clicking the application icon, then open a Recent Document by tapping its thumbnail. Or just double click an existing .odt file in the Finder.
2. Press Shift+Cmd+J to enter Full Screen Mode (do NOT use View Menu → Full Screen)
3. Highlight some text and press Cmd+1 (or any shortcut listed in Details)



Actual Results:  
The style or formatting doesn't get applied. 

Expected Results:  
If pressing Cmd+1, the Heading 1 style should be applied to the highlighted text, and the format should change (the text should become bold and the font size should increase).

[Information automatically included from LibreOffice]
Locale: en-US
Module: StartModule
[Information guessed from browser]
OS: Mac OS X (All)
OS is 64bit: no

  Model Name:	MacBook Pro
  Model Identifier:	MacBookPro6,1
  Processor Name:	Intel Core i5
  Processor Speed:	2.53 GHz
  Number of Processors:	1
  Total Number of Cores:	2
  L2 Cache (per Core):	256 KB
  L3 Cache:	3 MB
  Memory:	8 GB
  


Reset User Profile?No
Comment 1 gil 2016-07-06 14:25:00 UTC
In the case of B (Recent Document version) there is some additional behaviour which may or may not be useful:

The formatting operation only fails when I use Shift+Cmd+J in step 2. And thereafter the problem persists until I restart LO - no matter how often I toggle between windowed and Full Screen mode, and whichever method I use to go Full Screen (shortcut or menu clicks).

If, on the other hand, I use the menu option View Menu → Full Screen in step 2, the heading style will be applied as expected. And thereafter it will continue to work properly – whichever method I subsequently use to go Full Screen (shortcut or menu clicks). So, when editing an existing document, this is a possible workaround.

However, in the case of A (creating a new document), it doesn't matter whether I use the shortcut or the menu clicks to go Full Screen initially - the formatting fails either way. The way forward here is to save the document early, then reopen it and use the workaround for case B above.
Comment 2 V Stuart Foote 2016-07-07 23:04:35 UTC
@Steve-- one for your QA...
Comment 3 Alex Thurgood 2016-07-18 08:47:30 UTC
With 
Version: 5.3.0.0.alpha0+
Build ID: 33d58de8c05d7a3591ac81164c1786d183a09991
CPU Threads: 2; OS Version: Mac OS X 10.11.5; UI Render: default; 
Locale: fr-FR (fr.UTF-8)

Shift+Cmd+J does nothing, the app window remains unchanged.
The keyboard shortcut has been changed to Ctrl+Cmd+F which is the OSX default fullscreen keyboard shortcut.


Pressing Cmd+1 in a fullscreened Writer document applies the style, so this is WFM in master 5.3alpha
Comment 4 Alex Thurgood 2016-07-18 08:50:40 UTC
Also WFM in

Version: 5.2.0.0.beta2
Build ID: ae12e6f168ba39f137fc110174a37c482ce68fa4
CPU Threads: 2; OS Version: Mac OS X 10.11.5; UI Render: default; 
Locale: fr-FR (fr.UTF-8)
Comment 5 gil 2016-07-20 10:51:40 UTC
Thanks Stuart and Alex,

Great to know this is fixed in version 5.2
Comment 6 gil 2016-08-23 14:21:19 UTC
Sadly still not WFM in LO 5.2.0.4, on a fresh installation of OS X 10.11.5. Same with OS X 10.11.6.

Version: 5.2.0.4
Build ID: 066b007f5ebcc236395c7d282ba488bca6720265
CPU Threads: 4; OS Version: Mac OS X 10.11.6; UI Render: default; 
Locale: en-US (en.UTF-8)
Comment 7 steve -_- 2016-08-23 14:35:11 UTC Comment hidden (obsolete)
Comment 8 gil 2016-08-23 17:46:46 UTC Comment hidden (obsolete)
Comment 9 steve -_- 2016-08-23 18:11:39 UTC
Confirming → NEW
Comment 10 steve -_- 2016-08-23 18:14:44 UTC
Already broken in Version: 5.1.4.2 likely earlier or always.
Comment 11 steve -_- 2016-08-23 18:26:05 UTC
existing in 3.3.0.4 so inherited from OOo
Comment 12 QA Administrators 2017-10-23 13:59:38 UTC Comment hidden (obsolete)
Comment 13 gil 2017-11-21 15:09:41 UTC
I can confirm that this bug is still present in:

Version: 5.4.3.2
Build ID: 92a7159f7e4af62137622921e809f8546db437e5
CPU threads: 4; OS: Mac OS X 10.11.6; UI render: default; 
Locale: en-US (en.UTF-8); Calc: group

The Full Screen shortcut keys have changed from Shift+Cmd+J to Ctrl+Cmd+F, but the bug remains the same.

This has been a showstopper for me - I haven't used LO on OSX because of it. Hope it can be resolved soon.
Comment 14 gil 2018-02-05 12:38:43 UTC
Still present in:

Version: 6.0.0.3
Build ID: 64a0f66915f38c6217de274f0aa8e15618924765
CPU threads: 4; OS: Mac OS X 10.11.6; UI render: default; 
Locale: en-US (en.UTF-8); Calc: group

@steve -_- : is anyone working on this? It surely can't be that difficult to fix...
Comment 15 Yousuf Philips (jay) (retired) 2018-02-05 19:26:22 UTC
Telesto, Xisco, Tor: are any of you guys able to repo this on a Mac, as Steve repos it and Alex doesnt.
Comment 16 Telesto 2018-02-05 21:44:05 UTC
Repro. However depending on the order
Version: 6.1.0.0.alpha0+
Build ID: d1bc14b318c9a412a761d243085da0895a1aed4a
CPU threads: 4; OS: Mac OS X 10.13.3; UI render: default; 
Locale: nl-NL (nl_US.UTF-8); Calc: group threaded

No issue in scenario A
1. Type TEST to a document
2. View Menu → Full Screen
3. Select text (CTRL+A) and CTRL+B 

However broken in:

Scenario B
1. Type test to a document
2. Press CTRL CMD F
3. Select text (CTRL+A)
4. CTRL+B

Scenario C
1. Type test to a document
2. Select text (CTRL+A)
3. View Menu → Full Screen
4. CTRL+B

It's permanent in all cases. So it keeps working if you follow the steps of scenario A. It will break when following B or C (and LibO needs a restart to undo the effect). 

So, pressing a key combo before entering Full screen mode seems to break things
Comment 17 Telesto 2018-02-05 22:08:47 UTC Comment hidden (obsolete)
Comment 18 Telesto 2018-02-06 10:56:16 UTC
The description given here bug 49853 comment 142 seems to fit perfectly
Comment 19 Yousuf Philips (jay) (retired) 2018-02-07 16:47:31 UTC
(In reply to Telesto from comment #18)
> The description given here bug 49853 comment 142 seems to fit perfectly

Yep that seems to be the problem, as when i removed Bold from the menu, the shortcut worked fine in full screen mode.

@Maxim: as you fixed bug 49853, what do you think should be the fix here?
Comment 20 Maxim Monastirsky 2018-02-08 00:06:03 UTC
Hope this quick patch will do the trick:

https://gerrit.libreoffice.org/49399/
Comment 21 Commit Notification 2018-02-08 13:43:14 UTC
Maxim Monastirsky committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=9d77e7551e56b85d7f1b40bc42b9ba6876091f22

tdf#100784 macOS: Don't attempt to handle shortcuts via the menubar

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 22 Yousuf Philips (jay) (retired) 2018-02-13 07:49:52 UTC
Maxim: as your patch mentions to not do this in full screen mode, is there a reason why its doing it in regular mode?
Comment 23 Maxim Monastirsky 2018-02-13 21:23:02 UTC
(In reply to Yousuf Philips (jay) from comment #22)
> Maxim: as your patch mentions to not do this in full screen mode, is there a
> reason why its doing it in regular mode?
Because that's how any other native Mac app works. You can see it in other apps, that when pressing a shortcut which has an entry in the menu, the top level menu item blinks (e.g. when pressing Cmd+C for Copy, the Edit menu blinks). What actually happens is that a click on the corresponding menu item is simulated, instead of letting the app handle the shortcut directly as a keyboard event. Of course we're free to not follow this, at the cost of losing the menu blinking visual effect.
Comment 24 Yousuf Philips (jay) (retired) 2018-02-14 10:31:06 UTC
Thanks for the info Maxim, as i'm a Mac novice. :D

So will LO register this shortcut behaviour as a menu item activation or a shortcut execution, as this would cause problems to usage metrics collection?
Comment 25 gil 2018-02-15 12:20:55 UTC
To Maxim, Yousuf and Telesto,

Many thanks for taking this on. 

Is this the patched image file:

https://dev-builds.libreoffice.org/daily/libreoffice-6-0/MacOSX-x86_64@49-TDF/2018-02-08_09.36.00/libreoffice-6-0~2018-02-08_09.36.00_LibreOfficeDev_6.0.1.0.0_MacOS_x86-64.dmg ?

When I run it (in parallel with 6.0.0.3) the bug is still present. 

Maybe I am looking in the wrong place?
Comment 26 steve -_- 2018-02-15 13:15:47 UTC
@gilbox: since whiteboard has "target:6.1.0" as target, the 6.0.x branch will not have the fix (yet).
Comment 27 gil 2018-02-15 14:52:21 UTC
@steve -_- Thanks, I will wait for 6.1.0. Very happy to know this bug is fixed.
Comment 28 Yousuf Philips (jay) (retired) 2018-02-16 14:14:12 UTC
Backport was already submitted two days back, but still not merged yet.

https://gerrit.libreoffice.org/49707
Comment 29 Maxim Monastirsky 2018-02-18 01:12:46 UTC
(In reply to Yousuf Philips (jay) (retired) from comment #24)
> So will LO register this shortcut behaviour as a menu item activation or a
> shortcut execution, as this would cause problems to usage metrics collection?
It will see it as a menu item activation. But in fact, the current usage collection code doesn't seem to make any distinction between commands that were executed from a kb and those executed by a mouse click.
Comment 30 Commit Notification 2018-02-23 16:20:07 UTC
Maxim Monastirsky committed a patch related to this issue.
It has been pushed to "libreoffice-6-0":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=3b457cb8825882cadec44e0b0679d1e70051eb71&h=libreoffice-6-0

tdf#100784 macOS: Don't attempt to handle shortcuts via the menubar

It will be available in 6.0.2.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 31 gil 2018-03-04 15:27:24 UTC
Sorry to say the 6.0.2 patch is not WFM.

All three scenarios fail, including A (see comment 16).

Version: 6.0.2.1
Build ID: f7f06a8f319e4b62f9bc5095aa112a65d2f3ac89
CPU threads: 4; OS: Mac OS X 10.11.6; UI render: default; 
Locale: en-US (en.UTF-8); Calc: group
Comment 32 Maxim Monastirsky 2018-03-04 21:32:06 UTC
(In reply to gil from comment #31)
> Sorry to say the 6.0.2 patch is not WFM.
You're right. The patch present in the 6-0 branch, but not in 6-0-2. I'll correct the Whiteboard to reflect that.
Comment 33 gil 2018-03-06 15:08:22 UTC
Thanks Maxim, I'll look forward to 6.0.3
Comment 34 gil 2018-04-13 11:53:44 UTC
Glad to report full screen keyboard shortcuts are working perfectly in:

Version: 6.0.3.2
Build ID: 8f48d515416608e3a835360314dac7e47fd0b821
CPU threads: 4; OS: Mac OS X 10.11.6; UI render: default; 
Locale: en-GB (en.UTF-8); Calc: group

Big thanks to Maxim, steve, Yousuf, Telesto, Stuart, Alex and everyone involved with this fix. Now I can start writing again :^)