Bug 101181 - Support the OOXML Glow Effect for Pictures and Shapes
Summary: Support the OOXML Glow Effect for Pictures and Shapes
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: graphics stack (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: low enhancement
Assignee: Not Assigned
URL:
Whiteboard: target:7.0.0
Keywords:
Depends on:
Blocks: Images Shapes
  Show dependency treegraph
 
Reported: 2016-07-28 21:18 UTC by Luke
Modified: 2020-03-30 15:47 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
Example of Glow Effects (258.28 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2016-07-28 21:18 UTC, Luke
Details
Test cases (490.61 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2020-03-09 11:33 UTC, Regina Henschel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Luke 2016-07-28 21:18:13 UTC
Created attachment 126454 [details]
Example of Glow Effects

The the DrawingML 20.1.8.32 Glow Effect is stored in OOXML as <a:effectLst> and <a:glow> elements.[1] Such as:

<a:effectLst>
  <a:glow rad="292100">
    <a:srgbClr val="FF0000">
      <a:alpha val="50000"/>
    </a:srgbClr>
  </a:glow>
</a:effectLst>

Currently we do not support it. It's similar to a centered soft shadow like effect.
Comment 1 V Stuart Foote 2016-07-29 01:00:33 UTC
Why should we care about trying to implement these questionable OpenOfficeXML? They are not native to ODF and would each have to be parsed during filter import and "simulated" on drawing shapes.

blur
fill overlay 
glow
inner shadow
outer shadow
preset shadow
reflection
soft edge

Issue with import, and issues with export back to OOXML.

We gain what?

=-ref-=
http://officeopenxml.com/drwSp-effects.php
Comment 2 Luke 2016-07-29 22:04:25 UTC
Any improvement in MSO interoperability is a win.

I singled out this effect, because I've encountered it in several documents, one where a diagram was unreadable because of our lack of support. Of the other effects that you listed, 3/8 are shadow where we already have excellent support. We do our best to simulate them, and as long as no changes are made we pass the preserved OOXML values on export.

We don’t’ need to fully support this effect, just like we do not fully support all of the OOXML shadow parameters. However rendering something, even if it’s just a centered shadow, is better than what we do now.
Comment 3 Buovjaga 2016-08-10 14:40:14 UTC
Ok, if someone wishes to work on it..
Comment 4 Commit Notification 2020-03-03 14:53:28 UTC
Tamas Bunth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f9fc420dceb1ece2c98767da16a21aaff771f140

tdf#101181 Implement glow effect on shapes

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Regina Henschel 2020-03-09 11:33:48 UTC
Created attachment 158506 [details]
Test cases

What is the patch proposed to do? None of my test cases work.

Open attached file. It contains on each slide an object and a screen shot of how it looks in PowerPoint. I have tried it with Skia, with OpenGL, and without them. Tested with Version: 7.0.0.0.alpha0+ (x64)
Build ID: f61fa885ed929e7d4aea4d84b2ddadea4825eb18
CPU threads: 8; OS: Windows 10.0 Build 18362; UI render: default; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: CL
Comment 6 Buovjaga 2020-03-25 15:26:36 UTC
(In reply to Regina Henschel from comment #5)
> Created attachment 158506 [details]
> Test cases
> 
> What is the patch proposed to do? None of my test cases work.
> 
> Open attached file. It contains on each slide an object and a screen shot of
> how it looks in PowerPoint. I have tried it with Skia, with OpenGL, and
> without them.

Tamás was not in Cc
Comment 7 Commit Notification 2020-03-25 20:43:43 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5a100a3b62da5ea94d4707c10633023065e1d04f

tdf#101181: add sidebar panel for Glow effect

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Buovjaga 2020-03-26 18:38:15 UTC
Regina: I think I remember what's up: transparency is not yet implemented, so that explains the difference with MSO.
Comment 9 Commit Notification 2020-03-30 15:47:06 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/85ae85ee93c929785a4db6cf8dcd28c2a683f800

tdf#101181 related: fix SdrShadowTextAttribute::operator==

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.