Bug 101820 - DIALOG: Revise Page Style's Page tab
Summary: DIALOG: Revise Page Style's Page tab
Status: RESOLVED WONTFIX
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
5.3.0.0.alpha0+
Hardware: All All
: medium enhancement
Assignee: Heiko Tietze
URL:
Whiteboard:
Keywords:
Depends on: 67973
Blocks: Page-Style-Dialog
  Show dependency treegraph
 
Reported: 2016-08-31 15:16 UTC by Yousuf Philips (jay) (retired)
Modified: 2021-06-28 10:46 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
screenshot (60.45 KB, image/png)
2016-09-04 20:11 UTC, Yousuf Philips (jay) (retired)
Details
pageformatpage.ui (47.43 KB, application/x-designer)
2016-09-04 20:14 UTC, Yousuf Philips (jay) (retired)
Details
Screenshot with v7.2 (50.78 KB, image/png)
2021-06-21 11:51 UTC, Heiko Tietze
Details
Screenshot with patch applied (55.35 KB, image/png)
2021-06-24 14:10 UTC, Heiko Tietze
Details
Patch, second iteration (36.17 KB, image/jpeg)
2021-06-28 10:46 UTC, Heiko Tietze
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2016-08-31 15:16:28 UTC
After looking through all the elements in page tab of the page style dialog due to bug 67973, i believe it is worthwhile to revise the entire tab, so we dont have to look over its contents multiple times to fix all the minor bugs.

Here are the changes i believe should be made.

Paper Format section
1) 'Paper Format' heading label should be changed to 'Paper'
2) 'Format' label should be changed to 'Size'
3) 'Format' control width should be shrunk by a third
4) Add common page sizes for books, etc. like 6"x9"[1] and 5.5"x8.5"[2][3]

Margins section
1) Add preset list of margins above spinboxes from list available in sidebar
2) Add 'Synchronize' checkbox below spinboxes, similar to borders tab

Layout Settings section
1) 'Layout Settings' heading label should be change to 'Print', 'Printer', etc.
2) Move 'Paper tray' label and control here from Paper Format section

New Style or Format section
1) Move 'Text direction' label and control here from Paper Format and always be visible
2) Move 'Page Number' label and control here

Here are help pages for more info about the tab
https://help.libreoffice.org/Common/Page
https://help.libreoffice.org/Writer/Printing_Register-true

[1] https://en.wikipedia.org/wiki/Book_size
[2] https://en.wikibooks.org/wiki/Basic_Book_Design/Page_Size
[3] https://www.bookbaby.com/book-trim-sizes-and-binding-options
Comment 1 V Stuart Foote 2016-08-31 15:51:37 UTC
@Jay,

OK, no objections. But please remember the "Page setup" dialog is also used with configs for other modules--not just Writer. So this review has to be done for each before changing in Writer alone.

And, one of my long standing peeves is lack of margin settings in sidebar for Draw/Impress properties--and default for Draw pages like Impress Slides should be "none" rather than the default of 1cm/.39".
Comment 2 Cor Nouws 2016-09-01 08:29:38 UTC
@jay: can you please show a mockup of the shuffle and changes, esp. the right side of the dialog?
Also: I think that synchronize margin settings makes sense in Draw maybe, but not in Writer and Calc.
Comment 3 Yousuf Philips (jay) (retired) 2016-09-04 20:11:28 UTC
Created attachment 127148 [details]
screenshot

(In reply to V Stuart Foote from comment #1)
> OK, no objections. But please remember the "Page setup" dialog is also used
> with configs for other modules--not just Writer. So this review has to be
> done for each before changing in Writer alone.

Yes the new organization also works in Calc and Impress/Draw.

> And, one of my long standing peeves is lack of margin settings in sidebar
> for Draw/Impress properties--and default for Draw pages like Impress Slides
> should be "none" rather than the default of 1cm/.39".

Not sure why it is being brought up here.

(In reply to Cor Nouws from comment #2)
> @jay: can you please show a mockup of the shuffle and changes, esp. the
> right side of the dialog?

Enjoy.
Comment 4 Yousuf Philips (jay) (retired) 2016-09-04 20:14:24 UTC
Created attachment 127149 [details]
pageformatpage.ui

Here is the modified glade file for those who want to try it out (put it in /opt/libreofficedev5.3/share/config/soffice.cfg/cui/ui/) and for the dev who wants to implement the margin presets.
Comment 5 Cor Nouws 2016-09-04 20:59:26 UTC
(In reply to Yousuf Philips (jay) from comment #3)
> (In reply to Cor Nouws from comment #2)
> > @jay: can you please show a mockup of the shuffle and changes, esp. the
> > right side of the dialog?
> 
> Enjoy.

Thanks. It looks clean.
The section names 'Print' and 'Style' look as if they not fully/nicely cover what is in them, but hard to find better terms. Right and left page layout of course is also on the screen. And paper try mostly related to paper format, IMO. But I can live with it.
(Interesting that the Text direction can be set per page style (currently the case too).)
Comment 6 Heiko Tietze 2016-09-04 21:46:27 UTC
Before we start with the actual implementation we should flesh out the basics. I mean questions like two or more columns, indentation, relation of labels vs. controls etc., all what's declared in a guideline. This might end up in this ui. We started the discussion last year in the mailing list http://listarchives.libreoffice.org/global/design/msg07251.html and talked recently about alignment (both threads unfinished).
Comment 7 Yousuf Philips (jay) (retired) 2016-09-05 14:05:27 UTC
(In reply to Cor Nouws from comment #5)
> Thanks. It looks clean.

Glad you like it.

> The section names 'Print' and 'Style' look as if they not fully/nicely cover
> what is in them, but hard to find better terms.

They use the same 12px spacing used in 'Paper' and 'Margins'.

> Right and left page layout of course is also on the screen.

The options in Page layout are only useful when you print, as can be seen in 'only left' and 'only right', as it doesnt change anything that you see on the screen.

> And paper try mostly related to paper format, IMO.

Paper tray is a property of the printer you are printing from.

(In reply to Heiko Tietze from comment #6)
> Before we start with the actual implementation we should flesh out the
> basics. I mean questions like two or more columns, indentation, relation of
> labels vs. controls etc., all what's declared in a guideline.

The focus here is of better categorization of the headings and its controls, as issue of columns, indentation, etc. can be handled later.
Comment 8 Cor Nouws 2016-09-05 14:19:51 UTC
(In reply to Yousuf Philips (jay) from comment #7)
> The options in Page layout are only useful when you print, as can be seen in
> 'only left' and 'only right', as it doesnt change anything that you see on
> the screen.

Try setting different margin left and right, and look at the result when you choose Mirrored. Or give some hard breaks and look as result with Right Only (print preview/page count).
It's not just the paper output but clearly on the screen. Hence my 'reservation'.

> > And paper try mostly related to paper format, IMO.
> 
> Paper tray is a property of the printer you are printing from.

It's a property of the page settings, allowing to force printing from a certain tray. That could be size or orientation, but also same settings as all other pates, but with different paper (letter head for example).
So also hear, it's hard to catch the setting in a certain term.

NB: I didn't refer the check box Synchronize anymore. Though I don't think it's useful for most modules, I'm fine with it being there.
Comment 9 vamshi 2018-03-24 06:53:10 UTC Comment hidden (spam)
Comment 10 HamishSeymour 2020-03-30 13:44:13 UTC Comment hidden (spam)
Comment 11 Heiko Tietze 2021-06-21 11:51:06 UTC
Created attachment 173052 [details]
Screenshot with v7.2

This dialog has change slightly. But questions remain:

1. rename "Paper Format" to "Paper" and
   rename "Format" to "Size"
2. align "Orientation" options horizontally
3. add "Presets" to margins
4. move "Paper try" under "Layout Settings"
5. put "[ ] Use page line-spacing" (was: "Register-true") on top of "Reference Style"
6. add "Style" section for "Text direction" (requires tools > options > language > Asian or CJK enabled), "Page number", all newly introduced "Gutter" items, "Background"

My take:
1. Yes
2. No, since l10n might need some space
3. Some effort, gutter not include (see also bug 141720), but no objection
4. There might be a reason why this has an extra place
5. Looks weird in the proposal; better something like "Page line-spacing: [ ] Use"
6. Yes

Is this needed/desirable?
Comment 12 Heiko Tietze 2021-06-24 14:10:32 UTC
Created attachment 173169 [details]
Screenshot with patch applied

This would be my proposal, on Gerrit for review at https://gerrit.libreoffice.org/c/core/+/117791
Comment 13 Heiko Tietze 2021-06-28 10:46:23 UTC
Created attachment 173236 [details]
Patch, second iteration

We discussed this on Telegram. Page layout has the wrong position but the advantage is too small for my taste. Played around with a collapsed section for Print but this was rejected too. Abandoning.